Portability fixes for "make menuconfig"

This makes "make menuconfig" also work on systems where ncurses is not installed in a standard location (such as on NixOS).

This patch changes ccflags() so that it tries pkg-config first, and only if pkg-config fails does it go back to the fallback/manual checks. This is the same algorithm that ldflags() already uses.

[This patch is already applied upstream (will be part of linux v3.18):
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=be8af2d54a66911693eddc556e4f7a866670082b

I'm adding this instead of doing a full upstream kconfig sync because
(1) there was a conflict in one of the Buildroot kconfg patches (against linux 3.18-rc1), (2) adding this patch won't create any conflict next time someone re-syncs kconfig with linux and (3) because this is easier to review.
]

Signed-off-by Bj?rn Forsman <[email protected]>

---
 support/kconfig/lxdialog/check-lxdialog.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 support/kconfig/lxdialog/check-lxdialog.sh

Hum, whenever we do change in the kconfig code, we like them to be part of the patch series we have. See support/kconfig/README.buildroot for details. In this case, indeed, the fix is already upstream. But still, we would like to keep separated the base kconfig version (copied as-is from the kernel) from any further modification we have made.

Thanks!

On 26 October 2014 16:41, Thomas Petazzoni
<[email protected]> wrote:
[...]

Quoted 6 lines

Hum, whenever we do change in the kconfig code, we like them to be part of the patch series we have. See support/kconfig/README.buildroot for details. In this case, indeed, the fix is already upstream. But still, we would like to keep separated the base kconfig version (copied as-is from the kernel) from any further modification we have made.

Quoted 1 line

Thanks!

Ok. I understand. I'll try to do the re-sync as described in support/kconfig/README.buildroot then.

I've tried to re-sync with linux 3.18-rc1. Without luck. Quite frustrating. Something is changed upstream and I don't (yet) manage to fill in the missing bits of Make code to have Buildroot's "make menuconfig" work with these changes.

Would it be acceptable to add the patch posted in this thread directly to support/kconfig/patches/ instead?

Dear Bj?rn Forsman,

Quoted 4 lines · Bj?rn Forsman

I've tried to re-sync with linux 3.18-rc1. Without luck. Quite frustrating. Something is changed upstream and I don't (yet) manage to fill in the missing bits of Make code to have Buildroot's "make menuconfig" work with these changes.

Argh :/

At some point, Yann E. Morin was very active on the kbuild/kconfig code in the upstream Linux kernel. Maybe he can help there?

Quoted 2 lines

Would it be acceptable to add the patch posted in this thread directly to support/kconfig/patches/ instead?

Yes, it is acceptable. Especially if the patch description mentions that it's already upstream, it will help when we'll bump the kconfig code.

Quoted 9 lines · Thomas Petazzoni

Dear Bj?rn Forsman,

Quoted 4 lines · Bj?rn Forsman

I've tried to re-sync with linux 3.18-rc1. Without luck. Quite frustrating. Something is changed upstream and I don't (yet) manage to fill in the missing bits of Make code to have Buildroot's "make menuconfig" work with these changes.

Quoted 4 lines

Argh :/

At some point, Yann E. Morin was very active on the kbuild/kconfig code in the upstream Linux kernel. Maybe he can help there?

Sure. For someone familiar with this code, it is probably/hopefully trivial :-)

For a bit of background, it's support/kconfig/patches/06-br-build-system-integration.patch that doesn't apply, due to upstream (linux) commit 022af62d0190e1e3db63c19aeb5f51ae0612cd71 removing the code that the patch touches.

I started out by skipping 06-br-build-system-integration.patch, but I'm unable to glue the stuff back together. This is what happens now:

$ make menuconfig
mkdir -p /home/bfo/buildroot/output/build/buildroot-config/lxdialog
make CC="/run/current-system/sw/bin/gcc"
HOSTCC="/run/current-system/sw/bin/gcc"
obj=/home/bfo/buildroot/output/build/buildroot-config -C
support/kconfig -f Makefile.br mconf
make[1]: Entering directory `/home/bfo/buildroot/support/kconfig'
make[1]: *** No rule to make target
`/home/bfo/buildroot/output/build/buildroot-config/.tmp_gtkcheck',
needed by `/home/bfo/buildroot/output/build/buildroot-config/gconf.o'.
Stop.
make[1]: Leaving directory `/home/bfo/buildroot/support/kconfig'
make: *** [/home/bfo/buildroot/output/build/buildroot-config/mconf] Error 2

Quoted 3 lines

Quoted 2 lines

Would it be acceptable to add the patch posted in this thread directly to support/kconfig/patches/ instead?

Quoted 3 lines

Yes, it is acceptable. Especially if the patch description mentions that it's already upstream, it will help when we'll bump the kconfig code.

Great! But I'll wait and see if Yann has some inputs before going this route.

Best regards,
Bj?rn Forsman

Are you able to help with synchronizing linux/upstream kconfig with Buildroot? (See my failed attempt above.)

If you have no time, just let me know, and I'll add a patch in support/kconfig/patches/ instead of doing a full sync.

Dear Bj?rn Forsman,

Quoted 3 lines · Bj?rn Forsman

Are you able to help with synchronizing linux/upstream kconfig with Buildroot? (See my failed attempt above.)

Quoted 2 lines

If you have no time, just let me know, and I'll add a patch in support/kconfig/patches/ instead of doing a full sync.

I personally don't have the time this week, and I also know Yann is very busy as well this week. We might be able to help with that, but not before this WE or next week.

It's been a few weeks now, just thought I'd check in and see if you guys (Thomas, Yann) have some time now to look at synchronizing kconfig with upstream.

I'm in no rush, so just let me know whether you'd like to postpone or if I should just add this change as a separate patch file in the support/kconfig/patches/ directory.