staging: media: lirc: modify print calls

PATCH In review Aya Mahfouz 4 participants 6 messages Nov 4, 2014 – Nov 5, 2014

Subsystems (2)

Media (V4L/DVB) Staging

lore

Share & tools

lore

Aya Mahfouz

author

2014-11-04 21:43 UTC #0 lore raw

PATCH 1/1 staging: media: lirc: modify print calls

This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls.

Signed-off-by Aya Mahfouz <[email protected]>

---
 drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/media/lirc/lirc_zilog.c +2 -2

index 52f8e91..dca806a 100644
@@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	int ret;
 	bool tx_probe = false;
 
-	pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
+	dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
 		__func__, id->name, adap->nr, adap->name, client->addr);
 
 	/*

@@ -1631,7 +1631,7 @@ out_put_xx:
 out_put_ir:
 	put_ir_device(ir, true);
 out_no_ir:
-	dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
+	dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
 		    __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
 		   ret);
 	mutex_unlock(&ir_devices_lock);

Signature · 1 line

1.9.3

Mauro Carvalho Chehab

2014-11-05 10:17 UTC #1 lore raw

Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz <[email protected]> escreveu:

Quoted 2 lines

This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls.

Also doesn't apply. Probably made to apply on Greg's tree.

Regards,
Mauro

Quoted 28 lines

Signed-off-by Aya Mahfouz <[email protected]>

---
 drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/media/lirc/lirc_zilog.c +2 -2

index 52f8e91..dca806a 100644
@@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	int ret;
 	bool tx_probe = false;
 
-	pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
+	dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
 		__func__, id->name, adap->nr, adap->name, client->addr);
 
 	/*

@@ -1631,7 +1631,7 @@ out_put_xx:
 out_put_ir:
 	put_ir_device(ir, true);
 out_no_ir:
-	dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
+	dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
 		    __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
 		   ret);
 	mutex_unlock(&ir_devices_lock);

Aya Mahfouz

author

2014-11-05 13:43 UTC #2 lore raw

Quoted 11 lines · Mauro Carvalho Chehab

Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz <[email protected]> escreveu:
Quoted 2 lines
This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls.
Also doesn't apply. Probably made to apply on Greg's tree.
Regards,
Mauro

Yes, I submit patches to Greg's tree. Should I clone your tree?

Kind Regards,
Aya Saif El-yazal Mahfouz

Quoted 28 lines

Signed-off-by Aya Mahfouz <[email protected]>

---
 drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/media/lirc/lirc_zilog.c +2 -2

index 52f8e91..dca806a 100644
@@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	int ret;
 	bool tx_probe = false;
 
-	pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
+	dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
 		__func__, id->name, adap->nr, adap->name, client->addr);
 
 	/*

@@ -1631,7 +1631,7 @@ out_put_xx:
 out_put_ir:
 	put_ir_device(ir, true);
 out_no_ir:
-	dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
+	dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
 		    __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
 		   ret);
 	mutex_unlock(&ir_devices_lock);

Greg Kroah-Hartman

maintainer

2014-11-05 16:30 UTC #3 lore raw

Quoted 7 lines · Aya Mahfouz

Quoted 6 lines · Mauro Carvalho Chehab
Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz <[email protected]> escreveu:
Quoted 2 lines
This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls.

Quoted 8 lines

Quoted 5 lines
Also doesn't apply. Probably made to apply on Greg's tree.
Regards,
Mauro
Yes, I submit patches to Greg's tree. Should I clone your tree?

I'll take this one as it builds on a change in my tree.

thanks,

greg k-h

Sudip Mukherjee

2014-11-05 11:29 UTC #4 lore raw

In reply to Aya Mahfouz

Quoted 2 lines · Aya Mahfouz

This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls.

i think you should mention in the commit message why you are changing the device. and also for revised patch its better if you add version number in the subject. like this is v2.

thanks
sudip

Quoted 36 lines

Signed-off-by Aya Mahfouz <[email protected]>

---
 drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/media/lirc/lirc_zilog.c +2 -2

index 52f8e91..dca806a 100644
@@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	int ret;
 	bool tx_probe = false;
 
-	pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
+	dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
 		__func__, id->name, adap->nr, adap->name, client->addr);
 
 	/*

@@ -1631,7 +1631,7 @@ out_put_xx:
 out_put_ir:
 	put_ir_device(ir, true);
 out_no_ir:
-	dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
+	dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
 		    __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
 		   ret);
 	mutex_unlock(&ir_devices_lock);

Signature · 7 lines

1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Aya Mahfouz

author

2014-11-05 13:47 UTC #5 lore raw

Quoted 11 lines · Sudip Mukherjee

Quoted 2 lines · Aya Mahfouz
This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls.
i think you should mention in the commit message why you are changing the device. and also for revised patch its better if you add version number in the subject. like this is v2.
thanks
sudip

Thanks Sudip for your feedback. I use versions if I keep the same subject.

Kind Regards,
Aya Saif El-yazal Mahfouz

Quoted 36 lines

Signed-off-by Aya Mahfouz <[email protected]>

---
 drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/media/lirc/lirc_zilog.c +2 -2

index 52f8e91..dca806a 100644
@@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	int ret;
 	bool tx_probe = false;
 
-	pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n",
+	dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n",
 		__func__, id->name, adap->nr, adap->name, client->addr);
 
 	/*

@@ -1631,7 +1631,7 @@ out_put_xx:
 out_put_ir:
 	put_ir_device(ir, true);
 out_no_ir:
-	dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
+	dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
 		    __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
 		   ret);
 	mutex_unlock(&ir_devices_lock);

Signature · 7 lines

1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/