drm/panel: s6e8aa0: Update calls to gpiod_get*()
Subsystems (3)
PATCH 1/1 drm/panel: s6e8aa0: Update calls to gpiod_get*()
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
--- drivers/gpu/drm/panel/panel-s6e8aa0.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/gpu/drm/panel/panel-s6e8aa0.c +1 -6
@@ -1019,17 +1019,12 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi)return ret; } - ctx->reset_gpio =devm_gpiod_get (dev,"reset" ); + ctx->reset_gpio =devm_gpiod_get (dev,"reset" ,GPIOD_OUT_HIGH );if (IS_ERR (ctx->reset_gpio)) {dev_err (dev,"cannot get reset-gpios %ld\n" ,PTR_ERR (ctx->reset_gpio));return PTR_ERR (ctx->reset_gpio); } - ret =gpiod_direction_output (ctx->reset_gpio,1 ); -if (ret <0 ) { -dev_err (dev,"cannot configure reset-gpios %d\n" , ret); -return ret; - } ctx->brightness =GAMMA_LEVEL_NUM -1 ;
Signature · 1 line
2.1.2
PATCH 1/1 drm/panel: simple: Update calls to gpiod_get*()
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
--- drivers/gpu/drm/panel/panel-simple.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
drivers/gpu/drm/panel/panel-simple.c +2 -9
@@ -247,21 +247,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)if (IS_ERR (panel->supply))return PTR_ERR (panel->supply); - panel->enable_gpio =devm_gpiod_get_optional (dev,"enable" ); + panel->enable_gpio =devm_gpiod_get_optional (dev,"enable" , +GPIOD_OUT_LOW );if (IS_ERR (panel->enable_gpio)) { err =PTR_ERR (panel->enable_gpio);dev_err (dev,"failed to request GPIO: %d\n" , err);return err; } -if (panel->enable_gpio) { - err =gpiod_direction_output (panel->enable_gpio,0 ); -if (err <0 ) { -dev_err (dev,"failed to setup GPIO: %d\n" , err); -return err; - } - } - backlight =of_parse_phandle (dev->of_node,"backlight" ,0 );if (backlight) { panel->backlight =of_find_backlight_by_node (backlight);
Signature · 1 line
2.1.2
Re: [PATCH] drm/panel: simple: Update calls to gpiod_get*()
Quoted 10 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.Signed-off-by Alexandre Courbot <[email protected]>
Thierry, are you ok with this patch?
Thierry Reding
AppliedRe: [PATCH] drm/panel: simple: Update calls to gpiod_get*()
In reply to Alexandre CourbotQuoted 9 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
Quoted 4 lines
Signed-off-by Alexandre Courbot <[email protected]>--- drivers/gpu/drm/panel/panel-simple.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
Applied, thanks.
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.Signed-off-by Alexandre Courbot <[email protected]>
It needs patch "gpio: Fix gpio direction flags not getting set" to work correctly. It is not yet present in drm-next. Beside this:
--
Regards
Andrzej
Quoted 28 lines
--- drivers/gpu/drm/panel/panel-s6e8aa0.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)drivers/gpu/drm/panel/panel-s6e8aa0.c +1
-6@@ -1019,17 +1019,12 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi)return ret; } - ctx->reset_gpio =devm_gpiod_get (dev,"reset" ); + ctx->reset_gpio =devm_gpiod_get (dev,"reset" ,GPIOD_OUT_HIGH );if (IS_ERR (ctx->reset_gpio)) {dev_err (dev,"cannot get reset-gpios %ld\n" ,PTR_ERR (ctx->reset_gpio));return PTR_ERR (ctx->reset_gpio); } - ret =gpiod_direction_output (ctx->reset_gpio,1 ); -if (ret <0 ) { -dev_err (dev,"cannot configure reset-gpios %d\n" , ret); -return ret; - } ctx->brightness =GAMMA_LEVEL_NUM -1 ;
Quoted 10 lines · Andrzej Hajda
Quoted 9 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
Quoted 6 lines
Quoted 1 line
Signed-off-by Alexandre Courbot <[email protected]>It needs patch "gpio: Fix gpio direction flags not getting set" to work correctly. It is not yet present in drm-next. Beside this:
Acked-by Andrzej Hajda <[email protected]>
The required patch is now merged, can we go on with this patch?
Thierry Reding
AppliedQuoted 9 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
Quoted 4 lines
Signed-off-by Alexandre Courbot <[email protected]>--- drivers/gpu/drm/panel/panel-s6e8aa0.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks.
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel