: (error) Uninitialized variable: line
Hello,
cppcheck reports:
[common/cmd_ini.c:137]: (error) Uninitialized variable: line
can you please have a look? Thanks!
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de 365 Days of drinking Lo-Cal beer. = 1 Lite-year
Quoted 7 lines · Wolfgang Denk
Hello,
cppcheck reports:
[
common/cmd_ini.c:137]: (error) Uninitialized variable: linecan you please have a look? Thanks!
trini at bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --version Cppcheck 1.52
trini at bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --force --inline-suppr common/cmd_ini.c
Checking common/cmd_ini.c...
Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE... Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE... Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE...
Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME...
Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...
And I don't see anything. I did this since manually inspecting things and the code looks correct here but I could see cppcheck failing to figure it out (and I could see the code being optimized, we pass line as a pointer but then also return that back..).
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141106/34c13a86/attachment.pgp>
Dear Tom,
Quoted 3 lines · In message <20141106161600.GQ24724@bill-the-cat> you wrote:
trini at bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --version Cppcheck 1.52
-> cppcheck --version
Cppcheck 1.63
Quoted 7 lines
trini at bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --force --inline-suppr
common/cmd_ini.cCheckingcommon/cmd_ini.c...
Checkingcommon/cmd_ini.c:CONFIG_INI_ALLOW_MULTILINE...
Checkingcommon/cmd_ini.c:CONFIG_INI_CASE_INSENSITIVE...
Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_LINE...
Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_NAME...
Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_SECTION...
-> cppcheck --force --inline-suppr common/cmd_ini.c Checking common/cmd_ini.c...
Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE... Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE... Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE... [common/cmd_ini.c:137]: (error) Uninitialized variable: line Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME... Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...
Same result with Cppcheck 1.67
Quoted 4 lines
And I don't see anything. I did this since manually inspecting things and the code looks correct here but I could see cppcheck failing to figure it out (and I could see the code being optimized, we pass line as a pointer but then also return that back..).
To me it looks as if it complained due to possibly incorrect CONFIG_INI_MAX_LINE settings?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Put your Nose to the Grindstone!
-- Amalgamated Plastic Surgeons and Toolmakers, Ltd.Quoted 9 lines · Wolfgang Denk
Dear Tom,
Quoted 3 lines · In message <20141106161600.GQ24724@bill-the-cat> you wrote:
trini at bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --version Cppcheck 1.52
-> cppcheck --version
Cppcheck 1.63
Ah, OK.
Quoted 19 lines
Quoted 7 lines
trini at bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --force --inline-suppr
common/cmd_ini.cCheckingcommon/cmd_ini.c...
Checkingcommon/cmd_ini.c:CONFIG_INI_ALLOW_MULTILINE...
Checkingcommon/cmd_ini.c:CONFIG_INI_CASE_INSENSITIVE...
Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_LINE...
Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_NAME...
Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_SECTION...-> cppcheck --force --inline-suppr
common/cmd_ini.cCheckingcommon/cmd_ini.c...
Checkingcommon/cmd_ini.c:CONFIG_INI_ALLOW_MULTILINE... Checkingcommon/cmd_ini.c:CONFIG_INI_CASE_INSENSITIVE... Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_LINE... [common/cmd_ini.c:137]: (error) Uninitialized variable: line Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_NAME... Checkingcommon/cmd_ini.c:CONFIG_INI_MAX_SECTION...Same result with Cppcheck 1.67
Quoted 7 lines
Quoted 4 lines
And I don't see anything. I did this since manually inspecting things and the code looks correct here but I could see cppcheck failing to figure it out (and I could see the code being optimized, we pass line as a pointer but then also return that back..).
To me it looks as if it complained due to possibly incorrect
CONFIG_INI_MAX_LINEsettings?
Could be, but that'd be a compile-time failure if it's defined but not to a numerical value.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141106/e3c3087b/attachment.pgp>