Skip to contentSkip to conversation

usb: ehci: fix Interrupt on Doorbell flag of USBCMD

PATCH New Masahiro Yamada 2 participants 2 messages Nov 5, 2014 – Nov 6, 2014

Subsystems (2)
USB USB ehci driver
lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 usb: ehci: fix Interrupt on Doorbell flag of USBCMD

CMD_IAAD (Interrupt on Async Advance Doorbell) is bit 6, not bit 5. While we are here, sort the flags.

Signed-off-by Masahiro Yamada <[email protected]>

---

 drivers/usb/host/ehci.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/host/ehci.h +2 -2
index 433e703..79aecd4 100644
@@ -47,9 +47,9 @@ struct ehci_hcor {
 	uint32_t or_usbcmd;
 #define CMD_PARK	(1 << 11)		/* enable "park" */
 #define CMD_PARK_CNT(c)	(((c) >> 8) & 3)	/* how many transfers to park */
-#define CMD_ASE		(1 << 5)		/* async schedule enable */
 #define CMD_LRESET	(1 << 7)		/* partial reset */
-#define CMD_IAAD	(1 << 5)		/* "doorbell" interrupt */
+#define CMD_IAAD	(1 << 6)		/* "doorbell" interrupt */
+#define CMD_ASE		(1 << 5)		/* async schedule enable */
 #define CMD_PSE		(1 << 4)		/* periodic schedule enable */
 #define CMD_RESET	(1 << 1)		/* reset HC not bus */
 #define CMD_RUN		(1 << 0)		/* start/stop HC */
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 usb: ehci: fix Interrupt on Doorbell flag of USBCMD

Quoted 4 lines · Masahiro Yamada

CMD_IAAD (Interrupt on Async Advance Doorbell) is bit 6, not bit 5. While we are here, sort the flags.

Signed-off-by Masahiro Yamada <[email protected]>

Nice catch, applied, thanks!

Best regards,
Marek Vasut