bugon.cocci: fix Options at the macro
The comma after --no-includes makes coccinelle to not run the script:
/usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi -I ./include/linux/kconfig.h
Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
Options are:
--sp-file <file> the semantic patch file -o <file> the output file --in-place do the modification on the file directly --backup-suffix suffix to use when making a backup for inplace
...
At least with Fedora 20 coccinelle package:
coccinelle-1.0.0-0.rc20.1.fc21.x86_64
scripts/coccinelle/misc/bugon.cocci +1 -1
@@ -8,7 +8,7 @@ // Confidence: High // Copyright: (C) 2014 Himangi Saraogi. GPLv2. // Comments: -// Options: --no-includes, --include-headers +// Options: --no-includes --include-headers virtual patch virtual context
Julia Lawall
Acked-byThanks!
julia
Quoted 30 lines · Mauro Carvalho Chehab
The comma after --no-includes makes coccinelle to not run the script:
/usr/bin/spatch-D report --very-quiet --no-show-diff --cocci-file./scripts/coccinelle/misc/bugon.cocci--no-includes, --include-headers --patch . --dirdrivers/media/platform/coda/-I./arch/x86/include-Iarch/x86/include/generated-I include -I./arch/x86/include/uapi-Iarch/x86/include/generated/uapi-I./include/uapi-Iinclude/generated/uapi-I./include/linux/kconfig.h
Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
Options are:--sp-file <file> the semantic patch file -o <file> the output file --in-place do the modification on the file directly --backup-suffix suffix to use when making a backup for inplace...
At least with Fedora 20 coccinelle package:
coccinelle-1.0.0-0.rc20.1.fc21.x86_64Signed-off-by Mauro Carvalho Chehab <[email protected]>scripts/coccinelle/misc/bugon.cocci +1
-1@@ -8,7 +8,7 @@ // Confidence: High // Copyright: (C) 2014 Himangi Saraogi. GPLv2. // Comments: -// Options: --no-includes, --include-headers +// Options: --no-includes --include-headers virtual patch virtual context
Wolfram Sang
Tested-byQuoted 9 lines · Mauro Carvalho Chehab
The comma after --no-includes makes coccinelle to not run the script:
/usr/bin/spatch-D report --very-quiet --no-show-diff --cocci-file./scripts/coccinelle/misc/bugon.cocci--no-includes, --include-headers --patch . --dirdrivers/media/platform/coda/-I./arch/x86/include-Iarch/x86/include/generated-I include -I./arch/x86/include/uapi-Iarch/x86/include/generated/uapi-I./include/uapi-Iinclude/generated/uapi-I./include/linux/kconfig.h
Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
Options are:--sp-file <file> the semantic patch file -o <file> the output file --in-place do the modification on the file directly --backup-suffix suffix to use when making a backup for inplace
Quoted 6 lines
...
At least with Fedora 20 coccinelle package:
coccinelle-1.0.0-0.rc20.1.fc21.x86_64Signed-off-by Mauro Carvalho Chehab <[email protected]>
Yay, with this my patch handling scripts finally work again as they used to! Please let it go into 3.18.
Quoted 15 lines · Wolfram Sang
Quoted 14 lines · Mauro Carvalho Chehab
The comma after --no-includes makes coccinelle to not run the script:
/usr/bin/spatch-D report --very-quiet --no-show-diff --cocci-file./scripts/coccinelle/misc/bugon.cocci--no-includes, --include-headers --patch . --dirdrivers/media/platform/coda/-I./arch/x86/include-Iarch/x86/include/generated-I include -I./arch/x86/include/uapi-Iarch/x86/include/generated/uapi-I./include/uapi-Iinclude/generated/uapi-I./include/linux/kconfig.h
Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
Options are:--sp-file <file> the semantic patch file -o <file> the output file --in-place do the modification on the file directly --backup-suffix suffix to use when making a backup for inplace...
At least with Fedora 20 coccinelle package:
coccinelle-1.0.0-0.rc20.1.fc21.x86_64
Quoted 6 lines
Quoted 1 line
Signed-off-by Mauro Carvalho Chehab <[email protected]>Yay, with this my patch handling scripts finally work again as they used to! Please let it go into 3.18.
Tested-by Wolfram Sang <[email protected]>
Ping.
Dne 21.11.2014 v 19:07 Wolfram Sang napsal(a):
Quoted 16 lines · Wolfram Sang
Quoted 15 lines · Mauro Carvalho Chehab
Quoted 14 lines
The comma after --no-includes makes coccinelle to not run the script:
/usr/bin/spatch-D report --very-quiet --no-show-diff --cocci-file./scripts/coccinelle/misc/bugon.cocci--no-includes, --include-headers --patch . --dirdrivers/media/platform/coda/-I./arch/x86/include-Iarch/x86/include/generated-I include -I./arch/x86/include/uapi-Iarch/x86/include/generated/uapi-I./include/uapi-Iinclude/generated/uapi-I./include/linux/kconfig.h
Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
Options are:--sp-file <file> the semantic patch file -o <file> the output file --in-place do the modification on the file directly --backup-suffix suffix to use when making a backup for inplace...
At least with Fedora 20 coccinelle package:
coccinelle-1.0.0-0.rc20.1.fc21.x86_64
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Mauro Carvalho Chehab <[email protected]>Yay, with this my patch handling scripts finally work again as they used to! Please let it go into 3.18.
Tested-by Wolfram Sang <[email protected]>Ping.
Sorry for the delay. Applied now to kbuild.git#misc.
Michal