Skip to contentSkip to conversation

platform: x86: remove redundant variable in hp-wireless.c

PATCH In review Giedrius Statkevicius 3 participants 3 messages Nov 4, 2014 – Nov 7, 2014

Subsystems (2)
ACPI x86 platform drivers
lore
Share & tools
lore

Giedrius Statkevicius

author
#0 lore raw

PATCH 1/1 platform: x86: remove redundant variable in hp-wireless.c

Remove a variable because it only holds the results of a function call and then gets returned so instead just return the result of a function call.

Signed-off-by Giedrius Statkevičius <[email protected]>
---
 drivers/platform/x86/hp-wireless.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/platform/x86/hp-wireless.c +1 -4
index 415348f..670c62b 100644
@@ -82,10 +82,7 @@ static void hpwl_notify(struct acpi_device *acpi_dev, u32 event)
 
 static int hpwl_add(struct acpi_device *device)
 {
-	int err;
-
-	err = hp_wireless_input_setup();
-	return err;
+	return hp_wireless_input_setup();
 }
 
 static int hpwl_remove(struct acpi_device *device)
Signature · 1 line
2.1.3
#1 lore raw
Quoted 14 lines · Giedrius Statkevicius

Remove a variable because it only holds the results of a function call and then gets returned so instead just return the result of a function call.

Signed-off-by Giedrius Statkevičius <[email protected]>
---
 drivers/platform/x86/hp-wireless.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/platform/x86/hp-wireless.c +0 -0
index 415348f..670c62b 100644

drivers/platform/x86/hp-wireless.c static void hpwl_notify(struct acpi_device *acpi_dev, u32 event) · line 85

Quoted 8 lines
drivers/platform/x86/hp-wireless.c +1 -4
@@ -82,10 +82,7 @@ static void hpwl_notify(struct acpi_device *acpi_dev, u32 event)
 
 static int hpwl_add(struct acpi_device *device)
 {
-	int err;
-
-	err = hp_wireless_input_setup();
-	return err;
+	return hp_wireless_input_setup();

Since acpi_device_probe() does not print a warning if add() fails, it might be preferable to print the message here, rather than ignoring it completely.

Rafael?

Signature · 6 lines
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
Quoted 27 lines · Darren Hart
Quoted 14 lines · Giedrius Statkevicius

Remove a variable because it only holds the results of a function call and then gets returned so instead just return the result of a function call.

Signed-off-by Giedrius Statkevičius <[email protected]>
---
 drivers/platform/x86/hp-wireless.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/platform/x86/hp-wireless.c +0 -0
index 415348f..670c62b 100644

drivers/platform/x86/hp-wireless.c static void hpwl_notify(struct acpi_device *acpi_dev, u32 event) · line 85

Quoted 8 lines
drivers/platform/x86/hp-wireless.c +1 -4
@@ -82,10 +82,7 @@ static void hpwl_notify(struct acpi_device *acpi_dev, u32 event)
 
 static int hpwl_add(struct acpi_device *device)
 {
-	int err;
-
-	err = hp_wireless_input_setup();
-	return err;
+	return hp_wireless_input_setup();

Since acpi_device_probe() does not print a warning if add() fails, it might be preferable to print the message here, rather than ignoring it completely.

Quoted 1 line

Rafael?

Sounds reasonable.

Signature · 6 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html