Skip to contentSkip to conversation

mfd: twl4030-power: Support compatible = "ti,twl4030-power" again.

PATCH In review NeilBrown 3 participants 5 messages Nov 8, 2014 – Nov 10, 2014

Subsystems (2)
Multifunction devices (MFD) OMAP2+ support
lore
Share & tools
lore

NeilBrown

author
#0 lore raw

PATCH 1/1 mfd: twl4030-power: Support compatible = "ti,twl4030-power" again.

commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
mfd: twl4030-power: Add generic reset configuration

claims:
Let's add device tree support and configure things for warm reset as the default when compatible = "ti,twl4030-power".
and
Documentation/devicetree/bindings/mfd/twl4030-power.txt
claims that "ti,twl4030-power" is still a valid "compatible" setting.

However the current driver fails to probe with that 'compatible' setting.
Restore the old default.

Signed-off-by NeilBrown <[email protected]>
drivers/mfd/twl4030-power.c +4 -0
index 4d3ff3771491..1a7794f6be15 100644
@@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
 
 static struct of_device_id twl4030_power_of_match[] = {
 	{
+		.compatible = "ti,twl4030-power",
+		.data = NULL,
+	},
+	{
 		.compatible = "ti,twl4030-power-reset",
 		.data = &omap3_reset,
 	},
#1 lore raw

Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.

Am 08.11.2014 um 01:22 schrieb NeilBrown <[email protected]>:

Quoted 11 lines

commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
mfd: twl4030-power: Add generic reset configuration

claims:
Let's add device tree support and configure things for warm reset as the default when compatible = "ti,twl4030-power".
and
Documentation/devicetree/bindings/mfd/twl4030-power.txt
claims that "ti,twl4030-power" is still a valid "compatible" setting.

Quoted 3 lines

However the current driver fails to probe with that 'compatible' setting.
Restore the old default.

I think this is a duplicate to

599a1ca80d1d8269d54fdc4abdec8e65141381fe

(in linux-next)

Quoted 22 lines
Signed-off-by NeilBrown <[email protected]>
drivers/mfd/twl4030-power.c +4 -0
index 4d3ff3771491..1a7794f6be15 100644
@@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
 
 static struct of_device_id twl4030_power_of_match[] = {
 	{
+		.compatible = "ti,twl4030-power",
+		.data = NULL,
+	},
+	{
 		.compatible = "ti,twl4030-power-reset",
 		.data = &omap3_reset,
 	},

_______________________________________________
Gta04-owner mailing list
[email protected]
http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner

author
#2 lore raw

Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.

Quoted 18 lines · On Sat, 8 Nov 2014 08:24:28 +0100 "Dr. H. Nikolaus Schaller"…

Am 08.11.2014 um 01:22 schrieb NeilBrown <[email protected]>:

Quoted 11 lines

commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
mfd: twl4030-power: Add generic reset configuration

claims:
Let's add device tree support and configure things for warm reset as the default when compatible = "ti,twl4030-power".
and
Documentation/devicetree/bindings/mfd/twl4030-power.txt
claims that "ti,twl4030-power" is still a valid "compatible" setting.

Quoted 3 lines

However the current driver fails to probe with that 'compatible' setting.
Restore the old default.

Quoted 5 lines

I think this is a duplicate to

599a1ca80d1d8269d54fdc4abdec8e65141381fe

(in linux-next)

Ahh, so it is. Thanks.

NeilBrown

Quoted 23 lines
Quoted 23 lines
Signed-off-by NeilBrown <[email protected]>
drivers/mfd/twl4030-power.c +4 -0
index 4d3ff3771491..1a7794f6be15 100644
@@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
 
 static struct of_device_id twl4030_power_of_match[] = {
 	{
+		.compatible = "ti,twl4030-power",
+		.data = NULL,
+	},
+	{
 		.compatible = "ti,twl4030-power-reset",
 		.data = &omap3_reset,
 	},

_______________________________________________
Gta04-owner mailing list
[email protected]
http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner

#3 lore raw

Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.

Quoted 21 lines · NeilBrown
Quoted 18 lines · On Sat, 8 Nov 2014 08:24:28 +0100 "Dr. H. Nikolaus Schaller"…

Am 08.11.2014 um 01:22 schrieb NeilBrown <[email protected]>:

Quoted 14 lines

commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
mfd: twl4030-power: Add generic reset configuration

claims:
Let's add device tree support and configure things for warm reset as the default when compatible = "ti,twl4030-power".
and
Documentation/devicetree/bindings/mfd/twl4030-power.txt
claims that "ti,twl4030-power" is still a valid "compatible" setting.

However the current driver fails to probe with that 'compatible' setting.
Restore the old default.

Quoted 8 lines
Quoted 5 lines

I think this is a duplicate to

599a1ca80d1d8269d54fdc4abdec8e65141381fe

(in linux-next)

Ahh, so it is. Thanks.

Just read this.

Previous reply withdrawn.

Quoted 22 lines
Quoted 21 lines
Quoted 21 lines
Signed-off-by NeilBrown <[email protected]>
drivers/mfd/twl4030-power.c +4 -0
index 4d3ff3771491..1a7794f6be15 100644
@@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
 
 static struct of_device_id twl4030_power_of_match[] = {
 	{
+		.compatible = "ti,twl4030-power",
+		.data = NULL,
+	},
+	{
 		.compatible = "ti,twl4030-power-reset",
 		.data = &omap3_reset,
 	},

_______________________________________________
Gta04-owner mailing list
[email protected]
http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#4 lore raw
In reply to NeilBrown
Quoted 11 lines · NeilBrown

commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
mfd: twl4030-power: Add generic reset configuration

claims:
Let's add device tree support and configure things for warm reset as the default when compatible = "ti,twl4030-power".
and
Documentation/devicetree/bindings/mfd/twl4030-power.txt
claims that "ti,twl4030-power" is still a valid "compatible" setting.

Quoted 5 lines

However the current driver fails to probe with that 'compatible' setting.
Restore the old default.

Signed-off-by NeilBrown <[email protected]>

Tony should take a look at this.

Quoted 15 lines
drivers/mfd/twl4030-power.c +4 -0
index 4d3ff3771491..1a7794f6be15 100644
@@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
 
 static struct of_device_id twl4030_power_of_match[] = {
 	{
+		.compatible = "ti,twl4030-power",
+		.data = NULL,
+	},
+	{
 		.compatible = "ti,twl4030-power-reset",
 		.data = &omap3_reset,
 	},
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog