Skip to contentSkip to conversation

sound: enable sound support on n900 on devicetree-based boot

PATCH Applied Pavel Machek 2 participants 5 messages Nov 9, 2014 – Nov 10, 2014

Subsystems (2)
Sound ASoC
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.

This makes sound work on my n900 under 3.18-rc1.

Signed-off-by Pavel Machek <[email protected]>
sound/soc/omap/Kconfig +1 -1
index d44463a..0d7b707 100644
@@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
 
 config SND_OMAP_SOC_RX51
 	tristate "SoC Audio support for Nokia RX-51"
-	depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
+	depends on SND_OMAP_SOC && ARM && I2C
 	select SND_OMAP_SOC_MCBSP
 	select SND_SOC_TLV320AIC3X
 	select SND_SOC_TPA6130A2
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 4 lines · Pavel Machek

With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.

Please do try to use subject lines reflecting the style for the subsystem.

sound/soc/omap/Kconfig config SND_OMAP_SOC_N810 · line 29

Quoted 4 lines

config SND_OMAP_SOC_RX51

sound/soc/omap/Kconfig +1 -1
 	tristate "SoC Audio support for Nokia RX-51"
-	depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
+	depends on SND_OMAP_SOC && ARM && I2C

Please also update the config text so users have a chance to figure out that this driver is the one they need for their system - I guess most people won't know what RX-51 is.

author
#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 4 lines · Pavel Machek

With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.

Please do try to use subject lines reflecting the style for the subsystem.

Ok.

Quoted 8 lines

sound/soc/omap/Kconfig config SND_OMAP_SOC_N810 · line 29

Quoted 4 lines

config SND_OMAP_SOC_RX51

sound/soc/omap/Kconfig +1 -1
 	tristate "SoC Audio support for Nokia RX-51"
-	depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
+	depends on SND_OMAP_SOC && ARM && I2C

Please also update the config text so users have a chance to figure out that this driver is the one they need for their system - I guess most people won't know what RX-51 is.

Actually help text below already explains that. I'll update tristate text, too.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#3 lore raw

ASoC: omap: enable sound support on n900 on devicetree-based boot

In reply to Mark Brown

With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.

This makes sound work on my n900 under 3.18-rc1.

Signed-off-by Pavel Machek <[email protected]>
sound/soc/omap/Kconfig +4 -4
index d44463a..2738b19 100644
@@ -25,15 +25,15 @@ config SND_OMAP_SOC_N810
 	  Say Y if you want to add support for SoC audio on Nokia N810.
 
 config SND_OMAP_SOC_RX51
-	tristate "SoC Audio support for Nokia RX-51"
-	depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
+	tristate "SoC Audio support for Nokia N900 (RX-51)"
+	depends on SND_OMAP_SOC && ARM && I2C
 	select SND_OMAP_SOC_MCBSP
 	select SND_SOC_TLV320AIC3X
 	select SND_SOC_TPA6130A2
 	depends on GPIOLIB
 	help
-	  Say Y if you want to add support for SoC audio on Nokia RX-51
-	  hardware. This is also known as Nokia N900 product.
+	  Say Y if you want to add support for SoC audio on Nokia N900
+	  cellphone.
 
 config SND_OMAP_SOC_AMS_DELTA
 	tristate "SoC Audio support for Amstrad E3 (Delta) videophone"
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Applied
#4 lore raw

Re: ASoC: omap: enable sound support on n900 on devicetree-based boot

Quoted 3 lines · Pavel Machek

With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.

Applied, thanks.