Skip to contentSkip to conversation

Tiny dts change breaks boot on n900

PATCH Pavel Machek 4 participants 6 messages Nov 10, 2014 – Nov 16, 2014 Device tree bindings

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

I'm confused:

This fixes boot on n900. Strange thing is ... adp1653 driver is not even compiled in -- it is module.

It looks like tiny change in dts noone should care about breaks boot... I don't even have adp1653 device parsing code written.

Something similar happened before -- change in device tree order broke boot.

Any ideas? What is going on?
Pavel

arch/arm/boot/dts/omap3-n900.dts +0 -5
index f3118bf..557a19e 100644
@@ -565,11 +565,6 @@
 	adp1653: adp1653 at 30 {
 		compatible = "ad,adp1653";
 		reg = <0x30>;
-
-		max-flash-timeout-usec = <500000>;
-		max-flash-intensity-mA = <0>;
-		max-torch-intensity-mA = <0>;
-		max-indicator-intensity-uA = <0>;
 	};
 };
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#1 lore raw

dtb size limit? was Re: Tiny dts change breaks boot on n900

Quoted 7 lines · Pavel Machek

Hi!

I'm confused:

This fixes boot on n900. Strange thing is ... adp1653 driver is not even compiled in -- it is module.

Quoted 7 lines

It looks like tiny change in dts noone should care about breaks boot... I don't even have adp1653 device parsing code written.

Something similar happened before -- change in device tree order broke boot.

Any ideas? What is going on?

If I replace the blog below with

a = <1>;
b = <2>;
c = <3>;
d = <4>;

Resulting kernel boots. Replacing it with

a-really-long-attribute-name-hopefully-this-breaks-stuff = <1>; b = <2>;
c = <3>;
d = <4>;

Breaks the boot. I'm using dtb append option. Any ideas? Nonbooting dtb is 68910 bytes.

pavel at amd:/data/l/linux-n900$ ls -al arch/arm/boot/dts/omap3-n900.dtb -rw-r--r-- 1 pavel pavel 68910 Nov 10 13:52 arch/arm/boot/dts/omap3-n900.dtb

I removed some "smsc,lan91c94" settings, and it boots again. Weird.

Quoted 19 lines

Pavel

arch/arm/boot/dts/omap3-n900.dts +0 -5
index f3118bf..557a19e 100644
@@ -565,11 +565,6 @@
 	adp1653: adp1653 at 30 {
 		compatible = "ad,adp1653";
 		reg = <0x30>;
-
-		max-flash-timeout-usec = <500000>;
-		max-flash-intensity-mA = <0>;
-		max-torch-intensity-mA = <0>;
-		max-indicator-intensity-uA = <0>;
 	};
 };
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw

Re: dtb size limit? was Re: Tiny dts change breaks boot on n900

Quoted 30 lines · Pavel Machek
Quoted 7 lines · Pavel Machek

Hi!

I'm confused:

This fixes boot on n900. Strange thing is ... adp1653 driver is not even compiled in -- it is module.

Quoted 7 lines

It looks like tiny change in dts noone should care about breaks boot... I don't even have adp1653 device parsing code written.

Something similar happened before -- change in device tree order broke boot.

Any ideas? What is going on?

If I replace the blog below with

a = <1>;
b = <2>;
c = <3>;
d = <4>;

Resulting kernel boots. Replacing it with

a-really-long-attribute-name-hopefully-this-breaks-stuff = <1>; b = <2>;
c = <3>;
d = <4>;

Quoted 7 lines

Breaks the boot. I'm using dtb append option. Any ideas? Nonbooting dtb is 68910 bytes.

pavel at amd:/data/l/linux-n900$ ls -al arch/arm/boot/dts/omap3-n900.dtb -rw-r--r-- 1 pavel pavel 68910 Nov 10 13:52 arch/arm/boot/dts/omap3-n900.dtb

I removed some "smsc,lan91c94" settings, and it boots again. Weird.

Seems like we may still have some issues with the relocation if it's size related. Or a regression maybe?

See for example commit 5ffb04f6690d ("ARM: zImage: make sure appended DTB doesn't get overwritten by kernel .bss")

Regards,

Tony

Quoted 25 lines
Quoted 17 lines
arch/arm/boot/dts/omap3-n900.dts +0 -5
index f3118bf..557a19e 100644
@@ -565,11 +565,6 @@
 	adp1653: adp1653 at 30 {
 		compatible = "ad,adp1653";
 		reg = <0x30>;
-
-		max-flash-timeout-usec = <500000>;
-		max-flash-intensity-mA = <0>;
-		max-torch-intensity-mA = <0>;
-		max-indicator-intensity-uA = <0>;
 	};
 };
Signature · 6 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

Re: dtb size limit? was Re: Tiny dts change breaks boot on n900

In reply to Pavel Machek

Am 10.11.2014 um 12:58 schrieb Pavel Machek:

Quoted 9 lines

If I replace the blo[ck] below with

a = <1>;
b = <2>;
c = <3>;
d = <4>;

Resulting kernel boots. Replacing it with

Quoted 7 lines

a-really-long-attribute-name-hopefully-this-breaks-stuff = <1>; b = <2>;
c = <3>;
d = <4>;

Breaks the boot. I'm using dtb append option. Any ideas? Nonbooting dtb is 68910 bytes.

Did you verify that your initrd, if any, does not overlap the end of the kernel when loading it from the bootloader?

Andreas

Signature · 2 lines
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 21284 AG N?rnberg
author
#4 lore raw

Re: dtb size limit? was Re: Tiny dts change breaks boot on n900

Quoted 15 lines · Andreas F?rber

Am 10.11.2014 um 12:58 schrieb Pavel Machek:

Quoted 14 lines

If I replace the blo[ck] below with

a = <1>;
b = <2>;
c = <3>;
d = <4>;

Resulting kernel boots. Replacing it with

a-really-long-attribute-name-hopefully-this-breaks-stuff = <1>; b = <2>;
c = <3>;
d = <4>;

Quoted 5 lines
Quoted 2 lines

Breaks the boot. I'm using dtb append option. Any ideas? Nonbooting dtb is 68910 bytes.

Did you verify that your initrd, if any, does not overlap the end of the kernel when loading it from the bootloader?

I don't use initrd, so this can't be it. Thanks,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#5 lore raw

Re: dtb size limit? was Re: Tiny dts change breaks boot on n900

In reply to Pavel Machek
Quoted 2 lines · Pavel Machek

Breaks the boot. I'm using dtb append option. Any ideas? Nonbooting dtb is 68910 bytes.

Perhaps because it's not a multiple of 4?

$ factor 68910
68910: 2 3 5 2297

Does padding some property with 2 bytes help?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds