mwifiex: simplify ad hoc join capability info

PATCH In review James Cameron 2 participants 2 messages Nov 11, 2014 Networking drivers (wireless)

Share & tools

James Cameron

author

2014-11-11 05:21 UTC #0 lore raw

PATCH 1/1 mwifiex: simplify ad hoc join capability info

While preparing an ad-hoc start command, the capability info bitmap is needlessly set from the command, and then the ESS bit cleared.

Change to set the bitmap directly without reference to the command.

Signed-off-by James Cameron <[email protected]>

---
 drivers/net/wireless/mwifiex/join.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/net/wireless/mwifiex/join.c +1 -3

index 8d6c259..411a6c2 100644
@@ -880,9 +880,7 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,
 
 	/* Set Capability info */
 	bss_desc->cap_info_bitmap |= WLAN_CAPABILITY_IBSS;
-	tmp_cap = le16_to_cpu(adhoc_start->cap_info_bitmap);
-	tmp_cap &= ~WLAN_CAPABILITY_ESS;
-	tmp_cap |= WLAN_CAPABILITY_IBSS;
+	tmp_cap = WLAN_CAPABILITY_IBSS;
 
 	/* Set up privacy in bss_desc */
 	if (priv->sec_info.encryption_mode) {

Signature · 6 lines

1.9.1


-- 
James Cameron
http://quozl.linux.org.au/

Amitkumar Karwar

Acked-by on v1 1/1

2014-11-11 13:05 UTC #1 lore raw

Hi James,

Quoted 6 lines

While preparing an ad-hoc start command, the capability info bitmap is needlessly set from the command, and then the ESS bit cleared.
Change to set the bitmap directly without reference to the command.
Signed-off-by James Cameron <[email protected]>

Acked-by Amitkumar Karwar <[email protected]>

Thanks,
Amitkumar