spl: Change debug to printf for "Unsupported boot-device"
PATCH 1/1 spl: Change debug to printf for "Unsupported boot-device"
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
--- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl.c +1 -1
@@ -216,7 +216,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)break ;#endif default : -debug ("SPL: Un-supported Boot Device\n" ); +printf ("SPL: Unsupported Boot Device %d\n" , boot_device);hang (); }
Signature · 1 line
2.1.3
PATCH 1/1 spl: Change debug to printf for "Unsupported boot-device"
Quoted 9 lines · Stefan Roese
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by Stefan Roese <[email protected]>Cc Tom Rini <[email protected]>
Did you build all of ARM with this? I _think_ this may break the davinci/related boards that use SPL since they don't have printf due to size.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141111/7dcba9f0/attachment.pgp>
PATCH 1/1 spl: Change debug to printf for "Unsupported boot-device"
Quoted 9 lines · Tom Rini
Quoted 7 lines · Stefan Roese
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Stefan Roese <[email protected]>Cc Tom Rini <[email protected]>Did you build all of ARM with this? I _think_ this may break the davinci/related boards that use SPL since they don't have printf due to size.
Yes, might be the case. I'm running the build for all ARM board right now. Will let you know if this breaks anything.
Thanks,
Stefan