Skip to contentSkip to conversation

amd-xgbe: fix ->rss_hash_type

PATCH Superseded Dan Carpenter 3 participants 5 messages Nov 12, 2014 – Nov 13, 2014

Subsystems (4)
Networking Network drivers Kernel janitors AMD xgbe driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 amd-xgbe: fix ->rss_hash_type

There was a missing break statement so we set everything to PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.

Fixes 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
Signed-off-by Dan Carpenter <[email protected]>

---
This driver has a lot of Sparse endian warnings.
http://lwn.net/Articles/205624/

drivers/net/ethernet/amd/xgbe/xgbe-dev.c +1 -0
index 7daa2cd..55ba1dc 100644
@@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
 		case RX_DESC3_L34T_IPV6_UDP:
 			packet->rss_hash_type = PKT_HASH_TYPE_L4;
 
+			break;
 		default:
 			packet->rss_hash_type = PKT_HASH_TYPE_L3;
 		}
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dan Carpenter

There was a missing break statement so we set everything to PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.

Fixes 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Tom Lendacky <[email protected]>
Quoted 3 lines

---
This driver has a lot of Sparse endian warnings.
http://lwn.net/Articles/205624/

I'll send a patch to address the endian warnings.

Thanks,
Tom

Quoted 14 lines
drivers/net/ethernet/amd/xgbe/xgbe-dev.c +1 -0
index 7daa2cd..55ba1dc 100644
@@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
  		case RX_DESC3_L34T_IPV6_UDP:
  			packet->rss_hash_type = PKT_HASH_TYPE_L4;
 
+			break;
  		default:
  			packet->rss_hash_type = PKT_HASH_TYPE_L3;
  		}
maintainer
#2 lore raw
In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Wed, 12 Nov 2014 11:31:35 +0300

Quoted 14 lines

There was a missing break statement so we set everything to PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.

Fixes 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
Signed-off-by Dan Carpenter <[email protected]>

---
This driver has a lot of Sparse endian warnings.
http://lwn.net/Articles/205624/

drivers/net/ethernet/amd/xgbe/xgbe-dev.c +0 -0
index 7daa2cd..55ba1dc 100644

drivers/net/ethernet/amd/xgbe/xgbe-dev.c static int xgbe_dev_read(struct xgbe_channel *channel) · line 1604

Quoted 4 lines
drivers/net/ethernet/amd/xgbe/xgbe-dev.c +1 -0
@@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
 		case RX_DESC3_L34T_IPV6_UDP:
 			packet->rss_hash_type = PKT_HASH_TYPE_L4;
 
+			break;

Please don't add this spurious empty line before the break;, thanks.

author
#3 lore raw

PATCH v2 1/1 amd-xgbe: fix ->rss_hash_type

There was a missing break statement so we set everything to PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.

Fixes 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
Signed-off-by Dan Carpenter <[email protected]>

---
v2: remove blank line

drivers/net/ethernet/amd/xgbe/xgbe-dev.c +1 -1
index 7daa2cd..f6014d3 100644
@@ -1600,7 +1600,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
 		case RX_DESC3_L34T_IPV6_TCP:
 		case RX_DESC3_L34T_IPV6_UDP:
 			packet->rss_hash_type = PKT_HASH_TYPE_L4;
-
+			break;
 		default:
 			packet->rss_hash_type = PKT_HASH_TYPE_L3;
 		}
maintainer Applied
#4 lore raw

From: Dan Carpenter <[email protected]>
Date: Thu, 13 Nov 2014 09:19:06 +0300

Quoted 7 lines

There was a missing break statement so we set everything to PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.

Fixes 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
Signed-off-by Dan Carpenter <[email protected]>

---
v2: remove blank line

Applied, thanks a lot Dan.