Skip to contentSkip to conversation

sunvnet: fix NULL pointer dereference

PATCH Applied David L Stevens 3 participants 3 messages Nov 12, 2014

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

David L Stevens

author
#0 lore raw

PATCH 1/1 sunvnet: fix NULL pointer dereference

This patch fixes a NULL pointer dereference when __tx_port_find() doesn't find a matching port.

Signed-off-by David L Stevens <[email protected]>
---
 drivers/net/ethernet/sun/sunvnet.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/ethernet/sun/sunvnet.c +2 -0
index 55d66c9..a556eba 100644
@@ -958,6 +958,8 @@ vnet_select_queue(struct net_device *dev, struct sk_buff *skb,
 	struct vnet *vp = netdev_priv(dev);
 	struct vnet_port *port = __tx_port_find(vp, skb);
 
+	if (port == NULL)
+		return 0;
 	return port->q_index;
 }
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw

drivers/net/ethernet/sun/sunvnet.c vnet_select_queue(struct net_device *dev, struct sk_buff *skb, · line 964

Quoted 10 lines · David L Stevens
drivers/net/ethernet/sun/sunvnet.c +2 -0
@@ -958,6 +958,8 @@ vnet_select_queue(struct net_device *dev, struct sk_buff *skb,
 	struct vnet *vp = netdev_priv(dev);
 	struct vnet_port *port = __tx_port_find(vp, skb);
 
+	if (port == NULL)
+		return 0;
 	return port->q_index;
 }
Acked-by Sowmini Varadhan <[email protected]>

Thanks!
Sowmini