Skip to contentSkip to conversation

PCI: spear: Remove unnecessary OOM message

PATCH In review Jingoo Han 3 participants 3 messages Nov 12, 2014 – Nov 13, 2014 PCI

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 PCI: spear: Remove unnecessary OOM message

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning.

WARNING: Possible unnecessary 'out of memory' message

---
 drivers/pci/host/pcie-spear13xx.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/host/pcie-spear13xx.c +1 -3
index 85f594e..4647b62 100644
@@ -308,10 +308,8 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev)
 	int ret;
 
 	spear13xx_pcie = devm_kzalloc(dev, sizeof(*spear13xx_pcie), GFP_KERNEL);
-	if (!spear13xx_pcie) {
-		dev_err(dev, "no memory for SPEAr13xx pcie\n");
+	if (!spear13xx_pcie)
 		return -ENOMEM;
-	}
 
 	spear13xx_pcie->phy = devm_phy_get(dev, "pcie-phy");
 	if (IS_ERR(spear13xx_pcie->phy)) {
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning.

WARNING: Possible unnecessary 'out of memory' message

---
 drivers/pci/host/pcie-spear13xx.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
maintainer
#2 lore raw
In reply to Jingoo Han
Quoted 7 lines · Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning.

WARNING: Possible unnecessary 'out of memory' message

Applied with Viresh's ack to pci/host-spear for v3.19, thanks!

Quoted 24 lines
---
 drivers/pci/host/pcie-spear13xx.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/host/pcie-spear13xx.c +1 -3
index 85f594e..4647b62 100644
@@ -308,10 +308,8 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev)
 	int ret;
 
 	spear13xx_pcie = devm_kzalloc(dev, sizeof(*spear13xx_pcie), GFP_KERNEL);
-	if (!spear13xx_pcie) {
-		dev_err(dev, "no memory for SPEAr13xx pcie\n");
+	if (!spear13xx_pcie)
 		return -ENOMEM;
-	}
 
 	spear13xx_pcie->phy = devm_phy_get(dev, "pcie-phy");
 	if (IS_ERR(spear13xx_pcie->phy)) {
Signature · 1 line
1.7.9.5