Skip to contentSkip to conversation

Update github helper URL.

PATCH New Patrick Williams 6 participants 10 messages Nov 13, 2014 – Nov 14, 2014

lore
Share & tools
lore

Patrick Williams

author
#0 lore raw

PATCH 1/1 Update github helper URL.

Github changed the URL syntax from 'archive' back to 'tarball'.

Signed-off-by Patrick Williams <[email protected]>
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +1 -1
index 4cfb913..03907f1 100644
@@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
 domainseparator=$(if $(1),$(1),/)
 
 # github(user,package,version): returns site of GitHub repository
-github = https://github.com/$(1)/$(2)/archive/$(3)
+github = https://github.com/$(1)/$(2)/tarball/$(3)
 
 ################################################################################
 # The DOWNLOAD_* helpers are in charge of getting a working copy
Signature · 1 line
2.1.1
#1 lore raw

PATCH 1/1 Update github helper URL.

Quoted 13 lines · Patrick Williams

Github changed the URL syntax from 'archive' back to 'tarball'.

Signed-off-by Patrick Williams <[email protected]>
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +0 -0
index 4cfb913..03907f1 100644

package/pkg-download.mk notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c · line 62

Quoted 8 lines
package/pkg-download.mk +1 -1
@@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
 domainseparator=$(if $(1),$(1),/)
 
 # github(user,package,version): returns site of GitHub repository
-github = https://github.com/$(1)/$(2)/archive/$(3)
+github = https://github.com/$(1)/$(2)/tarball/$(3)
 
 ################################################################################
 # The DOWNLOAD_* helpers are in charge of getting a working copy

Yep, that seems to work! So Yann, stop working :-)

I haven't tested if it's exactly the same tarball. It redirects to a URL
containing legacy.tar.gz instead of tar.gz, so who knows...

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 Update github helper URL.

Quoted 19 lines · Arnout Vandecappelle
Quoted 18 lines · Patrick Williams

Github changed the URL syntax from 'archive' back to 'tarball'.

Signed-off-by Patrick Williams <[email protected]>
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +1 -1
index 4cfb913..03907f1 100644
@@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
 domainseparator=$(if $(1),$(1),/)
 
 # github(user,package,version): returns site of GitHub repository
-github = https://github.com/$(1)/$(2)/archive/$(3)
+github = https://github.com/$(1)/$(2)/tarball/$(3)
Quoted 8 lines

package/pkg-download.mk notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c · line 62

Quoted 3 lines
package/pkg-download.mk +0 -0
 ################################################################################
 # The DOWNLOAD_* helpers are in charge of getting a working copy

Yep, that seems to work! So Yann, stop working :-)

I haven't tested if it's exactly the same tarball. It redirects to a URL
containing legacy.tar.gz instead of tar.gz, so who knows...

Checked with a few tarballs, and it seems they only differ in the basename:

legacy (i.e., this patch):

	zeromq-cppzmq-1f05e0d/
current (i.e., archive/version.tar.gz):
	cppzmq-1f05e0d111197c64be32ad5aecd59f4d1b05a819/

So the legacy really looks better :-)

Therefore:

Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Tested-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 Update github helper URL.

In reply to Arnout Vandecappelle
Quoted 19 lines · Arnout Vandecappelle
Quoted 18 lines · Patrick Williams

Github changed the URL syntax from 'archive' back to 'tarball'.

Signed-off-by Patrick Williams <[email protected]>
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +1 -1
index 4cfb913..03907f1 100644
@@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
 domainseparator=$(if $(1),$(1),/)
 
 # github(user,package,version): returns site of GitHub repository
-github = https://github.com/$(1)/$(2)/archive/$(3)
+github = https://github.com/$(1)/$(2)/tarball/$(3)
Quoted 8 lines

package/pkg-download.mk notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c · line 62

Quoted 3 lines
package/pkg-download.mk +0 -0
 ################################################################################
 # The DOWNLOAD_* helpers are in charge of getting a working copy

Yep, that seems to work! So Yann, stop working :-)

I haven't tested if it's exactly the same tarball. It redirects to a URL
containing legacy.tar.gz instead of tar.gz, so who knows...

I can't follow all this madness.

Quoted 1 line
Quoted 1 line
Quoted 1 line

a10disp a899cc6dcf909360aac00482ede5369f3656f226 Downloading

--2014-11-13 20:57:54--
https://github.com/hglm/a10disp/archive/a899cc6dcf909360aac00482ede5369f3656f226/a10disp-a899cc6dcf909360aac00482ede5369f3656f226.tar.gz
Resolving github.com (github.com)... 192.30.252.129
Connecting to github.com (github.com)|192.30.252.129|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226
[following]
--2014-11-13 20:57:54--
https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226
Resolving codeload.github.com (codeload.github.com)... 192.30.252.146
Connecting to codeload.github.com
(codeload.github.com)|192.30.252.146|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]

Here the original URL with 'archive' still works. So what's the fuzz about?

#4 lore raw

PATCH 1/1 Update github helper URL.

Quoted 47 lines · Thomas De Schampheleire
Quoted 19 lines · Arnout Vandecappelle
Quoted 18 lines · Patrick Williams

Github changed the URL syntax from 'archive' back to 'tarball'.

Signed-off-by Patrick Williams <[email protected]>
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +1 -1
index 4cfb913..03907f1 100644
@@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
 domainseparator=$(if $(1),$(1),/)
 
 # github(user,package,version): returns site of GitHub repository
-github = https://github.com/$(1)/$(2)/archive/$(3)
+github = https://github.com/$(1)/$(2)/tarball/$(3)
Quoted 8 lines

package/pkg-download.mk notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c · line 62

Quoted 3 lines
package/pkg-download.mk +0 -0
 ################################################################################
 # The DOWNLOAD_* helpers are in charge of getting a working copy

Yep, that seems to work! So Yann, stop working :-)

I haven't tested if it's exactly the same tarball. It redirects to a URL
containing legacy.tar.gz instead of tar.gz, so who knows...

I can't follow all this madness.

Quoted 1 line
Quoted 1 line
Quoted 1 line

a10disp a899cc6dcf909360aac00482ede5369f3656f226 Downloading

--2014-11-13 20:57:54--
https://github.com/hglm/a10disp/archive/a899cc6dcf909360aac00482ede5369f3656f226/a10disp-a899cc6dcf909360aac00482ede5369f3656f226.tar.gz
Resolving github.com (github.com)... 192.30.252.129
Connecting to github.com (github.com)|192.30.252.129|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226
[following]
--2014-11-13 20:57:54--
https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226
Resolving codeload.github.com (codeload.github.com)... 192.30.252.146
Connecting to codeload.github.com
(codeload.github.com)|192.30.252.146|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]

Quoted 3 lines

Here the original URL with 'archive' still works. So what's the fuzz about?

I guess someone complained to github and they reverted it...

I just tried
https://github.com/xbmc/xbmc/archive/13.2-Gotham/xbmc-13.2-Gotham.tar.gz

which failed for Peter this morning, and it works now.

The funny thing is, it _doesn't_ redirect to the legacy...

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#5 lore raw

PATCH 1/1 Update github helper URL.

In reply to Thomas De Schampheleire
Quoted 26 lines · Thomas De Schampheleire
Quoted 25 lines · Arnout Vandecappelle
Quoted 13 lines · Patrick Williams

Github changed the URL syntax from 'archive' back to 'tarball'.

Signed-off-by Patrick Williams <[email protected]>
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +0 -0
index 4cfb913..03907f1 100644

package/pkg-download.mk notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c · line 62

Quoted 8 lines
package/pkg-download.mk +1 -1
@@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
 domainseparator=$(if $(1),$(1),/)
 
 # github(user,package,version): returns site of GitHub repository
-github = https://github.com/$(1)/$(2)/archive/$(3)
+github = https://github.com/$(1)/$(2)/tarball/$(3)
 
 ################################################################################
 # The DOWNLOAD_* helpers are in charge of getting a working copy

Yep, that seems to work! So Yann, stop working :-)

Quoted 4 lines
Quoted 2 lines

I haven't tested if it's exactly the same tarball. It redirects to a URL
containing legacy.tar.gz instead of tar.gz, so who knows...

I can't follow all this madness.

It seems people at github are like weathervane... ;-)
http://git.buildroot.net/buildroot/commit/?id=507d6a637ba51e9799acd4c8a0b614fc9842b4e2

Signature · 1 line
Samuel
#6 lore raw

PATCH 1/1 Update github helper URL.

In reply to Thomas De Schampheleire

Thomas, Arnout, Patrick, All,

On 2014-11-13 21:06 +0100, Thomas De Schampheleire spake thusly:

Quoted 20 lines · Arnout Vandecappelle
Quoted 19 lines · Patrick Williams
Quoted 18 lines

Github changed the URL syntax from 'archive' back to 'tarball'.

Signed-off-by Patrick Williams <[email protected]>
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-download.mk +1 -1
index 4cfb913..03907f1 100644
@@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
 domainseparator=$(if $(1),$(1),/)
 
 # github(user,package,version): returns site of GitHub repository
-github = https://github.com/$(1)/$(2)/archive/$(3)
+github = https://github.com/$(1)/$(2)/tarball/$(3)
Quoted 5 lines
Quoted 5 lines

package/pkg-download.mk notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c · line 62

Quoted 3 lines
package/pkg-download.mk +0 -0
 ################################################################################
 # The DOWNLOAD_* helpers are in charge of getting a working copy

Yep, that seems to work! So Yann, stop working :-)

Meh...

Quoted 21 lines
Quoted 2 lines

I haven't tested if it's exactly the same tarball. It redirects to a URL
containing legacy.tar.gz instead of tar.gz, so who knows...

I can't follow all this madness.

Quoted 1 line
Quoted 1 line
Quoted 1 line

a10disp a899cc6dcf909360aac00482ede5369f3656f226 Downloading

--2014-11-13 20:57:54--
https://github.com/hglm/a10disp/archive/a899cc6dcf909360aac00482ede5369f3656f226/a10disp-a899cc6dcf909360aac00482ede5369f3656f226.tar.gz
Resolving github.com (github.com)... 192.30.252.129
Connecting to github.com (github.com)|192.30.252.129|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226
[following]
--2014-11-13 20:57:54--
https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226
Resolving codeload.github.com (codeload.github.com)... 192.30.252.146
Connecting to codeload.github.com
(codeload.github.com)|192.30.252.146|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]

Quoted 1 line

Here the original URL with 'archive' still works. So what's the fuzz about?

DAng... It works again. It surely was broken yesterday: all downlaod would fallback to using http://sources.buildroot.net

See also the mail from Peter stating it did not work for him, too:

    http://lists.busybox.net/pipermail/buildroot/2014-November/111953.html

So, they "fixed" it over-night. Sigh, that's not reliable.

OK, so we can probably post-pone the resolution for post-release.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 1/1 Update github helper URL.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 11 lines
Quoted 1 line

Here the original URL with 'archive' still works. So what's the fuzz about?

DAng... It works again. It surely was broken yesterday: all downlaod would fallback to using http://sources.buildroot.net

See also the mail from Peter stating it did not work for him, too:

    http://lists.busybox.net/pipermail/buildroot/2014-November/111953.html

So, they "fixed" it over-night. Sigh, that's not reliable.

OK, so we can probably post-pone the resolution for post-release.

Gaah, I lost track. Are we now keeping it like it is or do we go back to the /tarball/ URLs?

Signature · 1 line
Bye, Peter Korsgaard
#8 lore raw

PATCH 1/1 Update github helper URL.

Hi Peter,

Quoted 12 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 1 line

Here the original URL with 'archive' still works. So what's the fuzz about?

DAng... It works again. It surely was broken yesterday: all downlaod would fallback to using http://sources.buildroot.net

See also the mail from Peter stating it did not work for him, too:

    http://lists.busybox.net/pipermail/buildroot/2014-November/111953.html
Quoted 6 lines
Quoted 3 lines

So, they "fixed" it over-night. Sigh, that's not reliable.

OK, so we can probably post-pone the resolution for post-release.

Gaah, I lost track. Are we now keeping it like it is or do we go back to the /tarball/ URLs?

We keep things as is for now,
No fix is needed on Buildroot side, it has been done on github side.

Regards,

Signature · 1 line
Samuel
#9 lore raw

PATCH 1/1 Update github helper URL.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Samuel" == Samuel Martin <[email protected]> writes:

Hi,

Quoted 5 lines
Quoted 2 lines

Gaah, I lost track. Are we now keeping it like it is or do we go back to the /tarball/ URLs?

We keep things as is for now,
No fix is needed on Buildroot side, it has been done on github side.

Ok, thanks.

Signature · 1 line
Bye, Peter Korsgaard