Skip to contentSkip to conversation

staging: media: bcm2048: fix coding style error

PATCH In review Christian Resell 5 participants 6 messages Nov 15, 2014 – Nov 16, 2014

Subsystems (2)
Media (V4L/DVB) Staging
lore
Share & tools
lore

Christian Resell

author
#0 lore raw

PATCH 1/1 staging: media: bcm2048: fix coding style error

Simple style fix (checkpatch.pl: "space prohibited before that ','"). For the eudyptula challenge (http://eudyptula-challenge.org/).

Signed-off-by Christian F. Resell <[email protected]>

---

drivers/staging/media/bcm2048/radio-bcm2048.c +1 -1
index 2bba370..bdc6854 100644
@@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
  *	bcm2048_i2c_driver - i2c driver interface
  */
 static const struct i2c_device_id bcm2048_id[] = {
-	{ "bcm2048" , 0 },
+	{ "bcm2048", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(i2c, bcm2048_id);
#1 lore raw
Quoted 2 lines · Christian Resell

Simple style fix (checkpatch.pl: "space prohibited before that ','"). For the eudyptula challenge (http://eudyptula-challenge.org/).

Nice, however we do not need the information about the 'eudyptula challenge' in the commit message.

If you want to include extra information please do it after the '---' line (just below the signed-off). You will find more details in the SubmittingPatches (chapter 15) of the kernel documentation.

Thanks,
Konrad

Quoted 19 lines
Signed-off-by Christian F. Resell <[email protected]>

---

drivers/staging/media/bcm2048/radio-bcm2048.c +1 -1
index 2bba370..bdc6854 100644
@@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
  *	bcm2048_i2c_driver - i2c driver interface
  */
 static const struct i2c_device_id bcm2048_id[] = {
-	{ "bcm2048" , 0 },
+	{ "bcm2048", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(i2c, bcm2048_id);

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

#2 lore raw
Quoted 10 lines · Konrad Zapalowicz
Quoted 2 lines · Christian Resell

Simple style fix (checkpatch.pl: "space prohibited before that ','"). For the eudyptula challenge (http://eudyptula-challenge.org/).

Nice, however we do not need the information about the 'eudyptula challenge' in the commit message.

If you want to include extra information please do it after the '---' line (just below the signed-off). You will find more details in the SubmittingPatches (chapter 15) of the kernel documentation.

Greg is staging tree maintainer... And if single extra space is all you can fix in the driver, perhaps it is not worth the patch?

Pavel

Quoted 22 lines

Thanks,
Konrad

Quoted 19 lines
Signed-off-by Christian F. Resell <[email protected]>

---

drivers/staging/media/bcm2048/radio-bcm2048.c +1 -1
index 2bba370..bdc6854 100644
@@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
  *	bcm2048_i2c_driver - i2c driver interface
  */
 static const struct i2c_device_id bcm2048_id[] = {
-	{ "bcm2048" , 0 },
+	{ "bcm2048", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(i2c, bcm2048_id);

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
maintainer
#3 lore raw
Quoted 8 lines · Pavel Machek
Quoted 7 lines · Konrad Zapalowicz
Quoted 2 lines · Christian Resell

Simple style fix (checkpatch.pl: "space prohibited before that ','"). For the eudyptula challenge (http://eudyptula-challenge.org/).

Nice, however we do not need the information about the 'eudyptula challenge' in the commit message.

Quoted 6 lines
Quoted 3 lines

If you want to include extra information please do it after the '---' line (just below the signed-off). You will find more details in the SubmittingPatches (chapter 15) of the kernel documentation.

Greg is staging tree maintainer... And if single extra space is all you can fix in the driver, perhaps it is not worth the patch?

I am not the maintainer of drivers/staging/media/ please look at MAINTAINERS before you make statements like that.

And yes, one space fixes is just fine, that's why the code is in staging.

greg k-h

#4 lore raw

Em Sat, 15 Nov 2014 13:25:03 -0800
Greg KH <[email protected]> escreveu:

Quoted 13 lines · Pavel Machek
Quoted 12 lines · Konrad Zapalowicz
Quoted 10 lines · Christian Resell
Quoted 2 lines

Simple style fix (checkpatch.pl: "space prohibited before that ','"). For the eudyptula challenge (http://eudyptula-challenge.org/).

Nice, however we do not need the information about the 'eudyptula challenge' in the commit message.

If you want to include extra information please do it after the '---' line (just below the signed-off). You will find more details in the SubmittingPatches (chapter 15) of the kernel documentation.

Quoted 8 lines
Quoted 2 lines

Greg is staging tree maintainer... And if single extra space is all you can fix in the driver, perhaps it is not worth the patch?

I am not the maintainer of drivers/staging/media/ please look at MAINTAINERS before you make statements like that.

And yes, one space fixes is just fine, that's why the code is in staging.

Yes, space fixes is OK for staging.

I'll apply this patch, removing the line that comments about the challenge, as we don't need to keep this information forever at the Kernel history.

Regards,
Mauro

#5 lore raw
In reply to Pavel Machek
Quoted 8 lines · Pavel Machek
Quoted 7 lines · Konrad Zapalowicz
Quoted 2 lines · Christian Resell

Simple style fix (checkpatch.pl: "space prohibited before that ','"). For the eudyptula challenge (http://eudyptula-challenge.org/).

Nice, however we do not need the information about the 'eudyptula challenge' in the commit message.

Quoted 6 lines
Quoted 3 lines

If you want to include extra information please do it after the '---' line (just below the signed-off). You will find more details in the SubmittingPatches (chapter 15) of the kernel documentation.

Greg is staging tree maintainer... And if single extra space is all you can fix in the driver, perhaps it is not worth the patch?

I think that every contribution, as long as it acctually fixes something, is worth the patch. The beauty of the open source community is that we do when we have time as much as we are able to do - totally no stress.

You, Pavel, are more experienced however those who are not have to learn somehow and one of the options is to start with something very simple. Sometimes the 'simple' means oneliner however as long as it compiles, is inline with the coding standard and in general is an improvement then it is good.

Regards,
Konrad

Quoted 28 lines

Pavel

Quoted 22 lines

Thanks,
Konrad

Quoted 19 lines
Signed-off-by Christian F. Resell <[email protected]>

---

drivers/staging/media/bcm2048/radio-bcm2048.c +1 -1
index 2bba370..bdc6854 100644
@@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
  *	bcm2048_i2c_driver - i2c driver interface
  */
 static const struct i2c_device_id bcm2048_id[] = {
-	{ "bcm2048" , 0 },
+	{ "bcm2048", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(i2c, bcm2048_id);

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html