package/nodejs: fix build error without OpenSSL support
PATCH 1/1 package/nodejs: fix build error without OpenSSL support
Version 0.10.33 of nodejs introduced a bug which prevents us from building nodejs without OpenSSL support. The bug is reported upstream:
https://github.com/joyent/node/issues/8676
This bug caused some build errors:
* http://autobuild.buildroot.net/results/0bf/0bf17bf710db051d491123482c90f2f72810804b/
* http://autobuild.buildroot.net/results/e1f/e1fb34818ff1167aa008b4011befb9fd14c81293/
and more...
nodejs can be build with shared linking to an external OpenSSL library (by setting --shared-openssl) or with static linking to the bundled OpenSSL library.
With this patch nodejs is build with static linking to the bundled OpenSSL library in case no OpenSSL package is selected.
--- package/nodejs/nodejs.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/nodejs/nodejs.mk +1 -1
@@ -76,7 +76,7 @@ define NODEJS_CONFIGURE_CMDS --without-snapshot \ --shared-zlib \ $(if $(BR2_PACKAGE_OPENSSL),--shared-openssl,\ - --without-ssl --without-ssl2 --without-ssl3) \ + --without-ssl2 --without-ssl3) \ $(if $(BR2_PACKAGE_NODEJS_NPM),,--without-npm) \ --without-dtrace \ --without-etw \
Signature · 1 line
2.1.3
PATCH 1/1 package/nodejs: fix build error without OpenSSL support
Dear J?rg Krause,
Quoted 8 lines · J?rg Krause
Version 0.10.33 of nodejs introduced a bug which prevents us from building nodejs without OpenSSL support. The bug is reported upstream:
https://github.com/joyent/node/issues/8676This bug caused some build errors:
* http://autobuild.buildroot.net/results/0bf/0bf17bf710db051d491123482c90f2f72810804b/
* http://autobuild.buildroot.net/results/e1f/e1fb34818ff1167aa008b4011befb9fd14c81293/
Quoted 8 lines
and more...
nodejs can be build with shared linking to an external OpenSSL library (by setting
--shared-openssl) or with static linking to the bundled OpenSSL library.With this patch nodejs is build with static linking to the bundled OpenSSL library in case no OpenSSL package is selected.
I don't think this is the right fix. We don't want to use the bundled OpenSSL library, that's contrary to what we do in the rest of Buildroot. The proper fixes are either fixing the bug that prevents nodejs from building without OpenSSL, or make nodejs select unconditionally OpenSSL.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com