dma: imx-sdma: clarify about firmware not found error
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 dma: imx-sdma: clarify about firmware not found error
From: Sascha Hauer <[email protected]>
When a firmware cannot be found for the SDMA engine then we can continue with the internal ROM firmware.
The meaning of this message is frequently asked for, so make clear that the driver still works with the internal ROM firmware and reduce the loglevel from err to info.
--- drivers/dma/imx-sdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dma/imx-sdma.c +2 -1
@@ -1287,7 +1287,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)unsigned short *ram_code;if (!fw) { -dev_err (sdma->dev,"firmware not found\n" ); +dev_info (sdma->dev,"external firmware not found, using ROM firmware\n" ); +/* In this case we just use the ROM firmware. */ return ; }
Signature · 1 line
1.9.1
PATCH 1/1 dma: imx-sdma: clarify about firmware not found error
Quoted 5 lines · Fabio Estevam
From: Sascha Hauer <[email protected]>
When a firmware cannot be found for the SDMA engine then we can continue with the internal ROM firmware.
Quoted 7 lines
The meaning of this message is frequently asked for, so make clear that the driver still works with the internal ROM firmware and reduce the loglevel from err to info.
Cc Vinod Koul <[email protected]>Cc linux-arm-kernel at lists.infradead.orgCc Shawn Guo <[email protected]>
Quoted 23 lines
Signed-off-by Sascha Hauer <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- drivers/dma/imx-sdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/dma/imx-sdma.c +2
-1@@ -1287,7 +1287,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)unsigned short *ram_code;if (!fw) { -dev_err (sdma->dev,"firmware not found\n" ); +dev_info (sdma->dev,"external firmware not found, using ROM firmware\n" ); +/* In this case we just use the ROM firmware. */ return ; }Signature · 1 line
1.9.1
Sascha Hauer
maintainerPATCH 1/1 dma: imx-sdma: clarify about firmware not found error
In reply to Fabio EstevamQuoted 9 lines · Fabio Estevam
From: Sascha Hauer <[email protected]>
When a firmware cannot be found for the SDMA engine then we can continue with the internal ROM firmware.
The meaning of this message is frequently asked for, so make clear that the driver still works with the internal ROM firmware and reduce the loglevel from err to info.
Quoted 5 lines
Cc Vinod Koul <[email protected]>Cc linux-arm-kernel at lists.infradead.orgCc Shawn Guo <[email protected]>Signed-off-by Sascha Hauer <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
I still think we should have this.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Fabio Estevam
reviewerPATCH 1/1 dma: imx-sdma: clarify about firmware not found error
Hi Vinod,
Quoted 16 lines · Sascha Hauer
Quoted 9 lines · Fabio Estevam
From: Sascha Hauer <[email protected]>
When a firmware cannot be found for the SDMA engine then we can continue with the internal ROM firmware.
The meaning of this message is frequently asked for, so make clear that the driver still works with the internal ROM firmware and reduce the loglevel from err to info.
Quoted 5 lines
Cc Vinod Koul <[email protected]>Cc linux-arm-kernel at lists.infradead.orgCc Shawn Guo <[email protected]>Signed-off-by Sascha Hauer <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Quoted 3 lines
I still think we should have this.
Acked-by Sascha Hauer <[email protected]>
Could this one be applied?