Skip to contentSkip to conversation

package/rpm: add missing dependency to openssl

PATCH New Yann E. MORIN 2 participants 3 messages Nov 16, 2014 – Nov 17, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rpm: add missing dependency to openssl

We forcibly enable use of an extrernal openssl in rpm, so we must depend on it.

openssl is correctly selected from kconfig, but there is no build-time dependency to it.

It was not an issue so far, because openssl always sorts before rpm, so gets built before. Unless one wants to just build rpm to debug an autobuilder failure, that is.

Add that build-time dependency to openssl.

---
 package/rpm/rpm.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rpm/rpm.mk +1 -1
index af1642f..50e6d75 100644
@@ -7,7 +7,7 @@
 RPM_VERSION_MAJOR = 5.2
 RPM_VERSION = $(RPM_VERSION_MAJOR).0
 RPM_SITE = http://rpm5.org/files/rpm/rpm-$(RPM_VERSION_MAJOR)
-RPM_DEPENDENCIES = zlib beecrypt neon popt
+RPM_DEPENDENCIES = zlib beecrypt neon popt openssl
 RPM_LICENSE = LGPLv2.1
 RPM_LICENSE_FILES = COPYING.LIB
 
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/rpm: add missing dependency to openssl

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

We forcibly enable use of an extrernal openssl in rpm, so we must depend on it.

Quoted 8 lines

openssl is correctly selected from kconfig, but there is no build-time dependency to it.

It was not an issue so far, because openssl always sorts before rpm, so gets built before. Unless one wants to just build rpm to debug an autobuilder failure, that is.

Add that build-time dependency to openssl.

Committed, thanks.

Quoted 10 lines
---
 package/rpm/rpm.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rpm/rpm.mk +0 -0
index af1642f..50e6d75 100644

package/rpm/rpm.mk line 10

Quoted 5 lines
package/rpm/rpm.mk +1 -1
@@ -7,7 +7,7 @@
 RPM_VERSION_MAJOR = 5.2
 RPM_VERSION = $(RPM_VERSION_MAJOR).0
 RPM_SITE = http://rpm5.org/files/rpm/rpm-$(RPM_VERSION_MAJOR)
-RPM_DEPENDENCIES = zlib beecrypt neon popt
+RPM_DEPENDENCIES = zlib beecrypt neon popt openssl

A quick check seems to show that zlib isn't selected from Config.in. Is it needed (besides indirectly from openssl)?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/rpm: add missing dependency to openssl

Peter, All,

On 2014-11-17 00:26 +0100, Peter Korsgaard spake thusly:

Quoted 21 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

We forcibly enable use of an extrernal openssl in rpm, so we must depend on it.

Quoted 8 lines

openssl is correctly selected from kconfig, but there is no build-time dependency to it.

It was not an issue so far, because openssl always sorts before rpm, so gets built before. Unless one wants to just build rpm to debug an autobuilder failure, that is.

Add that build-time dependency to openssl.

Committed, thanks.

Quoted 4 lines
---
 package/rpm/rpm.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

package/rpm/rpm.mk line 10

Quoted 10 lines
package/rpm/rpm.mk +1 -1
index af1642f..50e6d75 100644
@@ -7,7 +7,7 @@
 RPM_VERSION_MAJOR = 5.2
 RPM_VERSION = $(RPM_VERSION_MAJOR).0
 RPM_SITE = http://rpm5.org/files/rpm/rpm-$(RPM_VERSION_MAJOR)
-RPM_DEPENDENCIES = zlib beecrypt neon popt
+RPM_DEPENDENCIES = zlib beecrypt neon popt openssl

A quick check seems to show that zlib isn't selected from Config.in. Is it needed (besides indirectly from openssl)?

Yes, rpm needs it, too. I'll cook a patch. Thanks for noticing.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'