package/sdl_sound: fix constness in debug mode
PATCH v2 1/1 package/sdl_sound: fix constness in debug mode
When in debug mode, ./configure forces -Werror, which uncovers a constness issue in the speex decoder.
Add a patch to fix this.
Fixes:
http://autobuild.buildroot.net/results/6f5/6f5e1b782923d6e69e929466f0ddd3eeba28c6f1/ http://autobuild.buildroot.net/results/c1b/c1b31dc37fe62cb6901edad02bf50d73072b7cf0/ http://autobuild.buildroot.net/results/162/162e6d77e5812060001ea22faff99055aae3122a/ ...
--- package/sdl_sound/0001-fix-constness.patch | 16 ++++++++++++++++ package/sdl_sound/sdl_sound.mk | 3 +++ 2 files changed, 19 insertions(+) create mode 100644 package/sdl_sound/0001-fix-constness.patch
package/sdl_sound/0001-fix-constness.patch new file +16 -0
@@ -0,0 +1,16 @@ +decoders/speex: fix constness of speex mode + +Signed-off-by: "Yann E. MORIN" <[email protected]> + +diff -durN sdl_sound-1.0.3.orig/decoders/speex.c sdl_sound-1.0.3/decoders/speex.c +--- sdl_sound-1.0.3.orig/decoders/speex.c 2014-11-17 19:40:09.543553556 +0100 ++++ sdl_sound-1.0.3/decoders/speex.c 2014-11-17 19:40:37.119864580 +0100 +@@ -124,7 +124,7 @@ + + static int process_header(speex_t *speex, Sound_Sample *sample) + { +- SpeexMode *mode; ++ const SpeexMode * mode; + SpeexHeader *hptr; + SpeexHeader header; + int enh_enabled = SPEEX_USE_PERCEPTUAL_ENHANCER;
package/sdl_sound/sdl_sound.mk +3 -0
@@ -12,6 +12,9 @@ SDL_SOUND_LICENSE_FILES = COPYING SDL_SOUND_INSTALL_STAGING = YES SDL_SOUND_DEPENDENCIES = sdl +# Patch touching configure.in +SDL_SOUND_AUTORECONF = YES + ifneq ($(BR2_ENABLE_LOCALE),y) SDL_SOUND_DEPENDENCIES += libiconv endif
Signature · 1 line
1.9.1
PATCH v2 1/1 package/sdl_sound: fix constness in debug mode
All,
On 2014-11-17 19:53 +0100, Yann E. MORIN spake thusly:
Quoted 4 lines
When in debug mode, ./configure forces -Werror, which uncovers a constness issue in the speex decoder.
Add a patch to fix this.
Patch was submitted upstream, but is help in moderation because I am not subscribed to their mailing list. As soon as I have an answer, I'll post it here (at least a pointer to the thread).
Regards,
Yann E. MORIN.
Quoted 54 lines
Fixes:
http://autobuild.buildroot.net/results/6f5/6f5e1b782923d6e69e929466f0ddd3eeba28c6f1/ http://autobuild.buildroot.net/results/c1b/c1b31dc37fe62cb6901edad02bf50d73072b7cf0/ http://autobuild.buildroot.net/results/162/162e6d77e5812060001ea22faff99055aae3122a/ ...Signed-off-by "Yann E. MORIN" <[email protected]>Cc Bernd Kuhls <[email protected]>Cc Vicente Olivert Riera <[email protected]>--- package/sdl_sound/0001-fix-constness.patch | 16 ++++++++++++++++ package/sdl_sound/sdl_sound.mk | 3 +++ 2 files changed, 19 insertions(+) create mode 100644 package/sdl_sound/0001-fix-constness.patchpackage/sdl_sound/0001-fix-constness.patch new file +16
-0@@ -0,0 +1,16 @@ +decoders/speex: fix constness of speex mode + +Signed-off-by: "Yann E. MORIN" <[email protected]> + +diff -durN sdl_sound-1.0.3.orig/decoders/speex.c sdl_sound-1.0.3/decoders/speex.c +--- sdl_sound-1.0.3.orig/decoders/speex.c 2014-11-17 19:40:09.543553556 +0100 ++++ sdl_sound-1.0.3/decoders/speex.c 2014-11-17 19:40:37.119864580 +0100 +@@ -124,7 +124,7 @@ + + static int process_header(speex_t *speex, Sound_Sample *sample) + { +- SpeexMode *mode; ++ const SpeexMode * mode; + SpeexHeader *hptr; + SpeexHeader header; + int enh_enabled = SPEEX_USE_PERCEPTUAL_ENHANCER;package/sdl_sound/sdl_sound.mk +3
-0@@ -12,6 +12,9 @@ SDL_SOUND_LICENSE_FILES = COPYING SDL_SOUND_INSTALL_STAGING = YES SDL_SOUND_DEPENDENCIES = sdl +# Patch touching configure.in +SDL_SOUND_AUTORECONF = YES + ifneq ($(BR2_ENABLE_LOCALE),y) SDL_SOUND_DEPENDENCIES += libiconv endifSignature · 1 line
1.9.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/sdl_sound: fix constness in debug mode
In reply to Yann E. MORIN"Yann E. MORIN" <[email protected]> wrote in news:1416250380-24029-1-git-send-email-yann.morin.1998 at free.fr:
package/sdl_sound/sdl_sound.mk SDL_SOUND_LICENSE_FILES = COPYING · line 17
Quoted 3 lines
package/sdl_sound/sdl_sound.mk +3
-0+# Patch touching configure.in +SDL_SOUND_AUTORECONF = YES +
Hi,
I think this part of the patch is not necessary anymore ;)
Regards, Bernd
PATCH v2 1/1 package/sdl_sound: fix constness in debug mode
Bernd, All,
On 2014-11-17 20:10 +0100, Bernd Kuhls spake thusly:
Quoted 7 lines
"Yann E. MORIN" <[email protected]> wrote in news:1416250380-24029-1-git-send-email-yann.morin.1998 at free.fr:
package/sdl_sound/sdl_sound.mk SDL_SOUND_LICENSE_FILES = COPYING · line 16
Quoted 2 lines
package/sdl_sound/sdl_sound.mk +2
-0+# Patch touching configure.in +SDL_SOUND_AUTORECONF = YESI think this part of the patch is not necessary anymore ;)
Damn, yes. Will resend. Thanks.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'