Skip to contentSkip to conversation

ARM: dts: dove: add DT LCD controllers

PATCH New Russell King 4 participants 4 messages Nov 19, 2014 – Nov 22, 2014 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: dove: add DT LCD controllers

Add the DT fragment for the Marvell Dove LCD controllers.

---
The documentation for this binding was submitted previously as part of the code which parses this - v3.17-rc1~82^2~32^2~2.

 arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/dove.dtsi +14 -0
index 3b891dd20993..a5441d5482a6 100644
@@ -630,6 +630,20 @@
 				reg = <0xe8400 0x0c>;
 				ngpios = <8>;
 			};
+
+			lcd1: lcd-controller at 810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};
+
+			lcd0: lcd-controller at 820000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x820000 0x1000>;
+				interrupts = <47>;
+				status = "disabled";
+			};
 		};
 	};
 };
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 ARM: dts: dove: add DT LCD controllers

arch/arm/boot/dts/dove.dtsi line 639

Quoted 6 lines · On Wed, 19 Nov 2014 11:32:29 +0000 Russell King <[email protected]>…
arch/arm/boot/dts/dove.dtsi +6 -0
+			lcd1: lcd-controller at 810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};

The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?

Signature · 2 lines
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
#2 lore raw

PATCH 1/1 ARM: dts: dove: add DT LCD controllers

Quoted 11 lines · Jean-Francois Moine

arch/arm/boot/dts/dove.dtsi line 639

Quoted 6 lines · On Wed, 19 Nov 2014 11:32:29 +0000 Russell King <[email protected]>…
arch/arm/boot/dts/dove.dtsi +6 -0
+			lcd1: lcd-controller at 810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};

The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?

Actually, a more correct value would be 0x10000, if you read table 145. Yes, the device may onlny have documented registers from 0x84 to 0x1c8, but that isn't to say that we should say that the device resources start at 0x810084 and have a size of 0x144, when the bus level decodes a 64K chunk of memory.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
#3 lore raw

PATCH 1/1 ARM: dts: dove: add DT LCD controllers

In reply to Russell King
Quoted 9 lines · Russell King

Add the DT fragment for the Marvell Dove LCD controllers.

---
The documentation for this binding was submitted previously as part of the code which parses this - v3.17-rc1~82^2~32^2~2.

 arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

hmmm... this was already applied:

087b04701111e ARM: dts: dove: add DT LCD controllers

Quoted 1 line

From here:

https://lkml.kernel.org/r/E1XAKGS-0004WE-8h at rmk-PC.arm.linux.org.uk

thx,

Jason.