Skip to contentSkip to conversation

package/shairport-sync: fix init script

PATCH New Jörg Krause 3 participants 3 messages Nov 12, 2014 – Nov 19, 2014

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH 1/1 package/shairport-sync: fix init script

shairport-sync uses libdaemon for running as daemon and creating the pidfile which conflicts with start-stop-daemons -b -m options. For that reason shairport-sync does not start using /etc/init.d/S99shairport-sync start.

The issue is fixed by removing the background and pidfile task from start-stop-daemon and add a daemon option -d to shairport-sync.

Signed-off-by J?rg Krause <[email protected]>
---
 package/shairport-sync/S99shairport-sync | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/shairport-sync/S99shairport-sync +2 -2
index 31359fc..54d20ff 100644
@@ -1,12 +1,12 @@
 #! /bin/sh
 
 # Additional options that are passed to Shairport Sync
-OPTIONS=""
+OPTIONS="-d"
 
 case "$1" in
     start)
 	echo -n "Starting shairport-sync: "
-	start-stop-daemon -S -q -m -b -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
+	start-stop-daemon -S -q -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
 	[ $? = 0 ] && echo "OK" || echo "FAIL"
 	;;
     stop)
Signature · 1 line
2.1.3
#1 lore raw

PATCH 1/1 package/shairport-sync: fix init script

J?rg, All,

On 2014-11-13 00:06 +0100, J?rg Krause spake thusly:

Quoted 8 lines

shairport-sync uses libdaemon for running as daemon and creating the pidfile which conflicts with start-stop-daemons -b -m options. For that reason shairport-sync does not start using /etc/init.d/S99shairport-sync start.

The issue is fixed by removing the background and pidfile task from start-stop-daemon and add a daemon option -d to shairport-sync.

Signed-off-by J?rg Krause <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 30 lines
---
 package/shairport-sync/S99shairport-sync | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/shairport-sync/S99shairport-sync +2 -2
index 31359fc..54d20ff 100644
@@ -1,12 +1,12 @@
 #! /bin/sh
 
 # Additional options that are passed to Shairport Sync
-OPTIONS=""
+OPTIONS="-d"
 
 case "$1" in
     start)
 	echo -n "Starting shairport-sync: "
-	start-stop-daemon -S -q -m -b -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
+	start-stop-daemon -S -q -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
 	[ $? = 0 ] && echo "OK" || echo "FAIL"
 	;;
     stop)
Signature · 6 lines
2.1.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 package/shairport-sync: fix init script

In reply to Jörg Krause

Dear J?rg Krause,

Quoted 11 lines · J?rg Krause

shairport-sync uses libdaemon for running as daemon and creating the pidfile which conflicts with start-stop-daemons -b -m options. For that reason shairport-sync does not start using /etc/init.d/S99shairport-sync start.

The issue is fixed by removing the background and pidfile task from start-stop-daemon and add a daemon option -d to shairport-sync.

Signed-off-by J?rg Krause <[email protected]>
---
 package/shairport-sync/S99shairport-sync | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com