Skip to contentSkip to conversation

usb: ehci: do not set the LSB of Current qTD pointer

PATCH New Masahiro Yamada 2 participants 2 messages Nov 17, 2014 – Nov 19, 2014

Subsystems (2)
USB USB ehci driver
lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 usb: ehci: do not set the LSB of Current qTD pointer

According to EHCI specification, the LSB of DWORD 3 of Queue Head (Current qTD Pointer) is not T-bit, but always zero.

Signed-off-by Masahiro Yamada <[email protected]>

---

 drivers/usb/host/ehci-hcd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/usb/host/ehci-hcd.c +0 -1
index c671c72..54e948a 100644
@@ -971,7 +971,6 @@ int usb_lowlevel_init(int index, enum usb_init_type init, void **controller)
 	qh_list->qh_link = cpu_to_hc32((uint32_t)qh_list | QH_LINK_TYPE_QH);
 	qh_list->qh_endpt1 = cpu_to_hc32(QH_ENDPT1_H(1) |
 						QH_ENDPT1_EPS(USB_SPEED_HIGH));
-	qh_list->qh_curtd = cpu_to_hc32(QT_NEXT_TERMINATE);
 	qh_list->qh_overlay.qt_next = cpu_to_hc32(QT_NEXT_TERMINATE);
 	qh_list->qh_overlay.qt_altnext = cpu_to_hc32(QT_NEXT_TERMINATE);
 	qh_list->qh_overlay.qt_token =
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 usb: ehci: do not set the LSB of Current qTD pointer

Quoted 4 lines · Masahiro Yamada

According to EHCI specification, the LSB of DWORD 3 of Queue Head (Current qTD Pointer) is not T-bit, but always zero.

Signed-off-by Masahiro Yamada <[email protected]>

Applied, thanks!

Best regards,
Marek Vasut