gfs2: gfs2_dir_get_hash_table(): avoiding deferred vfree() is easy here...
vfree() is allowed under spinlock these days, but it's cheaper when it doesn't step into deferred case and here it's very easy to avoid.
Signed-off-by Al Viro <[email protected]>
--- fs/gfs2/dir.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
fs/gfs2/dir.c +4 -3
@@ -370,11 +370,12 @@ static __be64 *gfs2_dir_get_hash_table(struct gfs2_inode *ip) }spin_lock (&inode->i_lock); -if (ip->i_hash_cache) -kvfree (hc); -else +if (likely (!ip->i_hash_cache)) { ip->i_hash_cache = hc; + hc =NULL ; + }spin_unlock (&inode->i_lock); +kvfree (hc);return ip->i_hash_cache; }
Signature · 1 line
1.7.10.4
----- Original Message -----
Quoted 28 lines
vfree()is allowed under spinlock these days, but it's cheaper when it doesn't step into deferred case and here it's very easy to avoid.Signed-off-by Al Viro <[email protected]>--- fs/gfs2/dir.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)fs/gfs2/dir.c +4
-3@@ -370,11 +370,12 @@ static __be64 *gfs2_dir_get_hash_table(struct gfs2_inode *ip) }spin_lock (&inode->i_lock); -if (ip->i_hash_cache) -kvfree (hc); -else +if (likely (!ip->i_hash_cache)) { ip->i_hash_cache = hc; + hc =NULL ; + }spin_unlock (&inode->i_lock); +kvfree (hc);return ip->i_hash_cache;
Quoted 5 lines
}
--
1.7.10.4
ACK
Bob Peterson
Red Hat File Systems
Hi,
All five patches now in the GFS2 -nmw tree. Thanks,
Steve.
Quoted 28 lines · Al Viro
vfree()is allowed under spinlock these days, but it's cheaper when it doesn't step into deferred case and here it's very easy to avoid.Signed-off-by Al Viro <[email protected]>--- fs/gfs2/dir.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)fs/gfs2/dir.c +4
-3@@ -370,11 +370,12 @@ static __be64 *gfs2_dir_get_hash_table(struct gfs2_inode *ip) }spin_lock (&inode->i_lock); -if (ip->i_hash_cache) -kvfree (hc); -else +if (likely (!ip->i_hash_cache)) { ip->i_hash_cache = hc; + hc =NULL ; + }spin_unlock (&inode->i_lock); +kvfree (hc);return ip->i_hash_cache; }