Skip to contentSkip to conversation

powerpc: mpc8xx: remove hermes board support

PATCH New Masahiro Yamada 3 participants 3 messages Nov 21, 2014 – Dec 8, 2014 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 powerpc: mpc8xx: remove hermes board support

This board sprinkles #ifdef(CONFIG_HERMES) over various global files such as include/common.h, common/board_r.c, common/cmd_bdinfo.c. Let's zap such an ill-behaved board.

It has not been converted to generic board yet and mpc8xx is old enough.

---

Changes in v2:
- fix a grammatical mistake the commit description

 arch/powerpc/cpu/mpc8xx/Kconfig    |   4 -
 arch/powerpc/cpu/mpc8xx/cpu_init.c |   3 +-
 arch/powerpc/lib/board.c           |  12 -
 board/hermes/Kconfig               |   9 -
 board/hermes/MAINTAINERS           |   6 -
 board/hermes/Makefile              |   8 -
 board/hermes/flash.c               | 444 ----------------------------
 board/hermes/hermes.c              | 590 -------------------------------------
 board/hermes/u-boot.lds            |  88 ------
 board/hermes/u-boot.lds.debug      | 121 --------
 common/board_r.c                   |  24 --
 common/cmd_bdinfo.c                |   3 -
 configs/hermes_defconfig           |   3 -
 doc/README.scrapyard               |   5 +-
 include/common.h                   |   5 -
 include/commproc.h                 |  28 --
 include/configs/hermes.h           | 315 --------------------
 17 files changed, 4 insertions(+), 1664 deletions(-)
 delete mode 100644 board/hermes/Kconfig
 delete mode 100644 board/hermes/MAINTAINERS
 delete mode 100644 board/hermes/Makefile
 delete mode 100644 board/hermes/flash.c
 delete mode 100644 board/hermes/hermes.c
 delete mode 100644 board/hermes/u-boot.lds
 delete mode 100644 board/hermes/u-boot.lds.debug
 delete mode 100644 configs/hermes_defconfig
 delete mode 100644 include/configs/hermes.h
arch/powerpc/cpu/mpc8xx/Kconfig +0 -4
index e447748e..99420ab 100644
@@ -13,9 +13,6 @@ config TARGET_COGENT_MPC8XX
 config TARGET_ESTEEM192E
 	bool "Support ESTEEM192E"
 
-config TARGET_HERMES
-	bool "Support hermes"
-
 config TARGET_IP860
 	bool "Support IP860"
 
@@ -112,7 +109,6 @@ source "board/LEOX/elpt860/Kconfig"
 source "board/RRvision/Kconfig"
 source "board/cogent/Kconfig"
 source "board/esteem192e/Kconfig"
-source "board/hermes/Kconfig"
 source "board/ip860/Kconfig"
 source "board/ivm/Kconfig"
 source "board/kup/kup4k/Kconfig"
arch/powerpc/cpu/mpc8xx/cpu_init.c +1 -2
index 60c401e..6a1cd46 100644
@@ -125,8 +125,7 @@ void cpu_init_f (volatile immap_t * immr)
 	 *  I owe him a free beer. - wd]
 	 */
 
-#if defined(CONFIG_HERMES)	|| \
-    defined(CONFIG_IP860)	|| \
+#if defined(CONFIG_IP860)	|| \
     defined(CONFIG_IVML24)	|| \
     defined(CONFIG_IVMS8)	|| \
     defined(CONFIG_LWMON)	|| \
arch/powerpc/lib/board.c +0 -12
index 6eaab88..e6d5355 100644
@@ -820,13 +820,6 @@ void board_init_r(gd_t *id, ulong dest_addr)
 	mac_read_from_eeprom();
 #endif
 
-#ifdef	CONFIG_HERMES
-	if ((gd->board_type >> 16) == 2)
-		bd->bi_ethspeed = gd->board_type & 0xFFFF;
-	else
-		bd->bi_ethspeed = 0xFFFF;
-#endif
-
 #ifdef CONFIG_CMD_NET
 	/* kept around for legacy kernels only ... ignore the next section */
 	eth_getenv_enetaddr("ethaddr", bd->bi_enetaddr);
@@ -876,11 +869,6 @@ void board_init_r(gd_t *id, ulong dest_addr)
 	misc_init_r();
 #endif
 
-#ifdef	CONFIG_HERMES
-	if (bd->bi_ethspeed != 0xFFFF)
-		hermes_start_lxt980((int) bd->bi_ethspeed);
-#endif
-
 #if defined(CONFIG_CMD_KGDB)
 	WATCHDOG_RESET();
 	puts("KGDB:  ");
board/hermes/Kconfig deleted +0 -9
deleted file mode 100644
index deb37fd..0000000
@@ -1,9 +0,0 @@
-if TARGET_HERMES
-
-config SYS_BOARD
-	default "hermes"
-
-config SYS_CONFIG_NAME
-	default "hermes"
-
-endif
board/hermes/MAINTAINERS deleted +0 -6
deleted file mode 100644
index a596dad..0000000
@@ -1,6 +0,0 @@
-HERMES BOARD
-M:	Wolfgang Denk <[email protected]>
-S:	Maintained
-F:	board/hermes/
-F:	include/configs/hermes.h
-F:	configs/hermes_defconfig
board/hermes/Makefile deleted +0 -8
deleted file mode 100644
index ccca520..0000000
@@ -1,8 +0,0 @@
-#
-# (C) Copyright 2000-2006
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-#
-# SPDX-License-Identifier:	GPL-2.0+
-#
-
-obj-y	= hermes.o flash.o
board/hermes/flash.c deleted +0 -444

444 lines not on this page · raw message

board/hermes/hermes.c deleted +0 -590

590 lines not on this page · raw message

board/hermes/u-boot.lds deleted +0 -88

88 lines not on this page · raw message

board/hermes/u-boot.lds.debug deleted +0 -121

121 lines not on this page · raw message

common/board_r.c +0 -24
index 7c33900..862dcf3 100644
@@ -453,24 +453,6 @@ static int initr_env(void)
 	return 0;
 }
 
-#ifdef	CONFIG_HERMES
-static int initr_hermes(void)
-{
-	if ((gd->board_type >> 16) == 2)
-		gd->bd->bi_ethspeed = gd->board_type & 0xFFFF;
-	else
-		gd->bd->bi_ethspeed = 0xFFFF;
-	return 0;
-}
-
-static int initr_hermes_start(void)
-{
-	if (gd->bd->bi_ethspeed != 0xFFFF)
-		hermes_start_lxt980((int) gd->bd->bi_ethspeed);
-	return 0;
-}
-#endif
-
 #ifdef CONFIG_SC3
 /* TODO: with new initcalls, move this into the driver */
 extern void sc3_read_eeprom(void);
@@ -802,9 +784,6 @@ init_fnc_t init_sequence_r[] = {
 #ifdef CONFIG_SC3
 	initr_sc3_read_eeprom,
 #endif
-#ifdef	CONFIG_HERMES
-	initr_hermes,
-#endif
 #if defined(CONFIG_ID_EEPROM) || defined(CONFIG_SYS_I2C_MAC_OFFSET)
 	mac_read_from_eeprom,
 #endif
@@ -830,9 +809,6 @@ init_fnc_t init_sequence_r[] = {
 #ifdef CONFIG_MISC_INIT_R
 	misc_init_r,		/* miscellaneous platform-dependent init */
 #endif
-#ifdef CONFIG_HERMES
-	initr_hermes_start,
-#endif
 	INIT_FUNC_WATCHDOG_RESET
 #ifdef CONFIG_CMD_KGDB
 	initr_kgdb,
common/cmd_bdinfo.c +0 -3
index 3d37a86..f0b713c 100644
@@ -144,9 +144,6 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	print_eth(5);
 #endif
 
-#ifdef CONFIG_HERMES
-	print_mhz("ethspeed",		bd->bi_ethspeed);
-#endif
 	printf("IP addr     = %s\n", getenv("ipaddr"));
 	printf("baudrate    = %6u bps\n", gd->baudrate);
 	print_num("relocaddr", gd->relocaddr);
configs/hermes_defconfig deleted +0 -3
deleted file mode 100644
index a923a61..0000000
@@ -1,3 +0,0 @@
-CONFIG_PPC=y
-CONFIG_8xx=y
-CONFIG_TARGET_HERMES=y
doc/README.scrapyard +3 -2
index 8ba6e0a..deb4af4 100644
@@ -12,8 +12,9 @@ The list should be sorted in reverse chronological order.
 
 Board            Arch        CPU            Commit      Removed     Last known maintainer/contact
 =================================================================================================
-PRS200		 powerpc     mpc5200	    -		-
-MCC200		 powerpc     mpc5200	    -		-
+hermes           powerpc     mpc8xx         -           -           Wolfgang Denk <[email protected]>
+PRS200		 powerpc     mpc5200	    ecfdcee	2014-11-12
+MCC200		 powerpc     mpc5200	    ecfdcee     2014-11-12
 TOP5200		 powerpc     mpc5200	    d58a945	2014-10-28  Reinhard Meyer <[email protected]>
 TOP860		 powerpc     mpc860	    d58a945	2014-10-28  Reinhard Meyer <[email protected]>
 TOP9000		 arm	     at91sam9xeXXX  d58a945	2014-10-28  Reinhard Meyer <[email protected]>
include/common.h +0 -5
index ce0a734..b0c45cd 100644
@@ -438,11 +438,6 @@ extern ssize_t spi_read	 (uchar *, int, uchar *, int);
 extern ssize_t spi_write (uchar *, int, uchar *, int);
 #endif
 
-#ifdef CONFIG_HERMES
-/* $(BOARD)/hermes.c */
-void hermes_start_lxt980 (int speed);
-#endif
-
 #ifdef CONFIG_EVB64260
 void  evb64260_init(void);
 void  debug_led(int, int);
include/commproc.h +0 -28
index d78ab00..6875c4c 100644
@@ -535,34 +535,6 @@ typedef struct scc_enet {
 #define SICR_ENET_CLKRT	((uint)0x00002600)
 #endif	/* CONFIG_FPS850L, CONFIG_FPS860L */
 
-/*** HERMES-PRO ******************************************************/
-
-/* The HERMES-PRO uses the FEC on a MPC860T for Ethernet */
-
-#ifdef CONFIG_HERMES
-
-#define	FEC_ENET	/* use FEC for EThernet */
-#undef	SCC_ENET
-
-
-#define PD_MII_TXD1	((ushort)0x1000)	/* PD  3 */
-#define PD_MII_TXD2	((ushort)0x0800)	/* PD  4 */
-#define PD_MII_TXD3	((ushort)0x0400)	/* PD  5 */
-#define PD_MII_RX_DV	((ushort)0x0200)	/* PD  6 */
-#define PD_MII_RX_ERR	((ushort)0x0100)	/* PD  7 */
-#define PD_MII_RX_CLK	((ushort)0x0080)	/* PD  8 */
-#define PD_MII_TXD0	((ushort)0x0040)	/* PD  9 */
-#define PD_MII_RXD0	((ushort)0x0020)	/* PD 10 */
-#define PD_MII_TX_ERR	((ushort)0x0010)	/* PD 11 */
-#define PD_MII_MDC	((ushort)0x0008)	/* PD 12 */
-#define PD_MII_RXD1	((ushort)0x0004)	/* PD 13 */
-#define PD_MII_RXD2	((ushort)0x0002)	/* PD 14 */
-#define PD_MII_RXD3	((ushort)0x0001)	/* PD 15 */
-
-#define PD_MII_MASK	((ushort)0x1FFF)	/* PD 3...15 */
-
-#endif	/* CONFIG_HERMES */
-
 /***  IP860  **********************************************************/
 
 #if defined(CONFIG_IP860)
include/configs/hermes.h deleted +0 -315

315 lines not on this page · raw message

Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 powerpc: mpc8xx: remove hermes board support

Dear Masahiro Yamada,

Quoted 9 lines · In message <[email protected]> you…

This board sprinkles #ifdef(CONFIG_HERMES) over various global files such as include/common.h, common/board_r.c, common/cmd_bdinfo.c. Let's zap such an ill-behaved board.

It has not been converted to generic board yet and mpc8xx is old enough.

The board has long been out of production, too.

Tom, can you take this directly, or shall I send a PR?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
... not meant for the weak-at-heart: /^(?=.*one)(?=.*two)/
If you can follow that, you can use it.
          - Randal L. Schwartz in <[email protected]>
#2 lore raw

PATCH v2 1/1 powerpc: mpc8xx: remove hermes board support

In reply to Masahiro Yamada
Quoted 10 lines · Masahiro Yamada

This board sprinkles #ifdef(CONFIG_HERMES) over various global files such as include/common.h, common/board_r.c, common/cmd_bdinfo.c. Let's zap such an ill-behaved board.

It has not been converted to generic board yet and mpc8xx is old enough.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141208/68454bab/attachment.pgp>