python-certifi: add new package

PATCH Superseded Yegor Yefremov 4 participants 11 messages Nov 22, 2014 – Nov 24, 2014

lore

Share & tools

lore

Yegor Yefremov

author

2014-11-22 09:46 UTC #0 lore raw

PATCH v2 1/1 python-certifi: add new package

Signed-off-by Yegor Yefremov <[email protected]>

---
Changes:
v2: add MPL incense

 package/Config.in                        |  1 +
 package/python-certifi/Config.in         |  6 ++++++
 package/python-certifi/python-certifi.mk | 14 ++++++++++++++
 3 files changed, 21 insertions(+)
 create mode 100644 package/python-certifi/Config.in
 create mode 100644 package/python-certifi/python-certifi.mk

package/Config.in +1 -0

index a6977ce..cffa8d4 100644
@@ -482,6 +482,7 @@ endif
 if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
 menu "external python modules"
 	source "package/python-bottle/Config.in"
+	source "package/python-certifi/Config.in"
 	source "package/python-cffi/Config.in"
 	source "package/python-configobj/Config.in"
 	source "package/python-configshell-fb/Config.in"

package/python-certifi/Config.in new file +6 -0

new file mode 100644
index 0000000..9390b4f
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_CERTIFI
+	bool "python-certifi"
+	help
+	  Python package for providing Mozilla's CA Bundle.
+
+	  https://pypi.python.org/pypi/certifi

package/python-certifi/python-certifi.mk new file +14 -0

new file mode 100644
index 0000000..1458a53
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-certifi
+#
+################################################################################
+
+PYTHON_CERTIFI_VERSION = 14.05.14
+PYTHON_CERTIFI_SOURCE = certifi-$(PYTHON_CERTIFI_VERSION).tar.gz
+PYTHON_CERTIFI_SITE = https://pypi.python.org/packages/source/c/certifi
+PYTHON_CERTIFI_SETUP_TYPE = setuptools
+PYTHON_CERTIFI_LICENSE = ISC, MPL
+PYTHON_CERTIFI_LICENSE_FILES = LICENSE
+
+$(eval $(python-package))

Signature · 1 line

1.8.3.2

Yann E. MORIN

2014-11-22 17:09 UTC #1 lore raw

PATCH v2 1/1 python-certifi: add new package

Yegor, All,

On 2014-11-22 10:46 +0100, Yegor Yefremov spake thusly:

Quoted 1 line

Signed-off-by Yegor Yefremov <[email protected]>

Please, add a hash file to this package:
http://nightly.buildroot.org/#adding-packages-hash

Here are the hashes I computed locally, which you can add as-is to the hash file:

sha1 f53dc8f57aaf6d69c183ebadcec52ece0a55cc3f certifi-14.05.14.tar.gz
sha256 1e1bcbacd6357c151ae37cf0290dcc809721d32ce21fd6b7339568f3ddef1b69 certifi-14.05.14.tar.gz

Regards,
Yann E. MORIN.

Quoted 62 lines

---
Changes:
v2: add MPL incense

 package/Config.in                        |  1 +
 package/python-certifi/Config.in         |  6 ++++++
 package/python-certifi/python-certifi.mk | 14 ++++++++++++++
 3 files changed, 21 insertions(+)
 create mode 100644 package/python-certifi/Config.in
 create mode 100644 package/python-certifi/python-certifi.mk

package/Config.in +1 -0

index a6977ce..cffa8d4 100644
@@ -482,6 +482,7 @@ endif
 if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
 menu "external python modules"
 	source "package/python-bottle/Config.in"
+	source "package/python-certifi/Config.in"
 	source "package/python-cffi/Config.in"
 	source "package/python-configobj/Config.in"
 	source "package/python-configshell-fb/Config.in"

package/python-certifi/Config.in new file +6 -0

new file mode 100644
index 0000000..9390b4f
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_CERTIFI
+	bool "python-certifi"
+	help
+	  Python package for providing Mozilla's CA Bundle.
+
+	  https://pypi.python.org/pypi/certifi

package/python-certifi/python-certifi.mk new file +14 -0

new file mode 100644
index 0000000..1458a53
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-certifi
+#
+################################################################################
+
+PYTHON_CERTIFI_VERSION = 14.05.14
+PYTHON_CERTIFI_SOURCE = certifi-$(PYTHON_CERTIFI_VERSION).tar.gz
+PYTHON_CERTIFI_SITE = https://pypi.python.org/packages/source/c/certifi
+PYTHON_CERTIFI_SETUP_TYPE = setuptools
+PYTHON_CERTIFI_LICENSE = ISC, MPL
+PYTHON_CERTIFI_LICENSE_FILES = LICENSE
+
+$(eval $(python-package))

Signature · 6 lines

1.8.3.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 13 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141122/f4d724a9/attachment.asc>

Thomas Petazzoni

2014-11-22 18:08 UTC #2 lore raw

PATCH v2 1/1 python-certifi: add new package

Dear Yann E. MORIN,

Quoted 5 lines · Yann E. MORIN

Here are the hashes I computed locally, which you can add as-is to the hash file:
sha1 f53dc8f57aaf6d69c183ebadcec52ece0a55cc3f certifi-14.05.14.tar.gz
sha256 1e1bcbacd6357c151ae37cf0290dcc809721d32ce21fd6b7339568f3ddef1b69 certifi-14.05.14.tar.gz

Why do we suggest to have two hashes? Isn't sha265 sufficient?

Also, is it necessary to align the different columns? Should it be done with tabs or spaces? I've seen different solutions being used.

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Yann E. MORIN

2014-11-22 18:56 UTC #3 lore raw

PATCH v2 1/1 python-certifi: add new package

Thomas, All,

On 2014-11-22 19:08 +0100, Thomas Petazzoni spake thusly:

Quoted 9 lines · Yann E. MORIN

Quoted 6 lines
Here are the hashes I computed locally, which you can add as-is to the hash file:
sha1 f53dc8f57aaf6d69c183ebadcec52ece0a55cc3f certifi-14.05.14.tar.gz
sha256 1e1bcbacd6357c151ae37cf0290dcc809721d32ce21fd6b7339568f3ddef1b69 certifi-14.05.14.tar.gz
Why do we suggest to have two hashes? Isn't sha265 sufficient?

As Gustavo said, that's because sha1 and sha256 are two different hash mechanisms, and it's better to have both.

So I was following his advice, even though I don't mind adding just the sha256.

Quoted 2 lines

Also, is it necessary to align the different columns? Should it be done with tabs or spaces? I've seen different solutions being used.

I don't mind not aligning the fields, though I find it more convenient to read if they are.

If they get aligned, I think we should use spaces; tabs do not help because people may have different tabwidths.

Also, aligning with spaces is what we are doing for _PREMISSIONS and _USERS, so I think that's OK to align.

Also, the manual states:

Note: the number of spaces does not matter, so one can use spaces to properly align the different fields.

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Thomas Petazzoni

2014-11-22 19:59 UTC #4 lore raw

PATCH v2 1/1 python-certifi: add new package

Dear Yann E. MORIN,

Quoted 10 lines · Yann E. MORIN

Quoted 4 lines
Quoted 2 lines
sha1 f53dc8f57aaf6d69c183ebadcec52ece0a55cc3f certifi-14.05.14.tar.gz
sha256 1e1bcbacd6357c151ae37cf0290dcc809721d32ce21fd6b7339568f3ddef1b69 certifi-14.05.14.tar.gz
Why do we suggest to have two hashes? Isn't sha265 sufficient?
As Gustavo said, that's because sha1 and sha256 are two different hash mechanisms, and it's better to have both.
So I was following his advice, even though I don't mind adding just the sha256.

Hum. We need some decision here :)

Quoted 9 lines

Quoted 2 lines
Also, is it necessary to align the different columns? Should it be done with tabs or spaces? I've seen different solutions being used.
I don't mind not aligning the fields, though I find it more convenient to read if they are.
If they get aligned, I think we should use spaces; tabs do not help because people may have different tabwidths.

Quoted 7 lines

Also, aligning with spaces is what we are doing for _PREMISSIONS and _USERS, so I think that's OK to align.
Also, the manual states:
Note: the number of spaces does not matter, so one can use spaces to properly align the different fields.

And Peter, when reviewing the scancpan script, which did align things with spaces, was wondering why the script was doing this weird indentation.

We also need some decision here :-)

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Yegor Yefremov

author

2014-11-22 20:16 UTC #5 lore raw

PATCH v2 1/1 python-certifi: add new package

Quoted 31 lines · Thomas Petazzoni

Dear Yann E. MORIN,
Quoted 10 lines · Yann E. MORIN
Quoted 4 lines
Quoted 2 lines
sha1 f53dc8f57aaf6d69c183ebadcec52ece0a55cc3f certifi-14.05.14.tar.gz
sha256 1e1bcbacd6357c151ae37cf0290dcc809721d32ce21fd6b7339568f3ddef1b69 certifi-14.05.14.tar.gz
Why do we suggest to have two hashes? Isn't sha265 sufficient?
As Gustavo said, that's because sha1 and sha256 are two different hash mechanisms, and it's better to have both.
So I was following his advice, even though I don't mind adding just the sha256.
Hum. We need some decision here :)
Quoted 14 lines
Quoted 2 lines
Also, is it necessary to align the different columns? Should it be done with tabs or spaces? I've seen different solutions being used.
I don't mind not aligning the fields, though I find it more convenient to read if they are.
If they get aligned, I think we should use spaces; tabs do not help because people may have different tabwidths.
Also, aligning with spaces is what we are doing for _PREMISSIONS and _USERS, so I think that's OK to align.
Also, the manual states:

Quoted 8 lines

Quoted 2 lines
Note: the number of spaces does not matter, so one can use spaces to properly align the different fields.
And Peter, when reviewing the scancpan script, which did align things with spaces, was wondering why the script was doing this weird indentation.
We also need some decision here :-)

How should I include hash for this package?

Yegor

Thomas Petazzoni

2014-11-22 20:24 UTC #6 lore raw

PATCH v2 1/1 python-certifi: add new package

Dear Yegor Yefremov,

Quoted 1 line · Yegor Yefremov

How should I include hash for this package?

Don't worry about the hash for now. I'll commit either one hash or two hashes, and I won't really care about the indentation of the hash file.

The real question is the license one.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Yegor Yefremov

author

2014-11-22 20:32 UTC #7 lore raw

PATCH v2 1/1 python-certifi: add new package

Quoted 10 lines · Thomas Petazzoni

Dear Yegor Yefremov,
Quoted 1 line · Yegor Yefremov
How should I include hash for this package?
Don't worry about the hash for now. I'll commit either one hash or two hashes, and I won't really care about the indentation of the hash file.
The real question is the license one.

I'd add this:

PYTHON_CERTIFI_LICENSE = Python code: ISC, cacert.pem: MPL

The certifi author didn't answer my mail request.

Yegor

Thomas Petazzoni

2014-11-22 20:44 UTC #8 lore raw

PATCH v2 1/1 python-certifi: add new package

Dear Yegor Yefremov,

Quoted 3 lines · Yegor Yefremov

I'd add this:
PYTHON_CERTIFI_LICENSE = Python code: ISC, cacert.pem: MPL

It should be:

PYTHON_CERTIFI_LICENSE = ISC (Python code), MPL-2.0 (cacert.pem)

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Peter Korsgaard

2014-11-24 22:01 UTC #9 lore raw

PATCH v2 1/1 python-certifi: add new package

In reply to Thomas Petazzoni

Quoted 10 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Dear Yann E. MORIN,
Quoted 5 lines · Yann E. MORIN
Quoted 4 lines
Quoted 2 lines
sha1 f53dc8f57aaf6d69c183ebadcec52ece0a55cc3f certifi-14.05.14.tar.gz
sha256 1e1bcbacd6357c151ae37cf0290dcc809721d32ce21fd6b7339568f3ddef1b69 certifi-14.05.14.tar.gz
Why do we suggest to have two hashes? Isn't sha265 sufficient?

Quoted 7 lines

Quoted 5 lines
As Gustavo said, that's because sha1 and sha256 are two different hash mechanisms, and it's better to have both.
So I was following his advice, even though I don't mind adding just the sha256.
Hum. We need some decision here :)

Ehh, I don't really know. I believe we have agreed on adding an extra hash if upstream only publishes a weak one (E.G. md5), but requiring both sha1 and sha256 is imho overkill.

In general, I would say lets use sha256 if we need to calculate it ourselves, and otherwise whatever upstream publishes (unless it is md5, then we add sha256 ourselves).

Quoted 8 lines

Quoted 2 lines
Note: the number of spaces does not matter, so one can use spaces to properly align the different fields.
And Peter, when reviewing the scancpan script, which did align things with spaces, was wondering why the script was doing this weird indentation.
We also need some decision here :-)

Well, there's the spaces between the hashtype and the hash, and then there's the space between the hash and the filename. I find it nicer to read if the hashes are aligned, and I prefer to be able to use the output of ${foo}sum directly for the hash + filename, which I why I suggested:

type\thash filename

(two spaces between hash and filename) during the scanpan review, so you can do stuff like:

for i in md5 sha256; do echo -en "$i\t"; ${i}sum <file>; done > foo.hash

But it is not something I feel strongly about. Consistency between the different packages would be good though.

Signature · 1 line

Bye, Peter Korsgaard

Thomas Petazzoni

2014-11-22 17:15 UTC #10 lore raw

PATCH v2 1/1 python-certifi: add new package

In reply to Yegor Yefremov

Dear Yegor Yefremov,

package/python-certifi/python-certifi.mk line 11

Quoted 5 lines · Yegor Yefremov

package/python-certifi/python-certifi.mk new file +5 -0

+PYTHON_CERTIFI_VERSION = 14.05.14
+PYTHON_CERTIFI_SOURCE = certifi-$(PYTHON_CERTIFI_VERSION).tar.gz
+PYTHON_CERTIFI_SITE = https://pypi.python.org/packages/source/c/certifi
+PYTHON_CERTIFI_SETUP_TYPE = setuptools
+PYTHON_CERTIFI_LICENSE = ISC, MPL

Can this be more specific, like to what part the ISC license applies, and to what part the MPL license applies?

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com