Disable sample xerces
PATCH 1/1 Disable sample xerces
Hi all,
New try to send a patch with git send-email. This patch remove building and installing sample for xerces. If it's good, I have other patch to remove building and/or installing of sample or example or dev file in some package.
Best Regards,
Signature · 10 lines
Damien Lanson / Research and Development Engineer ZeeTim 15 b rue Frederic Joliot Currie, FR 94400 Vitry-sur-Seine www.zeetim.com Signed-off-by: Damien Lanson <[email protected]> --- package/xerces/xerces.mk | 7 +++++++ 1 file changed, 7 insertions(+)
package/xerces/xerces.mk +7 -0
@@ -11,6 +11,13 @@ XERCES_LICENSE = Apache-2.0 XERCES_LICENSE_FILES = LICENSE XERCES_MAKE = $(MAKE1) XERCES_INSTALL_STAGING = YES + +define XERCES_DISABLE_SAMPLES + $(SED) 's/ samples//' $(@D)/Makefile.in +endef + +XERCES_POST_PATCH_HOOKS += XERCES_DISABLE_SAMPLES + XERCES_CONF_OPTS = --disable-threads \ --with-gnu-ld
Signature · 1 line
1.7.10.4
PATCH 1/1 Disable sample xerces
Dear Damien Lanson,
Thanks for your contribution!
Quoted 3 lines · Damien Lanson
New try to send a patch with git send-email. This patch remove building and installing sample for xerces. If it's good, I have other patch to remove building and/or installing of sample or example or dev file in some package.
Unfortunately, this is not good yet to be applied. When you do a "git format-patch", you should send the patch unchanged with "git send-email". Or if you want to make some comments, do them below the "---" sign. Right now, from the point of view of git, the description of your patch is the personal message "New try to send a patch ...".
Basically, your process to send the patch should be:
git format-patch HEAD^ git send-email 0001-....patch
Also, while your patch certainly works, it would be good to have a solution that can potentially be submitted upstream, by patching configure.ac to provide a --enable-samples/--disable-samples option.
It's also a good idea to add a small commit log to explain why this commit is needed. And finally, the title of your commit should be:
xerces: disable the build of samples
i.e, it should always have "<pkg>: " as a prefix.
Can you resend an updated version of your patch with those changes?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Thomas Petazzoni
AppliedPATCH 1/1 Disable sample xerces
In reply to Damien LansonDear Damien Lanson,
Quoted 3 lines · Damien Lanson
New try to send a patch with git send-email. This patch remove building and installing sample for xerces. If it's good, I have other patch to remove building and/or installing of sample or example or dev file in some package.
Thanks, applied after tweaking the commit log, and rebased on master.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com