Skip to contentSkip to conversation

gst1-validate: needs python

PATCH New Peter Seiderer 2 participants 2 messages Nov 13, 2014 – Nov 22, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 gst1-validate: needs python

If host installed python version is < 2.7.0 gst1-validate compile will fail with

checking for a Python interpreter with version >= 2.7.0... none
configure: error: no suitable Python interpreter found

Fixed by adding host-python dependency.

Target tool /usr/bin/gst-validate-launcher is a python2 script

	$ head -1 /usr/bin/gst-validate-launcher
	#!/usr/bin/env python2

(and not easily upgradable to python3) so add python2 dependency and to fix the following runtime error

	$ gst-validate-launcher
	Traceback (most recent call last):
	  File "/usr/bin/gst-validate-launcher", line 44, in <module>
	    from launcher.main import main
	  File "/usr/lib/gst-validate-launcher/python/launcher/main.py", line 26, in <module>
	    import reporters
	  File "/usr/lib/gst-validate-launcher/python/launcher/reporters.py", line 29, in <module>
	    from xml.sax import saxutils
	ImportError: No module named xml.sax

add additional BR2_PACKAGE_PYTHON_PYEXPAT select.

Fixes:
http://autobuild.buildroot.net/results/e8c/e8c27db2a0935c2daef173d5650f6a2b3a219493/
http://autobuild.buildroot.net/results/723/723fe3036e8f0af2a90ff9e98173387466655000/

---
Changes v3 -> v4:
- changelog update (as suggested by Vicente Olivert Riera)

Changes v2 -> v3:
- add select BR2_PACKAGE_PYTHON_PYEXPAT (enables python xml package needed by gst-validate-launcher)

Changes v1 -> v2:
- changed from python/python3 to python only (python3 is not usable because gst-validate-launcher script is python2 only, see [1] from Vicente Olivert Riera)

[1] http://lists.busybox.net/pipermail/buildroot/2014-November/111907.html

---
 package/gstreamer1/gst1-validate/Config.in        | 7 ++++++-
 package/gstreamer1/gst1-validate/gst1-validate.mk | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)
package/gstreamer1/gst1-validate/Config.in +6 -1
index ffcdd27..34ec85f 100644
@@ -1,9 +1,14 @@
-menuconfig BR2_PACKAGE_GST1_VALIDATE
+config BR2_PACKAGE_GST1_VALIDATE
 	bool "gst1-validate"
+	depends on BR2_PACKAGE_PYTHON
 	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_PYTHON_PYEXPAT
 	help
 	  GstValidate is a tool that allows GStreamer developers to
 	  check that the GstElements they write behave the way they
 	  are supposed to.
 
 	  http://gstreamer.freedesktop.org/
+
+comment "gst1-validate depends on python"
+	depends on !BR2_PACKAGE_PYTHON
package/gstreamer1/gst1-validate/gst1-validate.mk +1 -1
index 4972cac..9a9e796 100644
@@ -12,6 +12,6 @@ GST1_VALIDATE_LICENSE_FILES = COPYING
 
 GST1_VALIDATE_CONF_OPTS = --disable-sphinx-doc
 
-GST1_VALIDATE_DEPENDENCIES = gstreamer1 gst1-plugins-base
+GST1_VALIDATE_DEPENDENCIES = gstreamer1 gst1-plugins-base host-python python
 
 $(eval $(autotools-package))
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH v4 1/1 gst1-validate: needs python

Dear Peter Seiderer,

Quoted 25 lines · Peter Seiderer

If host installed python version is < 2.7.0 gst1-validate compile will fail with

checking for a Python interpreter with version >= 2.7.0... none
configure: error: no suitable Python interpreter found

Fixed by adding host-python dependency.

Target tool /usr/bin/gst-validate-launcher is a python2 script

	$ head -1 /usr/bin/gst-validate-launcher
	#!/usr/bin/env python2

(and not easily upgradable to python3) so add python2 dependency and to fix the following runtime error

	$ gst-validate-launcher
	Traceback (most recent call last):
	  File "/usr/bin/gst-validate-launcher", line 44, in <module>
	    from launcher.main import main
	  File "/usr/lib/gst-validate-launcher/python/launcher/main.py", line 26, in <module>
	    import reporters
	  File "/usr/lib/gst-validate-launcher/python/launcher/reporters.py", line 29, in <module>
	    from xml.sax import saxutils
	ImportError: No module named xml.sax
Quoted 7 lines

add additional BR2_PACKAGE_PYTHON_PYEXPAT select.

Fixes:
http://autobuild.buildroot.net/results/e8c/e8c27db2a0935c2daef173d5650f6a2b3a219493/
http://autobuild.buildroot.net/results/723/723fe3036e8f0af2a90ff9e98173387466655000/

Patch applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com