Skip to contentSkip to conversation

mpdecimal: disable static build

PATCH New Baruch Siach 3 participants 4 messages Nov 23, 2014 – Nov 24, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpdecimal: disable static build

mpdecimal always tries to build its shared library.

Fixes:
http://autobuild.buildroot.net/results/276/2764bd8c42ba659682760ffc6afa933b7530d06c/
http://autobuild.buildroot.net/results/3cc/3cca0aacc4d66c49b21d23681813abea5a1b32e0/
http://autobuild.buildroot.net/results/207/20783d1448464d957862e1c70585844f86aed237/

---
 package/mpdecimal/Config.in | 4 ++++
 package/python3/Config.in   | 4 ++++
 2 files changed, 8 insertions(+)
package/mpdecimal/Config.in +4 -0
index 929d41514399..2aae520c15d9 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_MPDECIMAL
 	bool "mpdecimal"
 	help
+	depends on !BR2_PREFER_STATIC_LIB
 	  mpdecimal is a package for correctly-rounded arbitrary
 	  precision decimal floating point arithmetic. Starting from
 	  version 2.4, mpdecimal includes only the libmpdec
@@ -8,3 +9,6 @@ config BR2_PACKAGE_MPDECIMAL
 	  exclusively on libmpdec.
 
 	  http://www.bytereef.org/mpdecimal/
+
+comment "mpdecimal needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
package/python3/Config.in +4 -0
index 375390fcf69d..afcb74229474 100644
@@ -57,10 +57,14 @@ config BR2_PACKAGE_PYTHON3_CURSES
 
 config BR2_PACKAGE_PYTHON3_DECIMAL
 	select BR2_PACKAGE_MPDECIMAL
+	depends on !BR2_PREFER_STATIC_LIB # mpdecimal
 	bool "decimal module"
 	help
 	  decimal module for Python3.
 
+comment "decimal module needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
+
 config BR2_PACKAGE_PYTHON3_PYEXPAT
 	select BR2_PACKAGE_EXPAT
 	bool "pyexpat"
Signature · 1 line
2.1.3
#1 lore raw

PATCH 1/1 mpdecimal: disable static build

Dear Baruch Siach,

Quoted 8 lines · Baruch Siach

mpdecimal always tries to build its shared library.

Fixes:
http://autobuild.buildroot.net/results/276/2764bd8c42ba659682760ffc6afa933b7530d06c/
http://autobuild.buildroot.net/results/3cc/3cca0aacc4d66c49b21d23681813abea5a1b32e0/
http://autobuild.buildroot.net/results/207/20783d1448464d957862e1c70585844f86aed237/

While in flight, I have just cooked a patch that allows to build mpdecimal only as a static library. I'll send it later today.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 mpdecimal: disable static build

In reply to Baruch Siach

Baruch, All,

On 2014-11-23 11:08 +0200, Baruch Siach spake thusly:

Quoted 8 lines

mpdecimal always tries to build its shared library.

Fixes:
http://autobuild.buildroot.net/results/276/2764bd8c42ba659682760ffc6afa933b7530d06c/
http://autobuild.buildroot.net/results/3cc/3cca0aacc4d66c49b21d23681813abea5a1b32e0/
http://autobuild.buildroot.net/results/207/20783d1448464d957862e1c70585844f86aed237/

Beside the fact that Thomas P. has a fix for building static, I have a comment on that patch of yours...

Quoted 10 lines
---
 package/mpdecimal/Config.in | 4 ++++
 package/python3/Config.in   | 4 ++++
 2 files changed, 8 insertions(+)
package/mpdecimal/Config.in +0 -0
index 929d41514399..2aae520c15d9 100644

package/mpdecimal/Config.in line 7

Quoted 7 lines
package/mpdecimal/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_MPDECIMAL
 	bool "mpdecimal"
 	help
+	depends on !BR2_PREFER_STATIC_LIB
 	  mpdecimal is a package for correctly-rounded arbitrary
 	  precision decimal floating point arithmetic. Starting from
 	  version 2.4, mpdecimal includes only the libmpdec

Really? This makes the "depends on" part of the help text...

Regards,
Yann E. MORIN.

Quoted 33 lines
package/mpdecimal/Config.in +3 -0
@@ -8,3 +9,6 @@ config BR2_PACKAGE_MPDECIMAL
 	  exclusively on libmpdec.
 
 	  http://www.bytereef.org/mpdecimal/
+
+comment "mpdecimal needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
package/python3/Config.in +4 -0
index 375390fcf69d..afcb74229474 100644
@@ -57,10 +57,14 @@ config BR2_PACKAGE_PYTHON3_CURSES
 
 config BR2_PACKAGE_PYTHON3_DECIMAL
 	select BR2_PACKAGE_MPDECIMAL
+	depends on !BR2_PREFER_STATIC_LIB # mpdecimal
 	bool "decimal module"
 	help
 	  decimal module for Python3.
 
+comment "decimal module needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
+
 config BR2_PACKAGE_PYTHON3_PYEXPAT
 	select BR2_PACKAGE_EXPAT
 	bool "pyexpat"
Signature · 6 lines
2.1.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 mpdecimal: disable static build

Hi Yann,

Quoted 15 lines · Yann E. MORIN

On 2014-11-23 11:08 +0200, Baruch Siach spake thusly:

package/mpdecimal/Config.in line 7

Quoted 12 lines
package/mpdecimal/Config.in +1 -0
index 929d41514399..2aae520c15d9 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_MPDECIMAL
 	bool "mpdecimal"
 	help
+	depends on !BR2_PREFER_STATIC_LIB
 	  mpdecimal is a package for correctly-rounded arbitrary
 	  precision decimal floating point arithmetic. Starting from
 	  version 2.4, mpdecimal includes only the libmpdec

Really? This makes the "depends on" part of the help text...

Ah, my bad. I already marked this patch as Superseded in patchwork, as Thomas' patch will hopefully actually fix static build.

Thanks for reviewing, anyway.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -