clk: sunxi: Remove ahb1_sdram from sun6i/sun8i protected clocks list
PATCH 1/1 clk: sunxi: Remove ahb1_sdram from sun6i/sun8i protected clocks list
The ahb1_sdram clock gate is only used for accessing the sdram controller's registers over the bus. It is not used for actually clock the controller or the dram, hence it does not need to be protected.
This also gets rid of the problem when the protected ahb1_sdram gate is prepared/enabled while it is still an orphan, and the operation is not propagated to the correct parent.
This was confirmed on my A23 tablet and my A31 Hummingbird.
--- drivers/clk/sunxi/clk-sunxi.c | 1 - 1 file changed, 1 deletion(-)
drivers/clk/sunxi/clk-sunxi.c +0 -1
@@ -1425,7 +1425,6 @@ CLK_OF_DECLARE(sun7i_a20_clk_init, "allwinner,sun7i-a20", sun5i_init_clocks);static const char *sun6i_critical_clocks[]__initdata = {"cpu" , -"ahb1_sdram" , };static void __init sun6i_init_clocks (struct device_node *node)
Signature · 1 line
2.1.3
Maxime Ripard
AppliedPATCH 1/1 clk: sunxi: Remove ahb1_sdram from sun6i/sun8i protected clocks list
Quoted 11 lines · Chen-Yu Tsai
The
ahb1_sdramclock gate is only used for accessing the sdram controller's registers over the bus. It is not used for actually clock the controller or the dram, hence it does not need to be protected.This also gets rid of the problem when the protected
ahb1_sdramgate is prepared/enabled while it is still an orphan, and the operation is not propagated to the correct parent.This was confirmed on my A23 tablet and my A31 Hummingbird.
Signed-off-by Chen-Yu Tsai <[email protected]>
Queued for 3.20, thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141125/776e12f9/attachment.sig>