Skip to contentSkip to conversation

linux-next: build warning after merge of the irqchip tree

PATCH New Stephen Rothwell 2 participants 2 messages Nov 27, 2014 – Nov 28, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Jason,

After merging the irqchip tree, today's linux-next build (arm multi_v7_defconfig) produced this warning:

include/linux/irqchip/arm-gic.h:109:53: warning: its scope is only this definition or declaration, which is probably not what you want In file included from arch/arm/mach-ux500/pm.c:13:0:
include/linux/irqchip/arm-gic.h:109:53: warning: 'struct irq_domain' declared inside parameter list

 int gicv2m_of_init(struct device_node *node, struct irq_domain *parent);
                                                     ^

and many more similar.

Introduced by commit 853a33ce6932 ("irqchip: gic-v2m: Add support for ARM GICv2m MSI(-X) doorbell").

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#1 lore raw

PATCH 1/1 irqchip: gic: Remove warning by including linux/irqdomain.h

Commit

853a33ce6932 irqchip: gic-v2m: Add support for ARM GICv2m MSI(-X) doorbell

Introduced a series of warnings when building ARM multi_v7_defconfig:

include/linux/irqchip/arm-gic.h:109:53: warning: its scope is only this definition or declaration, which is probably not what you want In file included from arch/arm/mach-ux500/pm.c:13:0:
include/linux/irqchip/arm-gic.h:109:53: warning: 'struct irq_domain' declared inside parameter list

   int gicv2m_of_init(struct device_node *node, struct irq_domain *parent);
                                                       ^

Fix this by adding the proper include.

---
I've added this to irqchip/irqdomain-arm locally and pushed it to next. If there are no objections, I'll push it to irqchip/irqdomain-arm.

thx,

Jason.

 include/linux/irqchip/arm-gic.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/irqchip/arm-gic.h +2 -0
index 60b09ed58cae..d1b2263a4db3 100644
@@ -10,6 +10,8 @@
 #ifndef __LINUX_IRQCHIP_ARM_GIC_H
 #define __LINUX_IRQCHIP_ARM_GIC_H
 
+#include <linux/irqdomain.h>
+
 #define GIC_CPU_CTRL			0x00
 #define GIC_CPU_PRIMASK			0x04
 #define GIC_CPU_BINPOINT		0x08
Signature · 1 line
2.1.3