arm64: enable ARCH_HAS_BANDGAP config

Some of the existing thermal drivers (ti and exynos) have a dependency on ARCH_HAS_BANDGAP. Activate ARCH_HAS_BANDGAP config entry for ARM64 so that these drivers may be re-used.

Signed-off-by Abhilash Kesavan <[email protected]>

---

 arch/arm64/Kconfig |    3 +++
 1 file changed, 3 insertions(+)

arch/arm64/Kconfig +3 -1

index 5bb1900..7c452e4 100644
@@ -139,6 +139,9 @@ config KERNEL_MODE_NEON
 config FIX_EARLYCON_MEM
        def_bool y
 
+config ARCH_HAS_BANDGAP
+       def_bool y
+
 source "init/Kconfig"
 
 source "kernel/Kconfig.freezer"
--

1.7.9.5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Quoted 6 lines · Abhilash Kesavan

Some of the existing thermal drivers (ti and exynos) have a dependency on ARCH_HAS_BANDGAP. Activate ARCH_HAS_BANDGAP config entry for ARM64 so that these drivers may be re-used.

Signed-off-by Abhilash Kesavan <[email protected]>

---

HAS_BANDGAP was added to ARM to indicate that arch supports a bandgap device like a thermal management unit, so this looks good to me.

Quoted 9 lines · Alim Akhtar

Quoted 6 lines · Abhilash Kesavan

Some of the existing thermal drivers (ti and exynos) have a dependency on ARCH_HAS_BANDGAP. Activate ARCH_HAS_BANDGAP config entry for ARM64 so that these drivers may be re-used.

Signed-off-by Abhilash Kesavan <[email protected]>

---

HAS_BANDGAP was added to ARM to indicate that arch supports a bandgap device like a thermal management unit, so this looks good to me.

But it doesn't look good to me. ARCH_HAS_* kind of implies that the architecture has some feature or the port provides some feature. But in the current use, it simply allows the enabling of the menu config entries for two drivers (EXYNOS_THERMAL and TI_SOC_THERMAL).

If you want to specify that the SoC has a device, just use DT and not some random config option that only enables the menu entry for the corresponding driver.

--
Catalin

Quoted 16 lines · Catalin Marinas

Quoted 9 lines · Alim Akhtar

Quoted 6 lines · Abhilash Kesavan

Some of the existing thermal drivers (ti and exynos) have a dependency on ARCH_HAS_BANDGAP. Activate ARCH_HAS_BANDGAP config entry for ARM64 so that these drivers may be re-used.

Signed-off-by Abhilash Kesavan <[email protected]>

---

HAS_BANDGAP was added to ARM to indicate that arch supports a bandgap device like a thermal management unit, so this looks good to me.

But it doesn't look good to me. ARCH_HAS_* kind of implies that the architecture has some feature or the port provides some feature. But in the current use, it simply allows the enabling of the menu config entries for two drivers (EXYNOS_THERMAL and TI_SOC_THERMAL).

Quoted 3 lines

If you want to specify that the SoC has a device, just use DT and not some random config option that only enables the menu entry for the corresponding driver.

So, you are suggesting that the ARCH_HAS_BANDGAP dependency for these two drivers be removed ? I am not aware of the history behind adding this symbol, but as it is only used by the 2 platforms it should be easy to remove.

Quoted 9 lines · Alim Akhtar

Quoted 6 lines · Abhilash Kesavan

Some of the existing thermal drivers (ti and exynos) have a dependency on ARCH_HAS_BANDGAP. Activate ARCH_HAS_BANDGAP config entry for ARM64 so that these drivers may be re-used.

Signed-off-by Abhilash Kesavan <[email protected]>

---

HAS_BANDGAP was added to ARM to indicate that arch supports a bandgap device like a thermal management unit, so this looks good to me.

But it doesn't look good to me. ARCH_HAS_* kind of implies that the architecture has some feature or the port provides some feature. But in the current use, it simply allows the enabling of the menu config entries for two drivers (EXYNOS_THERMAL and TI_SOC_THERMAL).

If you want to specify that the SoC has a device, just use DT and not some random config option that only enables the menu entry for the corresponding driver.

--
Catalin