autotools: Fix wrong ./configure help screen default values
PATCH 1/1 autotools: Fix wrong ./configure help screen default values
From: David Sommerseth <[email protected]...>
enable_crypto_ofb_cfb is "yes" by default, so the --help screen should show --disable-ofb-cfb and not --enable-ofb-cfb.
enable_small and enable_password_save are both "no" by default, so the --help screen should state "default: no". Now it says "yes" as default, but is really disabled in the reality.
--- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
configure.ac +3 -3
@@ -73,7 +73,7 @@ AC_ARG_ENABLE( AC_ARG_ENABLE( [ofb-cfb], - [AS_HELP_STRING([--enable-ofb-cfb], [enable support for OFB and CFB cipher modes @<:@default=yes@:>@])], + [AS_HELP_STRING([--disable-ofb-cfb], [disable support for OFB and CFB cipher modes @<:@default=yes@:>@])], , [enable_crypto_ofb_cfb="yes"] )
@@ -157,14 +157,14 @@ AC_ARG_ENABLE( AC_ARG_ENABLE( [small], - [AS_HELP_STRING([--enable-small], [enable smaller executable size (disable OCC, usage message, and verb 4 parm list) @<:@default=yes@:>@])], + [AS_HELP_STRING([--enable-small], [enable smaller executable size (disable OCC, usage message, and verb 4 parm list) @<:@default=no@:>@])], , [enable_small="no"] ) AC_ARG_ENABLE( [password-save], - [AS_HELP_STRING([--enable-password-save], [allow --askpass and --auth-user-pass passwords to be read from a file @<:@default=yes@:>@])], + [AS_HELP_STRING([--enable-password-save], [allow --askpass and --auth-user-pass passwords to be read from a file @<:@default=no@:>@])], , [enable_password_save="no"] )
Signature · 1 line
1.8.3.1
ACK.
Your patch has been applied to the master and release/2.3 branches.
Since we agreed that we actually want to get rid of --enable-password-save (unconditionally enable it, get rid of the autoconf option) this might seem to be a bit redundant, but the patch is there, and it won't harm to make what we have correct :-)
As a matter of discussion, I wonder why we have "default=yes" and "no" in our --help text, and not "default=enabled"/"disabled", which might be slightly less confusing... any autoconf style guides here?
commit 104360b4f40a4ba29987d9478aed70450fec75a2 (master) commit 995be6fdc07f1280c46eec0c9b86f690124fb30f (release/2.3)
Author: David Sommerseth Date: Mon Nov 24 19:09:38 2014 +0100
autotools: Fix wrong ./configure help screen default values
Signed-off-by: David Sommerseth <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
URL: http://article.gmane.org/gmane.network.openvpn.devel/9278
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 5 lines · Gert Doering
As a matter of discussion, I wonder why we have "default=yes" and "no" in our --help text, and not "default=enabled"/"disabled", which might be slightly less confusing... any autoconf style guides here?
Do we need the "default=" stuff at all? Isn't the default state quite obvious when you see --enable-feature-abc or --disable-feature-xyz?
- --
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlR8plsACgkQDC186MBRfrqzFACbBBY7j7x/FG9GAkij7IKje5KS sREAoJygMPmlnZvqIXgchrnY8oA3gHZV
=jvC0
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Quoted 9 lines · David Sommerseth
Quoted 4 lines · Gert Doering
As a matter of discussion, I wonder why we have "default=yes" and "no" in our --help text, and not "default=enabled"/"disabled", which might be slightly less confusing... any autoconf style guides here?
Do we need the "default=" stuff at all? Isn't the default state quite obvious when you see --enable-feature-abc or --disable-feature-xyz?
I don't think we need the "default=" stuff, the --enable/--disable makes it clear by itself. Would make it easier to keep things consistent too.
- -Steffan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBCAAGBQJUfKvaAAoJEJgCyj0AftKIKTkH/2wDn6M/dTibd6isx9vkXooL goGBk7ISMbpzZlVSQ8sOCqc14hVZ0DUhBlXnmtbPwZnTSfGm/Yol6HIWDxX33q15 rVS6W44BqE7OVeAEfs6JAXccBwNCY/kZfBnaIaX7lrH0PWbEJYeHpgvQg0HILh4Y eugv1fs7mjWuuEQRxCsy7GZtZoI/h6gxrkC5BFRezhwnL9zqibFI1GbHlsYOtfQ8 CkdKLq6vN9AWQnFfrmycm4lZvwvvo6TonEfUjOiL235U/d9PvRGGBCmCftsV+ho2 BinpGM2wXr9BXYQWdZT3SUpwaCFdCWVoJDSmtYq95CAILc1l8CZ/8iLlvHMpccY= =uk55
-----END PGP SIGNATURE-----