Skip to contentSkip to conversation

package/bdwgc: only enable on supported architectures

PATCH New Yann E. MORIN 2 participants 3 messages Dec 1, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/bdwgc: only enable on supported architectures

bdwgc has support for a sub-set of the architectures we support.

Since there is roughly a 50-50 split of our architectures that have support in bdwgc vs. those that do not, use a positive dependency logic, rather than a negative one.

The list was constructed by visual inspection of the source code of bdwgc, but the header doing the check is, to say it politely, a bit difficult to read...

So, some working archotectures may be missing. Users needing it may investigate if their architectures are indeed supported.

Fixes;
    http://autobuild.buildroot.net/results/529/529b0b6dd47744c13f56e59a4c669a3f5d56530d/
---
 package/bdwgc/Config.in | 7 +++++++
 package/bdwgc/bdwgc.mk  | 2 ++
 package/guile/Config.in | 1 +
 3 files changed, 10 insertions(+)
package/bdwgc/Config.in +7 -0
index 9aa7c7d..277b6e4 100644
@@ -1,5 +1,12 @@
+config BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
+	default y
+	depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 \
+		|| BR2_mips || BR2_MIPSEL || BR2_powerpc || BR2_sh \
+		|| BR2_sparc || BR2_x86_64
+
 config BR2_PACKAGE_BDWGC
 	bool "bdwgc"
+	depends on BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS
 	select BR2_PACKAGE_LIBATOMIC_OPS
 	help
package/bdwgc/bdwgc.mk +2 -0
index 3e6de1a..b408947 100644
@@ -4,6 +4,8 @@
 #
 ################################################################################
 
+# When bumping the version number, check if the list of supported architectures
+# is still valid; see Config.log.
 BDWGC_VERSION = 7.2f
 BDWGC_SOURCE = gc-$(BDWGC_VERSION).tar.gz
 BDWGC_SITE = http://www.hboehm.info/gc/gc_source
package/guile/Config.in +1 -0
index 009dbdf..8f86e9f 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_GUILE
 	bool "guile"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_PACKAGE_BDWGC_ARCH_SUPPORTS # bdwgc
 	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS # bdwgc
 	depends on BR2_USE_WCHAR # libunistring
 	select BR2_PACKAGE_LIBUNISTRING
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/bdwgc: only enable on supported architectures

Hi Yann,

package/bdwgc/Config.in line 4

Quoted 9 lines · Yann E. MORIN
package/bdwgc/Config.in +4 -0
index 9aa7c7d..277b6e4 100644
@@ -1,5 +1,12 @@
+config BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
+	default y
+	depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 \
+		|| BR2_mips || BR2_MIPSEL || BR2_powerpc || BR2_sh \

s/BR2_MIPSEL/BR2_mipsel/

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/bdwgc: only enable on supported architectures

Baruch, All,

On 2014-12-01 20:13 +0200, Baruch Siach spake thusly:

Quoted 12 lines · Yann E. MORIN

package/bdwgc/Config.in line 4

Quoted 9 lines
package/bdwgc/Config.in +4 -0
index 9aa7c7d..277b6e4 100644
@@ -1,5 +1,12 @@
+config BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
+	default y
+	depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 \
+		|| BR2_mips || BR2_MIPSEL || BR2_powerpc || BR2_sh \

s/BR2_MIPSEL/BR2_mipsel/

Damned, I forgot to lowercase that one...

How easy it is to read just what one expects, not what is really written... Cognitive bias? :-]

Thanks.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'