Skip to contentSkip to conversation

ifplugd: remove spurious newline excape

PATCH New Baruch Siach 2 participants 3 messages Dec 2, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ifplugd: remove spurious newline excape

Commit 5ad5d55924bcc (ifplugd: install configuration files unconditionally) removed the conditional configuration file install, but left an redundant newline escape, causing the following error:

package/ifplugd/ifplugd.mk:23: *** missing 'endef', unterminated 'define'. Stop.

Fix this.

Cc Thomas Petazzoni <[email protected]>
---
 package/ifplugd/ifplugd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ifplugd/ifplugd.mk +1 -1
index 03ed8cdf33a2..6b6141e7b8b3 100644
@@ -24,7 +24,7 @@ define IFPLUGD_INSTALL_FIXUP
 	$(INSTALL) -D -m 0644 $(@D)/conf/ifplugd.conf $(TARGET_DIR)/etc/ifplugd/ifplugd.conf; \
 	$(SED) 's^\(ARGS=.*\)w^\1^' $(TARGET_DIR)/etc/ifplugd/ifplugd.conf; \
 	$(INSTALL) -D -m 0755 $(@D)/conf/ifplugd.action \
-		$(TARGET_DIR)/etc/ifplugd/ifplugd.action ; \
+		$(TARGET_DIR)/etc/ifplugd/ifplugd.action
 endef
 
 IFPLUGD_POST_INSTALL_TARGET_HOOKS += IFPLUGD_INSTALL_FIXUP
Signature · 1 line
2.1.3
#1 lore raw

PATCH 1/1 ifplugd: remove spurious newline excape

Hi Buildroot list,

Quoted 7 lines · Baruch Siach

Commit 5ad5d55924bcc (ifplugd: install configuration files unconditionally) removed the conditional configuration file install, but left an redundant newline escape, causing the following error:

package/ifplugd/ifplugd.mk:23: *** missing 'endef', unterminated 'define'. Stop.

Fix this.

In subject: s/excape/escape/

baruch

Quoted 19 lines
Cc Thomas Petazzoni <[email protected]>
---
 package/ifplugd/ifplugd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ifplugd/ifplugd.mk +1 -1
index 03ed8cdf33a2..6b6141e7b8b3 100644
@@ -24,7 +24,7 @@ define IFPLUGD_INSTALL_FIXUP
 	$(INSTALL) -D -m 0644 $(@D)/conf/ifplugd.conf $(TARGET_DIR)/etc/ifplugd/ifplugd.conf; \
 	$(SED) 's^\(ARGS=.*\)w^\1^' $(TARGET_DIR)/etc/ifplugd/ifplugd.conf; \
 	$(INSTALL) -D -m 0755 $(@D)/conf/ifplugd.action \
-		$(TARGET_DIR)/etc/ifplugd/ifplugd.action ; \
+		$(TARGET_DIR)/etc/ifplugd/ifplugd.action
 endef
 
 IFPLUGD_POST_INSTALL_TARGET_HOOKS += IFPLUGD_INSTALL_FIXUP
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 ifplugd: remove spurious newline excape

In reply to Baruch Siach
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Commit 5ad5d55924bcc (ifplugd: install configuration files unconditionally) removed the conditional configuration file install, but left an redundant newline escape, causing the following error:

Quoted 6 lines

package/ifplugd/ifplugd.mk:23: *** missing 'endef', unterminated 'define'. Stop.

Fix this.

Cc Thomas Petazzoni <[email protected]>

Committed, thanks - And sorry.

Signature · 1 line
Bye, Peter Korsgaard