batman-adv: packet.h, add some missing includes
Hi,
please explain how this file can now be used unmodified in userspace (batctl) and kernel. If it cannot be done without modifying the file then please provide patches to modify the daily checks which make sure that the files in both repos are the same. I think the batman-adv developers can give you the original scripts.
Kind regards,
Sven
Quoted 7 lines · Sven Eckelmann
Hi,
please explain how this file can now be used unmodified in userspace (batctl) and kernel. If it cannot be done without modifying the file then please provide patches to modify the daily checks which make sure that the files in both repos are the same. I think the batman-adv developers can give you the original scripts.
I wasn't aware that this file is also used in batctl. Why is it needed there?
Probably I should have a look into the batctl sources.
Thanks,
Markus
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 9 lines · On Tuesday 02 December 2014 14:57:03 Markus Pargmann wrote:
Quoted 7 lines · Sven Eckelmann
Hi,
please explain how this file can now be used unmodified in userspace (batctl) and kernel. If it cannot be done without modifying the file then please provide patches to modify the daily checks which make sure that the files in both repos are the same. I think the batman-adv developers can give you the original scripts.
Quoted 3 lines
I wasn't aware that this file is also used in batctl. Why is it needed there?
Probably I should have a look into the batctl sources.
It is used for things like the tcpdump, ping and traceroute. In the past (svn times) it was just a links from batctl to batman-adv. But after the switch to git it was decided that both should be kept in sync manually but checked automatically.
I would like to give you the mini-check script but I don't have it. And I don't have access to the servers anymore. But it is basically checkout of master, maint and next of batctl+batman-adv and some calls to cmp (or diff?) to check if both files are the same. A mail is sent [1] to a mailing list. Someone has to merge the missing changes manually.
Btw. thanks for taking your time to cleanup things.
Kind regards,
Sven
[1] https://lists.open-mesh.org/pipermail/linux-merge/2014-March/001736.html
Quoted 19 lines · Sven Eckelmann
Quoted 9 lines · On Tuesday 02 December 2014 14:57:03 Markus Pargmann wrote:
Quoted 7 lines · Sven Eckelmann
Hi,
please explain how this file can now be used unmodified in userspace (batctl) and kernel. If it cannot be done without modifying the file then please provide patches to modify the daily checks which make sure that the files in both repos are the same. I think the batman-adv developers can give you the original scripts.
Quoted 3 lines
I wasn't aware that this file is also used in batctl. Why is it needed there?
Probably I should have a look into the batctl sources.It is used for things like the tcpdump, ping and traceroute. In the past (svn times) it was just a links from batctl to batman-adv. But after the switch to git it was decided that both should be kept in sync manually but checked automatically.
Quoted 5 lines
I would like to give you the mini-check script but I don't have it. And I don't have access to the servers anymore. But it is basically checkout of master, maint and next of batctl+batman-adv and some calls to cmp (or diff?) to check if both files are the same. A mail is sent [1] to a mailing list. Someone has to merge the missing changes manually.
Thanks for the clarification. I will have a look at compile issues for batctl. Until now I only worked with the batman tree imported into my linux tree so all my kernel tools are still working.
Best regards,
Markus
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 7 lines · Sven Eckelmann
Hi,
please explain how this file can now be used unmodified in userspace (batctl) and kernel. If it cannot be done without modifying the file then please provide patches to modify the daily checks which make sure that the files in both repos are the same. I think the batman-adv developers can give you the original scripts.
I added an ifdef __KERNEL__ around the includes which should work for the userspace.
Regards,
Markus
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |