trivial compile warning fixes for ipvsadm

Some trivial compile warning fixes from Daniel Borkmann to the ipvsadm tool.

I'll apply these to the git repo[1] if nobody objects.

[1] git://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git

---

Daniel Borkmann (2):
ipvsadm: fix compile warning in print_largenum
ipvsadm: fix compile warning in modprobe_ipvs

 ipvsadm.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer

From: Daniel Borkmann <[email protected]>

ipvsadm.c: In function ‘print_largenum’:
ipvsadm.c:1445:3: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 2 has type ‘size_t’ [-Wformat=]
printf("%*llu", len <= 8 ? 9 : len + 1, i);
^

Fix by reducing the scope and use int for len instead.

---
 ipvsadm.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

index 1190839..8931412 100644
@@ -1437,15 +1437,15 @@ static inline char *fwd_switch(unsigned flags)
 
 static void print_largenum(unsigned long long i, unsigned int format)
 {
-	char mytmp[32];
-	size_t len;

From: Daniel Borkmann <[email protected]>

ipvsadm.c: In function ‘modprobe_ipvs’:
ipvsadm.c:1249:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]

  int rc;
      ^

Address this by also checking if waitpid(2) returned successfully before we check actual status information.

---
 ipvsadm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index 8931412..72ddc8a 100644
@@ -1255,7 +1255,7 @@ static int modprobe_ipvs(void)
 
 	rc = waitpid(child, &status, 0);
 
-	if (!WIFEXITED(status) || WEXITSTATUS(status)) {
+	if (rc == -1 || !WIFEXITED(status) || WEXITSTATUS(status)) {
 		return 1;
 	}
 

Hello,

Both patches look ok to me too,

We should not see ECHILD when SIGCHLD=SIG_DFL, right?
Only for SIG_IGN.

Regards

--
Julian Anastasov <[email protected]>

FYI: done, pushed to git tree (with Simon and Julian's ACKs):
[1] git://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git

Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer