arm64: Provide a namespace to NCAPS
PATCH 1/1 arm64: Provide a namespace to NCAPS
From: Fabio Estevam <[email protected]>
Building arm64.allmodconfig leads to the following warning:
usb/gadget/function/f_ncm.c:203:0: warning: "NCAPS" redefined
#define NCAPS (USB_CDC_NCM_NCAP_ETH_FILTER | USB_CDC_NCM_NCAP_CRC_MODE) ^
In file included from /home/build/work/batch/arch/arm64/include/asm/io.h:32:0,
from /home/build/work/batch/include/linux/clocksource.h:19,
from /home/build/work/batch/include/clocksource/arm_arch_timer.h:19,
from /home/build/work/batch/arch/arm64/include/asm/arch_timer.h:27,
from /home/build/work/batch/arch/arm64/include/asm/timex.h:19,
from /home/build/work/batch/include/linux/timex.h:65,
from /home/build/work/batch/include/linux/sched.h:19,
from /home/build/work/batch/arch/arm64/include/asm/compat.h:25,
from /home/build/work/batch/arch/arm64/include/asm/stat.h:23,
from /home/build/work/batch/include/linux/stat.h:5,
from /home/build/work/batch/include/linux/module.h:10,
from /home/build/work/batch/drivers/usb/gadget/function/f_ncm.c:19:arch/arm64/include/asm/cpufeature.h:27:0: note: this is the location of the previous definition
#define NCAPS 2
So add a ARM64 prefix to avoid such problem.
--- arch/arm64/include/asm/cpufeature.h | 10 +++++----- arch/arm64/kernel/setup.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/include/asm/cpufeature.h +5 -5
@@ -24,11 +24,11 @@#define ARM64_WORKAROUND_CLEAN_CACHE 0#define ARM64_WORKAROUND_DEVICE_LOAD_ACQUIRE 1 -#define NCAPS 2 +#define ARM64_NCAPS 2#ifndef __ASSEMBLY__ -extern DECLARE_BITMAP(cpu_hwcaps, NCAPS); +extern DECLARE_BITMAP(cpu_hwcaps, ARM64_NCAPS);static inline bool cpu_have_feature (unsigned int num) {
@@ -37,16 +37,16 @@ static inline bool cpu_have_feature(unsigned int num)static inline bool cpus_have_cap (unsigned int num) { -if (num >=NCAPS ) +if (num >=ARM64_NCAPS )return false;return test_bit (num, cpu_hwcaps); }static inline void cpus_set_cap (unsigned int num) { -if (num >=NCAPS ) +if (num >=ARM64_NCAPS )pr_warn ("Attempt to set an illegal CPU capability (%d >= %d)\n" , - num,NCAPS ); + num,ARM64_NCAPS );else __set_bit (num, cpu_hwcaps); }
arch/arm64/kernel/setup.c +1 -1
@@ -80,7 +80,7 @@ unsigned int compat_elf_hwcap __read_mostly = COMPAT_ELF_HWCAP_DEFAULT;unsigned int compat_elf_hwcap2__read_mostly ;#endif -DECLARE_BITMAP (cpu_hwcaps,NCAPS ); +DECLARE_BITMAP (cpu_hwcaps,ARM64_NCAPS );static const char *cpu_name;phys_addr_t __fdt_pointer__initdata ;
Signature · 1 line
1.9.1
Will Deacon
AppliedPATCH 1/1 arm64: Provide a namespace to NCAPS
Quoted 19 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Building arm64.allmodconfig leads to the following warning:
usb/gadget/function/f_ncm.c:203:0: warning: "NCAPS" redefined
#define NCAPS (USB_CDC_NCM_NCAP_ETH_FILTER|USB_CDC_NCM_NCAP_CRC_MODE) ^
In file included from/home/build/work/batch/arch/arm64/include/asm/io.h:32:0,from /home/build/work/batch/include/linux/clocksource.h:19, from /home/build/work/batch/include/clocksource/arm_arch_timer.h:19, from /home/build/work/batch/arch/arm64/include/asm/arch_timer.h:27, from /home/build/work/batch/arch/arm64/include/asm/timex.h:19, from /home/build/work/batch/include/linux/timex.h:65, from /home/build/work/batch/include/linux/sched.h:19, from /home/build/work/batch/arch/arm64/include/asm/compat.h:25, from /home/build/work/batch/arch/arm64/include/asm/stat.h:23, from /home/build/work/batch/include/linux/stat.h:5, from /home/build/work/batch/include/linux/module.h:10, from /home/build/work/batch/drivers/usb/gadget/function/f_ncm.c:19:
Quoted 4 lines
arch/arm64/include/asm/cpufeature.h:27:0: note: this is the location of the previous definition
#define NCAPS 2So add a ARM64 prefix to avoid such problem.
Thanks, applied.
Will