arm: omap2: rx51-peripherals: fix build warning

PATCH New Felipe Balbi 6 participants 10 messages Nov 26, 2014 – Dec 4, 2014

Subsystems (4)

Arm (32-bit) Media (V4L/DVB) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

Felipe Balbi

author

2014-11-26 20:27 UTC #0 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.

This patches fixes that warning:

arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {

Cc Sebastian Reichel <[email protected]>

Cc Tony Lindgren <[email protected]>

Cc Hans Verkuil <[email protected]>

Cc Mauro Carvalho Chehab <[email protected]>

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/mach-omap2/board-rx51-peripherals.c +2 -0

index d18a5cf..bda20c5 100644
@@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
 	.gpio_reset = 60,
 };
 
+#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
 static struct si4713_platform_data rx51_si4713_platform_data = {
 	.is_platform_device = true
 };
+#endif
 
 static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
 #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)

Signature · 1 line

2.1.0.GIT

Sebastian Reichel

2014-11-26 21:56 UTC #1 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

Quoted 12 lines · Felipe Balbi

commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {

Quoted 5 lines

Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>

Acked-by Sebastian Reichel <[email protected]>

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141126/154769c8/attachment-0001.sig>

Hans Verkuil

2014-11-27 07:41 UTC #2 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

In reply to Felipe Balbi

Quoted 12 lines · Felipe Balbi

commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {

Quoted 5 lines

Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>

Acked-by Hans Verkuil <[email protected]>

Quoted 21 lines

---
 arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/mach-omap2/board-rx51-peripherals.c +2 -0

index d18a5cf..bda20c5 100644
@@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
 	.gpio_reset = 60,
 };
 
+#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
 static struct si4713_platform_data rx51_si4713_platform_data = {
 	.is_platform_device = true
 };
+#endif
 
 static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
 #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)

Felipe Balbi

author

2014-12-04 15:24 UTC #3 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

In reply to Felipe Balbi

Quoted 12 lines · Felipe Balbi

commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {

Quoted 5 lines

Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>

a gentle reminder on this one.

Quoted 23 lines

---
 arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/mach-omap2/board-rx51-peripherals.c +2 -0

index d18a5cf..bda20c5 100644
@@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
 	.gpio_reset = 60,
 };
 
+#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
 static struct si4713_platform_data rx51_si4713_platform_data = {
 	.is_platform_device = true
 };
+#endif
 
 static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
 #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)

Signature · 1 line

2.1.0.GIT

Signature · 8 lines

balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/2085bc1e/attachment.sig>

Arnd Bergmann

2014-12-04 15:41 UTC #4 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

Quoted 13 lines · On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:

Quoted 12 lines · Felipe Balbi
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {

Quoted 8 lines

Quoted 5 lines
Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>
a gentle reminder on this one.

Let me add my

Acked-by Arnd Bergmann <[email protected]>

You didn't say who you expect to pick up the patch. I assume Mauro should take it because he took the patch that caused the problem, but he might not be aware that he should look at this now.

Arnd

Felipe Balbi

author

2014-12-04 15:48 UTC #5 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

Hi,

Quoted 20 lines · Arnd Bergmann

Quoted 19 lines · On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
Quoted 17 lines · Felipe Balbi
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {
Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>

Quoted 8 lines

Quoted 2 lines
a gentle reminder on this one.
Let me add my
Acked-by Arnd Bergmann <[email protected]>
You didn't say who you expect to pick up the patch. I assume Mauro

patch author now decides who takes the patch ? That's new :-)

Quoted 2 lines

should take it because he took the patch that caused the problem, but he might not be aware that he should look at this now.

He is in Cc, let's ask him :-)

Signature · 8 lines

balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/e8abb4a4/attachment-0001.sig>

Tony Lindgren

maintainer

2014-12-04 16:39 UTC #6 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

Quoted 30 lines · Felipe Balbi

Hi,
Quoted 27 lines · Arnd Bergmann
Quoted 13 lines · On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
Quoted 12 lines · Felipe Balbi
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {
Quoted 8 lines
Quoted 5 lines
Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>
a gentle reminder on this one.
Let me add my
Acked-by Arnd Bergmann <[email protected]>

Quoted 8 lines

Quoted 1 line
You didn't say who you expect to pick up the patch. I assume Mauro
patch author now decides who takes the patch ? That's new :-)
Quoted 2 lines
should take it because he took the patch that caused the problem, but he might not be aware that he should look at this now.
He is in Cc, let's ask him :-)

Best that this one goes in along with the other si4713 patches to avoid dependencies between trees:

Acked-by Tony Lindgren <[email protected]>

Mauro Carvalho Chehab

2014-12-04 17:00 UTC #7 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

Em Thu, 04 Dec 2014 08:39:31 -0800
Tony Lindgren <[email protected]> escreveu:

Quoted 27 lines · Felipe Balbi

Quoted 26 lines
Hi,
Quoted 23 lines · Arnd Bergmann
Quoted 21 lines · On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
Quoted 12 lines · Felipe Balbi
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {
Quoted 5 lines
Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>
a gentle reminder on this one.

Quoted 7 lines

Quoted 7 lines
Quoted 5 lines
Let me add my
Acked-by Arnd Bergmann <[email protected]>
You didn't say who you expect to pick up the patch. I assume Mauro
patch author now decides who takes the patch ? That's new :-)

Well, for patches that cross subsystem boundaries, like this one, the best is to give a hint about whom you expect to pick it.

In this specific case, as commit 68a3c04 is in my tree, the best is to merge the patch on it, as the patch may not even apply at Tony's tree.

Quoted 10 lines

Quoted 5 lines
Quoted 3 lines
should take it because he took the patch that caused the problem, but he might not be aware that he should look at this now.
He is in Cc, let's ask him :-)
Best that this one goes in along with the other si4713 patches to avoid dependencies between trees:
Acked-by Tony Lindgren <[email protected]>

Thanks! I'll merge it via my tree.

Regards,
Mauro

Felipe Balbi

author

2014-12-04 17:03 UTC #8 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

Hi,

Quoted 36 lines · Mauro Carvalho Chehab

Em Thu, 04 Dec 2014 08:39:31 -0800
Tony Lindgren <[email protected]> escreveu:
Quoted 33 lines · Felipe Balbi
Quoted 32 lines
Hi,
Quoted 28 lines · Arnd Bergmann
Quoted 13 lines · On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
Quoted 12 lines · Felipe Balbi
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {
Quoted 8 lines
Quoted 5 lines
Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>
a gentle reminder on this one.
Let me add my
Acked-by Arnd Bergmann <[email protected]>
You didn't say who you expect to pick up the patch. I assume Mauro

Quoted 8 lines

Quoted 1 line
Quoted 1 line
patch author now decides who takes the patch ? That's new :-)
Well, for patches that cross subsystem boundaries, like this one, the best is to give a hint about whom you expect to pick it.
In this specific case, as commit 68a3c04 is in my tree, the best is to merge the patch on it, as the patch may not even apply at Tony's tree.

pointing to the commit that caused the problem really isn't enough ? The commit short description (which is also on my commit log) clearly mentions "[media]".

Anyway, I'll do that next time.

Quoted 11 lines

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
should take it because he took the patch that caused the problem, but he might not be aware that he should look at this now.
He is in Cc, let's ask him :-)
Best that this one goes in along with the other si4713 patches to avoid dependencies between trees:
Acked-by Tony Lindgren <[email protected]>
Thanks! I'll merge it via my tree.

tks

Signature · 8 lines

balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/78c8be28/attachment.sig>

Mauro Carvalho Chehab

2014-12-04 17:12 UTC #9 lore raw

PATCH 1/1 arm: omap2: rx51-peripherals: fix build warning

Em Thu, 04 Dec 2014 11:03:53 -0600
Felipe Balbi <[email protected]> escreveu:

Quoted 48 lines

Hi,
Quoted 36 lines · Mauro Carvalho Chehab
Em Thu, 04 Dec 2014 08:39:31 -0800
Tony Lindgren <[email protected]> escreveu:
Quoted 33 lines · Felipe Balbi
Quoted 32 lines
Hi,
Quoted 28 lines · Arnd Bergmann
Quoted 13 lines · On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
Quoted 12 lines · Felipe Balbi
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update si4713 platform data) updated board-rx51-peripherals.c so that si4713 could be easily used on DT boot, but it ended up introducing a build warning whenever si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {
Quoted 8 lines
Quoted 5 lines
Cc Sebastian Reichel <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Hans Verkuil <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>
a gentle reminder on this one.
Let me add my
Acked-by Arnd Bergmann <[email protected]>
You didn't say who you expect to pick up the patch. I assume Mauro
Quoted 8 lines
Quoted 1 line
Quoted 1 line
patch author now decides who takes the patch ? That's new :-)
Well, for patches that cross subsystem boundaries, like this one, the best is to give a hint about whom you expect to pick it.
In this specific case, as commit 68a3c04 is in my tree, the best is to merge the patch on it, as the patch may not even apply at Tony's tree.

Quoted 5 lines

pointing to the commit that caused the problem really isn't enough ? The commit short description (which is also on my commit log) clearly mentions "[media]".
Anyway, I'll do that next time.

Ah, and please c/c linux-media ML next time, as I use patchwork there to track patches for the media tree.

Thanks,
Mauro.