Skip to contentSkip to conversation

hwmon: tmp401: add support for TI TMP435

PATCH Guenter Roeck 1 participant 1 message Dec 4, 2014

lore
Share & tools
lore
#0 lore raw
Quoted 39 lines · Bartosz Golaszewski

From: Patrick Titiano <[email protected]>

[Bartosz Golaszewski: prepared for submission, code review fixes]
---
 drivers/hwmon/tmp401.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/hwmon/tmp401.c +3 -1
index 7fa6e7d..ccd9938 100644
@@ -46,7 +46,7 @@
 /* Addresses to scan */
 static const unsigned short normal_i2c[] = { 0x4c, 0x4d, 0x4e, I2C_CLIENT_END };
 
-enum chips { tmp401, tmp411, tmp431, tmp432 };
+enum chips { tmp401, tmp411, tmp431, tmp432, tmp435 };
 
 /*
  * The TMP401 registers, note some registers have different addresses for
@@ -136,6 +136,7 @@ static const u8 TMP432_STATUS_REG[] = {
 #define TMP411C_DEVICE_ID			0x10
 #define TMP431_DEVICE_ID			0x31
 #define TMP432_DEVICE_ID			0x32
+#define TMP435_DEVICE_ID			0x35
 
 /*
  * Driver data (common to all clients)
@@ -146,6 +147,7 @@ static const struct i2c_device_id tmp401_id[] = {
 	{ "tmp411", tmp411 },
 	{ "tmp431", tmp431 },
 	{ "tmp432", tmp432 },
+	{ "tmp435", tmp435 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, tmp401_id);

drivers/hwmon/tmp401.c static int tmp401_detect(struct i2c_client *client, · line 691

Quoted 6 lines
drivers/hwmon/tmp401.c +3 -0
@@ -684,6 +686,11 @@ static int tmp401_detect(struct i2c_client *client,
 			return -ENODEV;
 		kind = tmp432;
 		break;
+	case TMP435_DEVICE_ID:
+		if (client->addr != 0x4c)
+			return -ENODEV;

On second thought, is this really correct ?

I had another look into the datasheet. It seems to me that the chip may support up to 9 different addresses, though that is a bit vague since the datasheet first claims that the address would be 0x4c, only to go on and list the 9 addresses (0x48 to 0x4f as well as 0x37) in the next paragraph.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors