watchdog: Fixed missing blank line warning
PATCH 1/1 watchdog: Fixed missing blank line warning
Fixed the checkpatch warning:
Missing a blank line after declarations
--- drivers/watchdog/mixcomwd.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/mixcomwd.c +1 -0
@@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,for (i =0 ; i != len; i++) {char c; +if (get_user (c, data + i))return -EFAULT ;if (c =='V' )
Signature · 1 line
1.7.9.5
Athira,
Quoted 28 lines · Athira Lekshmi
Fixed the checkpatch warning:
Missing a blank line after declarationsSigned-off-by Athira Lekshmi <[email protected]>--- drivers/watchdog/mixcomwd.c | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/mixcomwd.c +1
-0@@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,for (i =0 ; i != len; i++) {char c; +if (get_user (c, data + i))return -EFAULT ;if (c =='V' )Signature · 7 lines
1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
It is helpful to add a version number when patches are re-submitted to avoid them being confused for a new patch. git-format-patch has the --reroll-count option which makes this easy to do.
Signature · 1 line
- Jeremiah Mahler
Hello
Should I resubmit the above patch again including the version number, or can I start doing so from the next time onwards ?
Thank You
Athira Lekshmi
Quoted 38 lines · Jeremiah Mahler
Athira,
Quoted 23 lines · Athira Lekshmi
Fixed the checkpatch warning:
Missing a blank line after declarationsSigned-off-by Athira Lekshmi <[email protected]>--- drivers/watchdog/mixcomwd.c | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/mixcomwd.c +1
-1@@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,for (i =0 ; i != len; i++) {char c; +if (get_user (c, data + i))return -EFAULT ;if (c =='V' ) --1.7.9.5
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/It is helpful to add a version number when patches are re-submitted to avoid them being confused for a new patch. git-format-patch has the --reroll-count option which makes this easy to do.
--
- Jeremiah Mahler
Quoted 5 lines · Athira Lekshmi C V
Hello
Should I resubmit the above patch again including the version number, or can I start doing so from the next time onwards ?
Not a big deal this time but definitely do it in the future.
Another tip: try to avoid posting, it can make the conversation confusing [1].
[1]: https://lkml.org/lkml/2005/1/11/111
Quoted 42 lines
Thank You
Athira LekshmiQuoted 38 lines · Jeremiah Mahler
Athira,
Quoted 23 lines · Athira Lekshmi
Fixed the checkpatch warning:
Missing a blank line after declarationsSigned-off-by Athira Lekshmi <[email protected]>--- drivers/watchdog/mixcomwd.c | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/mixcomwd.c +1
-1@@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,for (i =0 ; i != len; i++) {char c; +if (get_user (c, data + i))return -EFAULT ;if (c =='V' ) --1.7.9.5
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/It is helpful to add a version number when patches are re-submitted to avoid them being confused for a new patch. git-format-patch has the --reroll-count option which makes this easy to do.
--
- Jeremiah Mahler
Signature · 1 line
- Jeremiah Mahler
Athira,
Quoted 9 lines · Jeremiah Mahler
Quoted 5 lines · Athira Lekshmi C V
Hello
Should I resubmit the above patch again including the version number, or can I start doing so from the next time onwards ?
Not a big deal this time but definitely do it in the future.
Another tip: try to avoid posting, it can make the conversation
^^^^^^^^^^^^^
Quoted 2 lines
confusing [1].
"avoid top posting"
Posting is great, don't avoid that :-)
Quoted 8 lines
[1]: https://lkml.org/lkml/2005/1/11/111
Quoted 6 lines
Thank You
Athira LekshmiQuoted 2 lines · Jeremiah Mahler
Athira,
[...]
Quoted 3 lines
Signature · 2 lines
-- - Jeremiah Mahler
Signature · 1 line
- Jeremiah Mahler