Skip to contentSkip to conversation

ARM: OMAP5: DRA7xx: Fix misleading comments in mux_data.h

PATCH In review Lubomir Popov 2 participants 3 messages Nov 10, 2014 – Dec 5, 2014

lore
Share & tools
lore

Lubomir Popov

author
#0 lore raw

PATCH 1/1 ARM: OMAP5: DRA7xx: Fix misleading comments in mux_data.h

The comments on the QSPI pad assignments erronously swapped the qspi1_d0 and qspi1_d1 functionality and could cause confusion. QSPI1_D[0] is in fact muxed on pad U1 (gpmc_a16), and QSPI1_D[1] - on pad P3 (gpmc_a17). Fixing comments.

Signed-off-by Lubomir Popov <[email protected]>
---
 board/ti/dra7xx/mux_data.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/ti/dra7xx/mux_data.h +2 -2
index 7276014..4824077 100644
@@ -130,8 +130,8 @@ const struct pad_conf_entry core_padconf_array_essential[] = {
 	{GPMC_A13, (IEN | PDIS | M1)},  /* QSPI1_RTCLK */
 	{GPMC_A14, (IEN | PDIS | M1)},  /* QSPI1_D[3] */
 	{GPMC_A15, (IEN | PDIS | M1)},  /* QSPI1_D[2] */
-	{GPMC_A16, (IEN | PDIS | M1)},  /* QSPI1_D[1] */
-	{GPMC_A17, (IEN | PDIS | M1)},  /* QSPI1_D[0] */
+	{GPMC_A16, (IEN | PDIS | M1)},  /* QSPI1_D[0] */
+	{GPMC_A17, (IEN | PDIS | M1)},  /* QSPI1_D[1] */
 	{GPMC_A18, (M1)},  /* QSPI1_SCLK */
 	{GPMC_A3, (IEN | PDIS | M1)},   /* QSPI1_CS2 */
 	{GPMC_A4, (IEN | PDIS | M1)},   /* QSPI1_CS3 */
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: OMAP5: DRA7xx: Fix misleading comments in mux_data.h

Quoted 6 lines · Lubomir Popov

The comments on the QSPI pad assignments erronously swapped the qspi1_d0 and qspi1_d1 functionality and could cause confusion. QSPI1_D[0] is in fact muxed on pad U1 (gpmc_a16), and QSPI1_D[1] - on pad P3 (gpmc_a17). Fixing comments.

Signed-off-by Lubomir Popov <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/ff151cb3/attachment.pgp>
#2 lore raw
In reply to Lubomir Popov
Quoted 7 lines · Lubomir Popov

The comments on the QSPI pad assignments erronously swapped the qspi1_d0 and qspi1_d1 functionality and could cause confusion. QSPI1_D[0] is in fact muxed on pad U1 (gpmc_a16), and QSPI1_D[1] - on pad P3 (gpmc_a17). Fixing comments.

Signed-off-by Lubomir Popov <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141205/7c871a8c/attachment.pgp>