Skip to contentSkip to conversation

exiv2: add patch to fix build error with some toolchains

PATCH New Nicolas Serafini 2 participants 3 messages Dec 4, 2014 – Dec 7, 2014

lore
Share & tools
lore

Nicolas Serafini

author
#0 lore raw

PATCH 1/1 exiv2: add patch to fix build error with some toolchains

This patch remove a header inclusion that is not required an can create build error with some toolchains.
The patch is pushed on the upstream for the next release.
http://dev.exiv2.org/issues/1007

Fixes:
http://autobuild.buildroot.net/results/09d/09d9b525eeee458247e10a7948070c00bbabb964/

Signed-off-by Nicolas Serafini <[email protected]>
---
 package/exiv2/exiv2-0001-remove-useless-header.patch | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 package/exiv2/exiv2-0001-remove-useless-header.patch
package/exiv2/exiv2-0001-remove-useless-header.patch new file +19 -0
new file mode 100644
index 0000000..96a3734
@@ -0,0 +1,19 @@
+version.cpp: remove useless header inclusion
+
+The inclusion of link.h header is not required and can create build
+error with some toolchains.
+The patch is pushed on the upstream for the next release.
+http://dev.exiv2.org/issues/1007
+
+Signed-off-by: Nicolas Serafini <[email protected]>
+
+--- exiv2-0.24.orig/src/version.cpp	2013-12-01 13:13:42.000000000 +0100
++++ exiv2-0.24/src/version.cpp	2014-12-04 09:30:39.667234130 +0100
+@@ -116,7 +116,6 @@ typedef string_v::iterator  string_i;
+ #elif defined(__linux__)
+ # include <unistd.h>
+ // http://syprog.blogspot.com/2011/12/listing-loaded-shared-objects-in-linux.html
+-# include "link.h"
+ # include <dlfcn.h>
+   struct something
+   {
Signature · 1 line
2.1.3
#1 lore raw

PATCH 1/1 exiv2: add patch to fix build error with some toolchains

Dear Nicolas Serafini,

Quoted 5 lines · Nicolas Serafini

This patch remove a header inclusion that is not required an can create build error with some toolchains.
The patch is pushed on the upstream for the next release.
http://dev.exiv2.org/issues/1007

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/09d/09d9b525eeee458247e10a7948070c00bbabb964/

Signed-off-by Nicolas Serafini <[email protected]>
---
 package/exiv2/exiv2-0001-remove-useless-header.patch | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 package/exiv2/exiv2-0001-remove-useless-header.patch
Tested-by Thomas Petazzoni <[email protected]>

I tested that it indeed fixes the Blackfin build failure mentioned in the commit log. The only minor detail is that the patch is not named correctly, it should be named 0001-remove-useless-header.patch, and not exiv2-0001-remove-useless-header.patch, but this can be fixed when applying Nicolas patch.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#2 lore raw

PATCH 1/1 exiv2: add patch to fix build error with some toolchains

In reply to Nicolas Serafini

Dear Nicolas Serafini,

Quoted 9 lines · Nicolas Serafini

This patch remove a header inclusion that is not required an can create build error with some toolchains.
The patch is pushed on the upstream for the next release.
http://dev.exiv2.org/issues/1007

Fixes:
http://autobuild.buildroot.net/results/09d/09d9b525eeee458247e10a7948070c00bbabb964/

Signed-off-by Nicolas Serafini <[email protected]>

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com