Skip to contentSkip to conversation

package/nginx: disallow AIO support on arc

PATCH New Samuel Martin 3 participants 6 messages Dec 6, 2014 – Dec 7, 2014

lore
Share & tools
lore

Samuel Martin

author
#0 lore raw

PATCH 1/2 package/nginx: disallow AIO support on arc

The nginx AIO support cannot build on arc, because it hardcodes the usage of SYS_eventfd(), while it should just use eventfd() from the C library.

Fixes:
http://autobuild.buildroot.org/results/f3e/f3e2c7a937517a5444f8c6cc0b02692af897b3e0/

Signed-off-by Samuel Martin <[email protected]>
---
 package/nginx/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/nginx/Config.in +2 -1
index c2a6af1..5b5c0b0 100644
@@ -17,9 +17,10 @@ if BR2_PACKAGE_NGINX
 config BR2_PACKAGE_NGINX_FILE_AIO
 	bool "file AIO support"
 	# Does not build, because nginx hardcodes using SYS_eventfd,
-	# but it's not available on AArch64, only eventfd() is.
+	# but it's not available on AArch64, nor arc only eventfd() is.
 	# See https://bugs.launchpad.net/linaro-aarch64/+bug/1160013
 	depends on !BR2_aarch64
+	depends on !BR2_arc
 
 config BR2_PACKAGE_NGINX_HTTP
 	bool "http server"
Signature · 1 line
2.1.3
author
#1 lore raw

PATCH 2/2 package/libnss: need dynamic library support

Fixes:
http://autobuild.buildroot.net/results/e01733c4b8c23f62e2081f0c4aadc16e22c4a2c4/

Signed-off-by Samuel Martin <[email protected]>
---
 package/libnss/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/libnss/Config.in +4 -2
index 690f928..d57c7a2 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBNSS
 	depends on BR2_LARGEFILE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
 	depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
+	depends on !BR2_PREFER_STATIC_LIB
 	help
 	  Network Security Services (NSS) is a set of libraries designed
 	  to support development of security-enabled client and server

@@ -15,6 +16,7 @@ config BR2_PACKAGE_LIBNSS
 
 	  http://www.mozilla.org/projects/security/pki/nss/
 
-comment "libnss needs a toolchain w/ largefile, threads"
+comment "libnss needs a toolchain w/ largefile, threads, dynamic librairy"
 	depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
-	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS \
+		BR2_PREFER_STATIC_LIB
Signature · 1 line
2.1.3
#2 lore raw

PATCH 2/2 package/libnss: need dynamic library support

Dear Samuel Martin,

Quoted 13 lines · Samuel Martin

Fixes:
http://autobuild.buildroot.net/results/e01733c4b8c23f62e2081f0c4aadc16e22c4a2c4/

Signed-off-by Samuel Martin <[email protected]>
---
 package/libnss/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/libnss/Config.in +0 -0
index 690f928..d57c7a2 100644

package/libnss/Config.in config BR2_PACKAGE_LIBNSS · line 9

Quoted 4 lines
package/libnss/Config.in +1 -0
@@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBNSS
 	depends on BR2_LARGEFILE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
 	depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
+	depends on !BR2_PREFER_STATIC_LIB

What about the reverse dependencies, such as ecryptfs-utils?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#3 lore raw

PATCH 2/2 package/libnss: need dynamic library support

Quoted 11 lines · Thomas Petazzoni

Dear Samuel Martin,

Quoted 8 lines · Samuel Martin

Fixes:
http://autobuild.buildroot.net/results/e01733c4b8c23f62e2081f0c4aadc16e22c4a2c4/

Signed-off-by Samuel Martin <[email protected]>
---
 package/libnss/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Quoted 11 lines

package/libnss/Config.in config BR2_PACKAGE_LIBNSS · line 9

Quoted 9 lines
package/libnss/Config.in +1 -0
index 690f928..d57c7a2 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBNSS
      depends on BR2_LARGEFILE
      depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
      depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
+     depends on !BR2_PREFER_STATIC_LIB

What about the reverse dependencies, such as ecryptfs-utils?

oops! I missed that. I'll respin the patch

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 1 line
Samuel
#4 lore raw

PATCH 1/2 package/nginx: disallow AIO support on arc

In reply to Samuel Martin

Samuel, All,

On 2014-12-06 14:15 +0100, Samuel Martin spake thusly:

Quoted 17 lines

The nginx AIO support cannot build on arc, because it hardcodes the usage of SYS_eventfd(), while it should just use eventfd() from the C library.

Fixes:
http://autobuild.buildroot.org/results/f3e/f3e2c7a937517a5444f8c6cc0b02692af897b3e0/

Signed-off-by Samuel Martin <[email protected]>
---
 package/nginx/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/nginx/Config.in +0 -0
index c2a6af1..5b5c0b0 100644

package/nginx/Config.in if BR2_PACKAGE_NGINX · line 20

Quoted 5 lines
package/nginx/Config.in +1 -1
@@ -17,9 +17,10 @@ if BR2_PACKAGE_NGINX
 config BR2_PACKAGE_NGINX_FILE_AIO
 	bool "file AIO support"
 	# Does not build, because nginx hardcodes using SYS_eventfd,
-	# but it's not available on AArch64, only eventfd() is.
+	# but it's not available on AArch64, nor arc only eventfd() is.

but it's available on neither AArch64 nor arc, where only eventfd() is.

Otherwise, looks good:

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 13 lines
package/nginx/Config.in +1 -0
 	# See https://bugs.launchpad.net/linaro-aarch64/+bug/1160013
 	depends on !BR2_aarch64
+	depends on !BR2_arc
 
 config BR2_PACKAGE_NGINX_HTTP
 	bool "http server"
Signature · 6 lines
2.1.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#5 lore raw

PATCH 1/2 package/nginx: disallow AIO support on arc

In reply to Samuel Martin

Dear Samuel Martin,

Quoted 11 lines · Samuel Martin

The nginx AIO support cannot build on arc, because it hardcodes the usage of SYS_eventfd(), while it should just use eventfd() from the C library.

Fixes:
http://autobuild.buildroot.org/results/f3e/f3e2c7a937517a5444f8c6cc0b02692af897b3e0/

Signed-off-by Samuel Martin <[email protected]>
---
 package/nginx/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, applied after slightly tweaking the comment as suggested by Yann.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com