mm/memcontrol.c: fix the placement of 'MAX_NUMNODES > 1' if block
Subsystems (2)
PATCH 1/1 mm/memcontrol.c: fix the placement of 'MAX_NUMNODES > 1' if block
From: Fabio Estevam <[email protected]>
When building ARM allmodconfig we get the following build warning:
mm/memcontrol.c:1629:13: warning: 'test_mem_cgroup_node_reclaimable' defined but not used [-Wunused-function]
As test_mem_cgroup_node_reclaimable() is only used inside the
'#if MAX_NUMNODES > 1' block, we should also place its definition there as well.
--- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memcontrol.c +1 -1
@@ -1616,6 +1616,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask, NULL, "Memory cgroup out of memory"); } +#if MAX_NUMNODES >1 /** * test_mem_cgroup_node_reclaimable * @memcg: the target memcg
@@ -1638,7 +1639,6 @@ static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,return false; } -#if MAX_NUMNODES >1 /* * Always updating the nodemask is not very good - even if we have an empty
Signature · 7 lines
1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Hi,
this has been fixed last week already
http://marc.info/?l=linux-mm&m=141751847710864&w=2
Thanks!
Quoted 38 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
When building ARM allmodconfig we get the following build warning:
mm/memcontrol.c:1629:13: warning: 'test_mem_cgroup_node_reclaimable' defined but not used [-Wunused-function]As
test_mem_cgroup_node_reclaimable()is only used inside the
'#ifMAX_NUMNODES> 1' block, we should also place its definition there as well.Reported-by Olof's autobuilder <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/memcontrol.c +1
-1@@ -1616,6 +1616,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask, NULL, "Memory cgroup out of memory"); } +#if MAX_NUMNODES >1 /** * test_mem_cgroup_node_reclaimable * @memcg: the target memcg @@ -1638,7 +1639,6 @@ static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,return false; } -#if MAX_NUMNODES >1 /* * Always updating the nodemask is not very good - even if we have an empty Signature · 1 line
1.9.1
Signature · 8 lines
Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>