Skip to contentSkip to conversation

libdvbv5: dvb_fe_retrieve_quality not working correctly (dvb-fe.c)

BUG HeavyJoost 1 participant 1 message Dec 7, 2014 Media (V4L/DVB)

lore
Share & tools
lore

HeavyJoost

author
#0 lore raw

I was trying out this library and I found two things that probably need fixing in dvb_fe_retrieve_quality. Without this it only returns DVB_QUAL_UNKNOWN for my setup.

Issue 1 on line 1205:

ber = dvb_fe_retrieve_per(&parms->p, layer);

As far as I can tell this should use dvb_fe_retrieve_ber (so _ber instead of _per) with the appropriate arguments.

Issue 2 on line 1218:

dvbv_fe_cnr_to_quality(parms, cnr);

This probably needs to be changed to the following because it doesn't have any effect otherwise ;)

qual = dvbv_fe_cnr_to_quality(parms, cnr);