Skip to contentSkip to conversation

qtuio: add error handling to for loop

PATCH Superseded Thomas Petazzoni 2 participants 3 messages Dec 3, 2014 – Dec 7, 2014

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH v2 1/1 qtuio: add error handling to for loop

Also remove unneeded sub-shell usage in the build and installation steps. It is kept for the configure step as it is actually useful, and works fine because "|| exit 1" is outside the sub-shell.

Signed-off-by Thomas Petazzoni <[email protected]>

---
Changes v1 -> v2:
* Remove unneeded sub-shell usage, noticed by Yann E. Morin.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/qtuio/qtuio.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/qtuio/qtuio.mk +3 -3
index 9925f84..5fa10a7 100644
@@ -19,7 +19,7 @@ QTUIO_EXAMPLES = dials fingerpaint knobs pinchzoom
 ifeq ($(BR2_QTUIO_EXAMPLES),y)
 define QTUIO_CONFIGURE_EXAMPLES
 	for example in $(QTUIO_EXAMPLES) ; do \
-		(cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) ; \
+		(cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) || exit 1; \
 	done
 endef
 endif

@@ -32,7 +32,7 @@ endef
 ifeq ($(BR2_QTUIO_EXAMPLES),y)
 define QTUIO_BUILD_EXAMPLES
 	for example in $(QTUIO_EXAMPLES) ; do \
-		($(MAKE) -C $(@D)/examples/$${example}) ; \
+		$(MAKE) -C $(@D)/examples/$${example} || exit 1; \
 	done
 endef
 endif

@@ -46,7 +46,7 @@ endef
 ifeq ($(BR2_QTUIO_EXAMPLES),y)
 define QTUIO_INSTALL_EXAMPLES
 	for example in $(QTUIO_EXAMPLES) ; do \
-		($(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example}) ; \
+		$(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example} || exit 1 ; \
 	done
 endef
 endif
Signature · 1 line
2.1.0
#1 lore raw

PATCH v2 1/1 qtuio: add error handling to for loop

Thomas, All,

On 2014-12-03 23:05 +0100, Thomas Petazzoni spake thusly:

Quoted 10 lines

Also remove unneeded sub-shell usage in the build and installation steps. It is kept for the configure step as it is actually useful, and works fine because "|| exit 1" is outside the sub-shell.

Signed-off-by Thomas Petazzoni <[email protected]>

---
Changes v1 -> v2:
* Remove unneeded sub-shell usage, noticed by Yann E. Morin.

Signed-off-by Thomas Petazzoni <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 42 lines
---
 package/qtuio/qtuio.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/qtuio/qtuio.mk +3 -3
index 9925f84..5fa10a7 100644
@@ -19,7 +19,7 @@ QTUIO_EXAMPLES = dials fingerpaint knobs pinchzoom
 ifeq ($(BR2_QTUIO_EXAMPLES),y)
 define QTUIO_CONFIGURE_EXAMPLES
 	for example in $(QTUIO_EXAMPLES) ; do \
-		(cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) ; \
+		(cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) || exit 1; \
 	done
 endef
 endif

@@ -32,7 +32,7 @@ endef
 ifeq ($(BR2_QTUIO_EXAMPLES),y)
 define QTUIO_BUILD_EXAMPLES
 	for example in $(QTUIO_EXAMPLES) ; do \
-		($(MAKE) -C $(@D)/examples/$${example}) ; \
+		$(MAKE) -C $(@D)/examples/$${example} || exit 1; \
 	done
 endef
 endif

@@ -46,7 +46,7 @@ endef
 ifeq ($(BR2_QTUIO_EXAMPLES),y)
 define QTUIO_INSTALL_EXAMPLES
 	for example in $(QTUIO_EXAMPLES) ; do \
-		($(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example}) ; \
+		$(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example} || exit 1 ; \
 	done
 endef
 endif
Signature · 6 lines
2.1.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author Applied
#2 lore raw

PATCH v2 1/1 qtuio: add error handling to for loop

In reply to Thomas Petazzoni

Dear Thomas Petazzoni,

Quoted 5 lines · Thomas Petazzoni

Also remove unneeded sub-shell usage in the build and installation steps. It is kept for the configure step as it is actually useful, and works fine because "|| exit 1" is outside the sub-shell.

Signed-off-by Thomas Petazzoni <[email protected]>

Applied.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com