Skip to contentSkip to conversation

package/binutils: fix comment dependencies

PATCH New Romain Naour 3 participants 3 messages Dec 4, 2014 – Dec 7, 2014

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/1 package/binutils: fix comment dependencies

Signed-off-by Romain Naour <[email protected]>
---
 package/binutils/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/binutils/Config.in +2 -2
index 50c38b6..fb037ef 100644
@@ -22,5 +22,5 @@ config BR2_PACKAGE_BINUTILS_TARGET
 endif
 
 comment "binutils needs a toolchain w/ wchar"
-	depends on !BR2_aarch64 && !BR2_nios2
-	depends on BR2_USE_WCHAR
+	depends on !BR2_aarch64 || !BR2_nios2
+	depends on !BR2_USE_WCHAR
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 package/binutils: fix comment dependencies

Romain, All,

On 2014-12-04 22:11 +0100, Romain Naour spake thusly:

Quoted 10 lines
Signed-off-by Romain Naour <[email protected]>
---
 package/binutils/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/binutils/Config.in +0 -0
index 50c38b6..fb037ef 100644

package/binutils/Config.in config BR2_PACKAGE_BINUTILS_TARGET · line 25

Quoted 6 lines
package/binutils/Config.in +1 -2
@@ -22,5 +22,5 @@ config BR2_PACKAGE_BINUTILS_TARGET
 endif
 
 comment "binutils needs a toolchain w/ wchar"
-	depends on !BR2_aarch64 && !BR2_nios2
-	depends on BR2_USE_WCHAR
+	depends on !BR2_aarch64 || !BR2_nios2

Nope. Architecture dependency must be the same as for the package symbol, so we must keep the '&&' here, like there is for BR2_PACKAGE_BINUTILS.

package/binutils/Config.in config BR2_PACKAGE_BINUTILS_TARGET · line 26

Quoted 1 line
package/binutils/Config.in +1 -0
+	depends on !BR2_USE_WCHAR

Yes.

Regards,
Yann E. MORIN.

Quoted 7 lines
Signature · 6 lines
1.9.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/binutils: fix comment dependencies

In reply to Romain Naour

Dear Romain Naour,

Quoted 10 lines · Romain Naour
Signed-off-by Romain Naour <[email protected]>
---
 package/binutils/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/binutils/Config.in +0 -0
index 50c38b6..fb037ef 100644

package/binutils/Config.in config BR2_PACKAGE_BINUTILS_TARGET · line 25

Quoted 6 lines
package/binutils/Config.in +1 -2
@@ -22,5 +22,5 @@ config BR2_PACKAGE_BINUTILS_TARGET
 endif
 
 comment "binutils needs a toolchain w/ wchar"
-	depends on !BR2_aarch64 && !BR2_nios2
-	depends on BR2_USE_WCHAR
+	depends on !BR2_aarch64 || !BR2_nios2

I've kept that one as it was, as explained by Yann.

package/binutils/Config.in config BR2_PACKAGE_BINUTILS_TARGET · line 26

Quoted 1 line
package/binutils/Config.in +1 -0
+	depends on !BR2_USE_WCHAR

Committed, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com