arch/Config.in: Drop unused BR2_BINFMT_ELF
PATCH 1/1 arch/Config.in: Drop unused BR2_BINFMT_ELF
The BR2_BINFMT_ELF symbol (introduced in commit 57133825c930) can't possibly be selected because it depends on (!BR2_bfin && !BR2_m68k), while the surrounding choice depends on (BR2_bfin || BR2_m68k). This symbol is never used.
--- arch/Config.in | 8 -------- 1 file changed, 8 deletions(-)
arch/Config.in +0 -8
@@ -257,14 +257,6 @@ choice depends on BR2_bfin || BR2_m68k default BR2_BINFMT_FDPIC -config BR2_BINFMT_ELF - bool "ELF" - depends on !BR2_bfin && !BR2_m68k - help - ELF (Executable and Linkable Format) is a format for libraries and - executables used across different architectures and operating - systems. - config BR2_BINFMT_FDPIC bool "FDPIC" depends on BR2_bfin || BR2_m68k
Signature · 1 line
2.1.3
PATCH 1/1 arch/Config.in: Drop unused BR2_BINFMT_ELF
Dear Baruch Siach,
Quoted 11 lines · Baruch Siach
The
BR2_BINFMT_ELFsymbol (introduced in commit57133825c930) can't possibly be selected because it depends on (!BR2_bfin && !BR2_m68k), while the surrounding choice depends on (BR2_bfin||BR2_m68k). This symbol is never used.Cc Sonic Zhang <[email protected]>Cc Thomas Petazzoni <[email protected]>Signed-off-by Baruch Siach <[email protected]>--- arch/Config.in | 8 -------- 1 file changed, 8 deletions(-)
Well, it's true that it's never selected today. However, it can be useful in a number of situations, with some changes: better support for static/shared library selection, support for ARM noMMU, etc. For example, I have one commit in one of my branches that does this:
commit f31d45345e3e260b2942324e43b0a366ec279007
Author: Thomas Petazzoni <[email protected]> Date: Sat Sep 21 07:31:07 2013 +0200
arch: ensure BR2_BINFMT_ELF is really used
Currently, the binary format choice is only shown for the Blackfin and m68k architectures, since we assume that all other architectures are using the ELF binary format. However, due to this, the BR2_BINFMT_ELF symbol is in fact not set to 'y' for those architectures that use the ELF format.
This will be causing problems for the refactoring of the static/shared library support, as we will need to know if the binary format supports shared libraries or not.
Therefore, it moves out the BR2_BINFMT_ELF option outside of the choice, ensures it is enabled on all architectures but Blackfin and m68k, and turns the option within the choice into BR2_BINFMT_ELF_CHOICE (but in fact this option can never be seen at the moment, since it depends on !blackfin && !m68k, but the choice it self depends on blackfin || m68k).
arch/Config.in +6 -1
@@ -225,15 +225,20 @@ config BR2_GCC_TARGET_FLOAT_ABI config BR2_GCC_TARGET_MODE string +config BR2_BINFMT_ELF + bool + default y if !BR2_bfin && !BR2_m68k + # Set up target binary format choice prompt "Target Binary Format" depends on BR2_bfin || BR2_m68k default BR2_BINFMT_FDPIC -config BR2_BINFMT_ELF +config BR2_BINFMT_ELF_CHOICE bool "ELF" depends on !BR2_bfin && !BR2_m68k + select BR2_BINFMT_ELF help ELF (Executable and Linkable Format) is a format for libraries and executables used across different architectures and operating
However, I'm fine with BR2_BINFMT_ELF being removed for now, and re-added later when actually needed.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 arch/Config.in: Drop unused BR2_BINFMT_ELF
In reply to Baruch SiachBaruch, All,
On 2014-11-20 11:37 +0200, Baruch Siach spake thusly:
Quoted 8 lines
The
BR2_BINFMT_ELFsymbol (introduced in commit57133825c930) can't possibly be selected because it depends on (!BR2_bfin && !BR2_m68k), while the surrounding choice depends on (BR2_bfin||BR2_m68k). This symbol is never used.Cc Sonic Zhang <[email protected]>Cc Thomas Petazzoni <[email protected]>Signed-off-by Baruch Siach <[email protected]>
As Thomas P. said, he has a series that needs this symbol, and he now has posted that series to the list:
http://lists.busybox.net/pipermail/buildroot/2014-December/114192.html
So I've marked this patch "Superseded" in Patchowrk.
Thanks!
Regards,
Yann E. MORIN.
Quoted 30 lines
--- arch/Config.in | 8 -------- 1 file changed, 8 deletions(-)arch/Config.in +0
-8@@ -257,14 +257,6 @@ choice depends on BR2_bfin || BR2_m68k default BR2_BINFMT_FDPIC -config BR2_BINFMT_ELF - bool "ELF" - depends on !BR2_bfin && !BR2_m68k - help - ELF (Executable and Linkable Format) is a format for libraries and - executables used across different architectures and operating - systems. - config BR2_BINFMT_FDPIC bool "FDPIC" depends on BR2_bfin || BR2_m68kSignature · 6 lines
2.1.3 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'